[RFC,v2,1/1] rpc: Use libtirpc for all RPC tests + detect headers location

RPC implementation in glibc has been deprecated since glibc 2.16
(headers + bindings were available via --enable-obsolete-rpc) and other
libc ususaly don't implement rpc anyway, it's time to move on and link
against libtirpc. While this fixes problem on these libc
implementations, without libtirpc we obviously end up with no RPC tests.

openSUSE recently moved /usr/include/tirpc to /usr/include as part of
upgrade to glibc 2.27 [1]. Fedora is planning something similar [2].
That's why is needed to detect the correct location and use lapi header.

The reason doing it in one commit is not to break systems using still
/usr/include/tirpc for libtirpc headers:
In file included from ../../../../../../include/lapi/rpc.h:31:0,
                 from librpc01.c:19:
/usr/include/tirpc/rpc/rpc.h:74:10: fatal error: rpc/rpcb_clnt.h: No such file or directory
 #include <rpc/rpcb_clnt.h> /* rpcbind interface functions */

[1] https://build.opensuse.org/package/view_file/Base:System/libtirpc/libtirpc.changes?expand=1
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1537432

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Changes v1->v2:
* Removed 'LDLIBS += $(TIRPC_LIBS)' from testcases/network/rpc/Makefile
as it's not needed.
* More descriptive commit message.
---
 include/lapi/rpc.h                                 | 39 ++++++++++++++++++++++
 m4/ltp-tirpc.m4                                    |  2 +-
 testcases/network/Makefile                         |  4 +++
 testcases/network/rpc/Makefile                     |  4 ---
 testcases/network/rpc/basic_tests/rpc01/Makefile   |  1 +
 .../network/rpc/basic_tests/rpc01/lib/Makefile     |  1 +
 .../network/rpc/basic_tests/rpc01/lib/librpc01.c   |  2 +-
 .../network/rpc/basic_tests/rpc01/lib/librpc01.h   |  2 +-
 .../rpc_stdcall_clnt_call/rpc_clnt_call_complex.c  |  4 +--
 .../tirpc_rpcb_getaddr.c                           |  4 +--
 .../tirpc_rpcb_getaddr_limits.c                    |  2 +-
 .../tirpc_rpcb_getmaps.c                           |  4 +--
 .../tirpc_authdes_create.c                         |  2 +-
 .../tirpc_authdes_seccreate.c                      |  2 +-
 .../tirpc_authnone_create.c                        |  2 +-
 .../tirpc_authsys_create.c                         |  2 +-
 .../tirpc_authsys_create_default.c                 |  2 +-
 .../tirpc_bottomlevel_clnt_call.c                  |  4 +--
 .../tirpc_bottomlevel_clnt_call_complex.c          |  6 +---
 .../tirpc_bottomlevel_clnt_call_dataint.c          |  2 +-
 .../tirpc_bottomlevel_clnt_call_mt.c               |  6 +---
 .../tirpc_bottomlevel_clnt_call_performance.c      |  2 +-
 .../tirpc_bottomlevel_clnt_call_scalability.c      |  6 +---
 .../tirpc_bottomlevel_clnt_call_stress.c           |  4 +--
 .../tirpc_clnt_dg_create.c                         |  4 +--
 .../tirpc_clnt_dg_create_limits.c                  |  2 +-
 .../tirpc_clnt_vc_create.c                         |  4 +--
 .../tirpc_clnt_vc_create_limits.c                  |  2 +-
 .../tirpc_svc_dg_create.c                          |  4 +--
 .../tirpc_svc_dg_create_limits.c                   |  2 +-
 .../tirpc_svc_vc_create.c                          |  4 +--
 .../tirpc_svc_vc_create_limits.c                   |  2 +-
 .../tirpc_clnt_pcreateerror.c                      |  4 +--
 .../tirpc_err_clnt_perrno/tirpc_clnt_perrno.c      |  6 +---
 .../tirpc_clnt_perrno_complex.c                    |  6 +---
 .../tirpc_err_clnt_perror/tirpc_clnt_perror.c      |  6 +---
 .../tirpc_clnt_perror_complex.c                    |  6 +---
 .../tirpc_err_svcerr_noproc/tirpc_svcerr_noproc.c  |  4 +--
 .../tirpc_err_svcerr_noprog/tirpc_svcerr_noprog.c  |  4 +--
 .../tirpc_svcerr_progvers.c                        |  4 +--
 .../tirpc_svcerr_systemerr.c                       |  4 +--
 .../tirpc_svcerr_weakauth.c                        |  4 +--
 .../tirpc_expertlevel_clnt_call.c                  |  4 +--
 .../tirpc_expertlevel_clnt_call_complex.c          |  6 +---
 .../tirpc_expertlevel_clnt_call_dataint.c          |  2 +-
 .../tirpc_expertlevel_clnt_call_mt.c               |  6 +---
 .../tirpc_expertlevel_clnt_call_performance.c      |  2 +-
 .../tirpc_expertlevel_clnt_call_scalability.c      |  6 +---
 .../tirpc_expertlevel_clnt_call_stress.c           |  4 +--
 .../tirpc_clnt_tli_create.c                        |  4 +--
 .../tirpc_clnt_tli_create_limits.c                 |  2 +-
 .../tirpc_rpcb_rmtcall.c                           |  4 +--
 .../tirpc_rpcb_rmtcall_complex.c                   |  6 +---
 .../tirpc_rpcb_rmtcall_dataint.c                   |  2 +-
 .../tirpc_rpcb_rmtcall_mt.c                        |  6 +---
 .../tirpc_rpcb_rmtcall_performance.c               |  2 +-
 .../tirpc_rpcb_rmtcall_scalability.c               |  6 +---
 .../tirpc_rpcb_rmtcall_stress.c                    |  4 +--
 .../tirpc_expertlevel_rpcb_set/tirpc_rpcb_set.c    |  4 +--
 .../tirpc_rpcb_unset.c                             |  4 +--
 .../tirpc_expertlevel_svc_reg/tirpc_svc_reg.c      |  4 +--
 .../tirpc_expertlevel_svc_reg/tirpc_svc_reg_mt.c   |  6 +---
 .../tirpc_svc_reg_stress.c                         |  4 +--
 .../tirpc_svc_tli_create.c                         |  4 +--
 .../tirpc_svc_tli_create_limits.c                  |  2 +-
 .../tirpc_expertlevel_svc_unreg/tirpc_svc_unreg.c  |  4 +--
 .../tirpc_svc_unreg_mt.c                           |  6 +---
 .../tirpc_svc_unreg_stress.c                       |  4 +--
 .../tirpc_interlevel_clnt_call.c                   |  6 +---
 .../tirpc_interlevel_clnt_call_complex.c           |  6 +---
 .../tirpc_interlevel_clnt_call_dataint.c           |  2 +-
 .../tirpc_interlevel_clnt_call_mt.c                |  6 +---
 .../tirpc_interlevel_clnt_call_performance.c       |  2 +-
 .../tirpc_interlevel_clnt_call_scalability.c       |  6 +---
 .../tirpc_interlevel_clnt_call_stress.c            |  6 +---
 .../tirpc_clnt_control.c                           |  7 +---
 .../tirpc_clnt_control_limits.c                    |  2 +-
 .../tirpc_clnt_tp_create.c                         |  7 +---
 .../tirpc_clnt_tp_create_timed.c                   |  6 +---
 .../tirpc_clnt_tp_create_timed_limits.c            |  2 +-
 .../tirpc_svc_tp_create.c                          |  6 +---
 .../tirpc_rpc_broadcast.c                          |  6 +---
 .../tirpc_rpc_broadcast_complex.c                  |  2 +-
 .../tirpc_rpc_broadcast_dataint.c                  |  2 +-
 .../tirpc_rpc_broadcast_mt.c                       |  6 +---
 .../tirpc_rpc_broadcast_performance.c              |  2 +-
 .../tirpc_rpc_broadcast_scalability.c              |  6 +---
 .../tirpc_rpc_broadcast_stress.c                   |  6 +---
 .../tirpc_rpc_broadcast_exp.c                      |  6 +---
 .../tirpc_rpc_broadcast_exp_complex.c              |  2 +-
 .../tirpc_rpc_broadcast_exp_dataint.c              |  2 +-
 .../tirpc_rpc_broadcast_exp_limits.c               |  2 +-
 .../tirpc_rpc_broadcast_exp_mt.c                   |  6 +---
 .../tirpc_rpc_broadcast_exp_performance.c          |  2 +-
 .../tirpc_rpc_broadcast_exp_scalability.c          |  6 +---
 .../tirpc_rpc_broadcast_exp_stress.c               |  6 +---
 .../tirpc/tirpc_simple_rpc_call/tirpc_rpc_call.c   |  6 +---
 .../tirpc_simple_rpc_call/tirpc_rpc_call_complex.c |  6 +---
 .../tirpc_simple_rpc_call/tirpc_rpc_call_dataint.c |  2 +-
 .../tirpc_simple_rpc_call/tirpc_rpc_call_mt.c      |  6 +---
 .../tirpc_rpc_call_performance.c                   |  2 +-
 .../tirpc_rpc_call_scalability.c                   |  6 +---
 .../tirpc_simple_rpc_call/tirpc_rpc_call_stress.c  |  6 +---
 .../tirpc/tirpc_simple_rpc_reg/tirpc_rpc_reg.c     |  6 +---
 .../tirpc/tirpc_simple_rpc_reg/tirpc_rpc_reg_mt.c  |  6 +---
 .../tirpc_simple_rpc_reg/tirpc_rpc_reg_stress.c    |  6 +---
 .../tirpc_toplevel_clnt_call.c                     |  6 +---
 .../tirpc_toplevel_clnt_call_complex.c             |  6 +---
 .../tirpc_toplevel_clnt_call_dataint.c             |  2 +-
 .../tirpc_toplevel_clnt_call_mt.c                  |  6 +---
 .../tirpc_toplevel_clnt_call_performance.c         |  2 +-
 .../tirpc_toplevel_clnt_call_scalability.c         |  6 +---
 .../tirpc_toplevel_clnt_call_stress.c              |  6 +---
 .../tirpc_toplevel_clnt_create/tirpc_clnt_create.c |  6 +---
 .../tirpc_clnt_create_timed.c                      |  6 +---
 .../tirpc_clnt_create_timed_limits.c               |  2 +-
 .../tirpc_clnt_destroy.c                           |  6 +---
 .../tirpc_toplevel_svc_create/tirpc_svc_create.c   |  6 +---
 .../tirpc_toplevel_svc_destroy/tirpc_svc_destroy.c |  6 +---
 .../rpc/rpc-tirpc/tests_pack/tirpc_cleaner.c       |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_1/tirpc_svc_1.c |  6 +---
 .../tests_pack/tirpc_svc_11/tirpc_svc_11.c         |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_2/tirpc_svc_2.c |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_3/tirpc_svc_3.c |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_4/tirpc_svc_4.c |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_5/tirpc_svc_5.c |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_6/tirpc_svc_6.c |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_7/tirpc_svc_7.c |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_8/tirpc_svc_8.c |  6 +---
 .../rpc-tirpc/tests_pack/tirpc_svc_9/tirpc_svc_9.c |  6 +---
 130 files changed, 170 insertions(+), 429 deletions(-)
 create mode 100644 include/lapi/rpc.h

Message ID	20180306124322.28876-1-pvorel@suse.cz
State	Accepted
Delegated to:	Petr Vorel
Headers	show Return-Path: <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it> From: Petr Vorel <pvorel@suse.cz> To: ltp@lists.linux.it Date: Tue, 6 Mar 2018 13:43:22 +0100 Message-Id: <20180306124322.28876-1-pvorel@suse.cz> Subject: [LTP] [RFC PATCH v2 1/1] rpc: Use libtirpc for all RPC tests + detect headers location Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>
Series	[RFC,v2,1/1] rpc: Use libtirpc for all RPC tests + detect headers location \| expand [RFC,v2,1/1] rpc: Use libtirpc for all RPC tests + detect headers location

[RFC,v2,1/1] rpc: Use libtirpc for all RPC tests + detect headers location

Commit Message

Comments

Patch