mbox series

[v4,0/4] tst_device.c: Handle Android path for backing device

Message ID 20230327161145.1702680-1-edliaw@google.com
Headers show
Series tst_device.c: Handle Android path for backing device | expand

Message

Edward Liaw March 27, 2023, 4:11 p.m. UTC 
e1b1ae66b240 ("tst_find_backing_dev: Get dev name from
/sys/dev/block/*/uevent") added a hardcoded path to check for the
backing device in /dev.  On Android, it needs to check /dev/block.

The set_dev_path function was renamed to set_dev_loop_path and its
return value was changed from 1 on success to 0 on success to be more
consistent with other functions.  A check was added to
tst_find_free_loopdev in the event that the loop device is not ready
yet, which appears to happen occasionally on Android.

v1->v2:
Changed the function signature of tst_find_backing_dev to add the length
of the path string.  Updated all references for this function to include
the added parameter.

v2->v3:
Split the function rename, return value change, and the return value
check into 3 commits.  Fixed logic for non-NULL path check.  Added Fixes
tag for e1b1ae66b240.

v3->v4:
Rename dev_len argument to dev_size and update documentation and
references.  Remove != 0 as it is redundant. 

Edward Liaw (4):
  set_dev_path: Rename to set_dev_loop_path
  set_dev_loop_path: Change return value to zero on success
  tst_find_free_loopdev: Check return value of set_dev_loop_path
  tst_find_backing_dev: Also check /dev/block/ for backing device

 doc/c-test-api.txt                            |  2 +-
 include/tst_device.h                          |  7 +--
 lib/newlib_tests/tst_device.c                 |  2 +-
 lib/tst_device.c                              | 51 ++++++++++++-------
 .../kernel/syscalls/ioctl/ioctl_loop05.c      |  2 +-
 5 files changed, 40 insertions(+), 24 deletions(-)

Comments

Li Wang March 28, 2023, 2:40 a.m. UTC | #1 
Hi Edward, All,

Nice work. Patchset applied, thanks!