diff mbox series

[net-next,v3,05/10] net: freescale: ucc_geth: Use the correct type to store WoL opts

Message ID 20241203124323.155866-6-maxime.chevallier@bootlin.com (mailing list archive)
State Handled Elsewhere
Headers show
Series net: freescale: ucc_geth: Phylink conversion | expand

Commit Message

Maxime Chevallier Dec. 3, 2024, 12:43 p.m. UTC 
The WoL opts are represented through a bitmask stored in a u32. As this
mask is copied as-is in the driver, make sure we use the exact same type
to store them internally.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
V3: No changes

 drivers/net/ethernet/freescale/ucc_geth.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn Dec. 4, 2024, 1:59 a.m. UTC | #1 
On Tue, Dec 03, 2024 at 01:43:16PM +0100, Maxime Chevallier wrote:
> The WoL opts are represented through a bitmask stored in a u32. As this
> mask is copied as-is in the driver, make sure we use the exact same type
> to store them internally.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/ucc_geth.h b/drivers/net/ethernet/freescale/ucc_geth.h
index e08cfc8d8904..60fd804a616a 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.h
+++ b/drivers/net/ethernet/freescale/ucc_geth.h
@@ -1216,7 +1216,7 @@  struct ucc_geth_private {
 	int oldspeed;
 	int oldduplex;
 	int oldlink;
-	int wol_en;
+	u32 wol_en;
 	u32 phy_wol_en;
 
 	struct device_node *node;