| Message ID | 20210503102323.17804-1-msuchanek@suse.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | ibmvnic: remove default label from to_string switch | expand |
| Related | show |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | warning | Failed to apply on branch powerpc/merge (e3a9b9d6a03f5fbf99b540e863b001d46ba1735c) |
| snowpatch_ozlabs/apply_patch | warning | Failed to apply on branch powerpc/next (5256426247837feb8703625bda7fcfc824af04cf) |
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch linus/master (9ccce092fc64d19504fa54de4fd659e279cc92e7) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 20 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Mon, May 3, 2021 at 5:54 AM Michal Suchanek <msuchanek@suse.de> wrote: > > This way the compiler warns when a new value is added to the enum but > not the string transation like: s/transation/translation/ This trick works. Since the original code does not generate gcc warnings/errors, should this patch be sent to net-next as an improvement? > > drivers/net/ethernet/ibm/ibmvnic.c: In function 'adapter_state_to_string': > drivers/net/ethernet/ibm/ibmvnic.c:832:2: warning: enumeration value 'VNIC_FOOBAR' not handled in switch [-Wswitch] > switch (state) { > ^~~~~~ > drivers/net/ethernet/ibm/ibmvnic.c: In function 'reset_reason_to_string': > drivers/net/ethernet/ibm/ibmvnic.c:1935:2: warning: enumeration value 'VNIC_RESET_FOOBAR' not handled in switch [-Wswitch] > switch (reason) { > ^~~~~~ > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > --- Acked-by: Lijun Pan <lijunp213@gmail.com> > drivers/net/ethernet/ibm/ibmvnic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c > index 5788bb956d73..4d439413f6d9 100644 > --- a/drivers/net/ethernet/ibm/ibmvnic.c > +++ b/drivers/net/ethernet/ibm/ibmvnic.c > @@ -846,9 +846,8 @@ static const char *adapter_state_to_string(enum vnic_state state) > return "REMOVING"; > case VNIC_REMOVED: > return "REMOVED"; > - default: > - return "UNKNOWN"; > } > + return "UNKNOWN"; > } > > static int ibmvnic_login(struct net_device *netdev) > @@ -1946,9 +1945,8 @@ static const char *reset_reason_to_string(enum ibmvnic_reset_reason reason) > return "TIMEOUT"; > case VNIC_RESET_CHANGE_PARAM: > return "CHANGE_PARAM"; > - default: > - return "UNKNOWN"; > } > + return "UNKNOWN"; > } > > /* > -- > 2.26.2 >
From: Lijun Pan <lijunp213@gmail.com> Date: Mon, 3 May 2021 13:21:00 -0500 > On Mon, May 3, 2021 at 5:54 AM Michal Suchanek <msuchanek@suse.de> wrote: >> >> This way the compiler warns when a new value is added to the enum but >> not the string transation like: > > s/transation/translation/ > > This trick works. > Since the original code does not generate gcc warnings/errors, should > this patch be sent to net-next as an improvement? Yes.
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 5788bb956d73..4d439413f6d9 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -846,9 +846,8 @@ static const char *adapter_state_to_string(enum vnic_state state) return "REMOVING"; case VNIC_REMOVED: return "REMOVED"; - default: - return "UNKNOWN"; } + return "UNKNOWN"; } static int ibmvnic_login(struct net_device *netdev) @@ -1946,9 +1945,8 @@ static const char *reset_reason_to_string(enum ibmvnic_reset_reason reason) return "TIMEOUT"; case VNIC_RESET_CHANGE_PARAM: return "CHANGE_PARAM"; - default: - return "UNKNOWN"; } + return "UNKNOWN"; } /*
This way the compiler warns when a new value is added to the enum but not the string transation like: drivers/net/ethernet/ibm/ibmvnic.c: In function 'adapter_state_to_string': drivers/net/ethernet/ibm/ibmvnic.c:832:2: warning: enumeration value 'VNIC_FOOBAR' not handled in switch [-Wswitch] switch (state) { ^~~~~~ drivers/net/ethernet/ibm/ibmvnic.c: In function 'reset_reason_to_string': drivers/net/ethernet/ibm/ibmvnic.c:1935:2: warning: enumeration value 'VNIC_RESET_FOOBAR' not handled in switch [-Wswitch] switch (reason) { ^~~~~~ Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- drivers/net/ethernet/ibm/ibmvnic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)