| Message ID | cover.1633104510.git.naveen.n.rao@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | powerpc/bpf: Various fixes | expand |
On Fri, Oct 1, 2021 at 11:15 PM Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> wrote: > > Various fixes to the eBPF JIT for powerpc, thanks to some new tests > added by Johan. This series fixes all failures in test_bpf on powerpc64. > There are still some failures on powerpc32 to be looked into. Great work! I have tested it on powerpc64 in QEMU, which is the same setup that previously triggered an illegal instruction, and all tests pass now. On powerpc32 there are still some issues left as you say. Thanks! Johan > > - Naveen > > > Naveen N. Rao (8): > powerpc/lib: Add helper to check if offset is within conditional > branch range > powerpc/bpf: Validate branch ranges > powerpc/bpf: Handle large branch ranges with BPF_EXIT > powerpc/bpf: Fix BPF_MOD when imm == 1 > powerpc/bpf: Fix BPF_SUB when imm == 0x80000000 > powerpc/bpf: Limit 'ldbrx' to processors compliant with ISA v2.06 > powerpc/security: Add a helper to query stf_barrier type > powerpc/bpf: Emit stf barrier instruction sequences for BPF_NOSPEC > > Ravi Bangoria (1): > powerpc/bpf: Remove unused SEEN_STACK > > arch/powerpc/include/asm/code-patching.h | 1 + > arch/powerpc/include/asm/ppc-opcode.h | 1 + > arch/powerpc/include/asm/security_features.h | 5 + > arch/powerpc/kernel/security.c | 5 + > arch/powerpc/lib/code-patching.c | 7 +- > arch/powerpc/net/bpf_jit.h | 39 ++++--- > arch/powerpc/net/bpf_jit64.h | 8 +- > arch/powerpc/net/bpf_jit_comp.c | 28 ++++- > arch/powerpc/net/bpf_jit_comp32.c | 10 +- > arch/powerpc/net/bpf_jit_comp64.c | 113 ++++++++++++++----- > 10 files changed, 167 insertions(+), 50 deletions(-) > > > base-commit: 044c2d99d9f43c6d6fde8bed00672517dd9a5a57 > -- > 2.33.0 >
Hi Johan, Johan Almbladh wrote: > On Fri, Oct 1, 2021 at 11:15 PM Naveen N. Rao > <naveen.n.rao@linux.vnet.ibm.com> wrote: >> >> Various fixes to the eBPF JIT for powerpc, thanks to some new tests >> added by Johan. This series fixes all failures in test_bpf on powerpc64. >> There are still some failures on powerpc32 to be looked into. > > Great work! I have tested it on powerpc64 in QEMU, which is the same > setup that previously triggered an illegal instruction, and all tests > pass now. On powerpc32 there are still some issues left as you say. Thanks for the review, and the test! - Naveen
Various fixes to the eBPF JIT for powerpc, thanks to some new tests added by Johan. This series fixes all failures in test_bpf on powerpc64. There are still some failures on powerpc32 to be looked into. - Naveen Naveen N. Rao (8): powerpc/lib: Add helper to check if offset is within conditional branch range powerpc/bpf: Validate branch ranges powerpc/bpf: Handle large branch ranges with BPF_EXIT powerpc/bpf: Fix BPF_MOD when imm == 1 powerpc/bpf: Fix BPF_SUB when imm == 0x80000000 powerpc/bpf: Limit 'ldbrx' to processors compliant with ISA v2.06 powerpc/security: Add a helper to query stf_barrier type powerpc/bpf: Emit stf barrier instruction sequences for BPF_NOSPEC Ravi Bangoria (1): powerpc/bpf: Remove unused SEEN_STACK arch/powerpc/include/asm/code-patching.h | 1 + arch/powerpc/include/asm/ppc-opcode.h | 1 + arch/powerpc/include/asm/security_features.h | 5 + arch/powerpc/kernel/security.c | 5 + arch/powerpc/lib/code-patching.c | 7 +- arch/powerpc/net/bpf_jit.h | 39 ++++--- arch/powerpc/net/bpf_jit64.h | 8 +- arch/powerpc/net/bpf_jit_comp.c | 28 ++++- arch/powerpc/net/bpf_jit_comp32.c | 10 +- arch/powerpc/net/bpf_jit_comp64.c | 113 ++++++++++++++----- 10 files changed, 167 insertions(+), 50 deletions(-) base-commit: 044c2d99d9f43c6d6fde8bed00672517dd9a5a57