mbox series

[net-next,0/4] net: ucc_geth: devm cleanups

Message ID 20241104210127.307420-1-rosenp@gmail.com (mailing list archive)
Headers show
Series net: ucc_geth: devm cleanups | expand

Message

Rosen Penev Nov. 4, 2024, 9:01 p.m. UTC 
Also added a small fix for NVMEM mac addresses.

This was tested as working on a Watchguard T10 device.

Rosen Penev (4):
  net: ucc_geth: use devm for kmemdup
  net: ucc_geth: use devm for alloc_etherdev
  net: ucc_geth: use devm for register_netdev
  net: ucc_geth: fix usage with NVMEM MAC address

 drivers/net/ethernet/freescale/ucc_geth.c | 34 ++++++++++-------------
 1 file changed, 14 insertions(+), 20 deletions(-)

Comments

Rosen Penev Nov. 5, 2024, 1:35 a.m. UTC | #1 
On Mon, Nov 4, 2024 at 1:01 PM Rosen Penev <rosenp@gmail.com> wrote:
>
> Also added a small fix for NVMEM mac addresses.
>
> This was tested as working on a Watchguard T10 device.
>
> Rosen Penev (4):
>   net: ucc_geth: use devm for kmemdup
>   net: ucc_geth: use devm for alloc_etherdev
>   net: ucc_geth: use devm for register_netdev
>   net: ucc_geth: fix usage with NVMEM MAC address
oh this is interesting

_remove calls platform_get_drvdata but platform_set_drvdata never gets
called. I believe that means _remove is operating on a NULL pointer.
>
>  drivers/net/ethernet/freescale/ucc_geth.c | 34 ++++++++++-------------
>  1 file changed, 14 insertions(+), 20 deletions(-)
>
> --
> 2.47.0
>