| Message ID | 1592471945-24786-1-git-send-email-linuxram@us.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Migrate non-migrated pages of a SVM. | expand |
I should have elaborated on the problem and the need for these patches. Explaining it here. Will add it to the series in next version. ------------------------------------------------------------- The time taken to switch a VM to Secure-VM, increases by the size of the VM. A 100GB VM takes about 7minutes. This is unacceptable. This linear increase is caused by a suboptimal behavior by the Ultravisor and the Hypervisor. The Ultravisor unnecessarily migrates all the GFN of the VM from normal-memory to secure-memory. It has to just migrate the necessary and sufficient GFNs. However when the optimization is incorporated in the Ultravisor, the Hypervisor starts misbehaving. The Hypervisor has a inbuilt assumption that the Ultravisor will explicitly request to migrate, each and every GFN of the VM. If only necessary and sufficient GFNs are requested for migration, the Hypervisor continues to manage the rest of the GFNs are normal GFNs. This leads of memory corruption, manifested consistently when the SVM reboots. The same is true, when a memory slot is hotplugged into a SVM. The Hypervisor expects the ultravisor to request migration of all GFNs to secure-GFN. But at the same time the hypervisor is unable to handle any H_SVM_PAGE_IN requests from the Ultravisor, done in the context of UV_REGISTER_MEM_SLOT ucall. This problem manifests as random errors in the SVM, when a memory-slot is hotplugged. This patch series automatically migrates the non-migrated pages of a SVM, and thus solves the problem. ------------------------------------------------------------------ On Thu, Jun 18, 2020 at 02:19:01AM -0700, Ram Pai wrote: > This patch series migrates the non-migrated pages of a SVM. > This is required when the UV calls H_SVM_INIT_DONE, and > when a memory-slot is hotplugged to a Secure VM. > > Testing: Passed rigorous SVM reboot test using different > sized SVMs. > > Changelog: > . fixed a bug observed by Bharata. Pages that > where paged-in and later paged-out must also be > skipped from migration during H_SVM_INIT_DONE. > > Laurent Dufour (1): > KVM: PPC: Book3S HV: migrate hot plugged memory > > Ram Pai (3): > KVM: PPC: Book3S HV: Fix function definition in book3s_hv_uvmem.c > KVM: PPC: Book3S HV: track the state GFNs associated with secure VMs > KVM: PPC: Book3S HV: migrate remaining normal-GFNs to secure-GFNs in > H_SVM_INIT_DONE > > Documentation/powerpc/ultravisor.rst | 2 + > arch/powerpc/include/asm/kvm_book3s_uvmem.h | 8 +- > arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- > arch/powerpc/kvm/book3s_hv.c | 12 +- > arch/powerpc/kvm/book3s_hv_uvmem.c | 449 ++++++++++++++++++++++------ > 5 files changed, 368 insertions(+), 105 deletions(-) > > -- > 1.8.3.1
This patch series migrates the non-migrated pages of a SVM. This is required when the UV calls H_SVM_INIT_DONE, and when a memory-slot is hotplugged to a Secure VM. Testing: Passed rigorous SVM reboot test using different sized SVMs. Changelog: . fixed a bug observed by Bharata. Pages that where paged-in and later paged-out must also be skipped from migration during H_SVM_INIT_DONE. Laurent Dufour (1): KVM: PPC: Book3S HV: migrate hot plugged memory Ram Pai (3): KVM: PPC: Book3S HV: Fix function definition in book3s_hv_uvmem.c KVM: PPC: Book3S HV: track the state GFNs associated with secure VMs KVM: PPC: Book3S HV: migrate remaining normal-GFNs to secure-GFNs in H_SVM_INIT_DONE Documentation/powerpc/ultravisor.rst | 2 + arch/powerpc/include/asm/kvm_book3s_uvmem.h | 8 +- arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- arch/powerpc/kvm/book3s_hv.c | 12 +- arch/powerpc/kvm/book3s_hv_uvmem.c | 449 ++++++++++++++++++++++------ 5 files changed, 368 insertions(+), 105 deletions(-)