| Message ID | 20240816015447.320394-5-tiwei.btw@antgroup.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Some minor cleanups for UML | expand |
Hi Tiwei, On Fri, 2024-08-16 at 09:54 +0800, Tiwei Bie wrote: > It's no longer used since the removal of the SKAS3/4 support. > > Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> > --- > arch/um/include/shared/skas/mm_id.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/um/include/shared/skas/mm_id.h > b/arch/um/include/shared/skas/mm_id.h > index 1e76ba40feba..b3571a8afec9 100644 > --- a/arch/um/include/shared/skas/mm_id.h > +++ b/arch/um/include/shared/skas/mm_id.h > @@ -8,7 +8,6 @@ > > struct mm_id { > union { > - int mm_fd; > int pid; > } u; > unsigned long stack; Maybe we should also remove the union here while at it? It is pretty pointless after all. Benjamin
Hi Benjamin, On 2024/8/16 13:59, Benjamin Berg wrote: > Hi Tiwei, > > On Fri, 2024-08-16 at 09:54 +0800, Tiwei Bie wrote: >> It's no longer used since the removal of the SKAS3/4 support. >> >> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> >> --- >> arch/um/include/shared/skas/mm_id.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/um/include/shared/skas/mm_id.h >> b/arch/um/include/shared/skas/mm_id.h >> index 1e76ba40feba..b3571a8afec9 100644 >> --- a/arch/um/include/shared/skas/mm_id.h >> +++ b/arch/um/include/shared/skas/mm_id.h >> @@ -8,7 +8,6 @@ >> >> struct mm_id { >> union { >> - int mm_fd; >> int pid; >> } u; >> unsigned long stack; > > Maybe we should also remove the union here while at it? It is pretty > pointless after all. That makes sense. Will do. Thanks! Regards, Tiwei > > Benjamin
diff --git a/arch/um/include/shared/skas/mm_id.h b/arch/um/include/shared/skas/mm_id.h index 1e76ba40feba..b3571a8afec9 100644 --- a/arch/um/include/shared/skas/mm_id.h +++ b/arch/um/include/shared/skas/mm_id.h @@ -8,7 +8,6 @@ struct mm_id { union { - int mm_fd; int pid; } u; unsigned long stack;
It's no longer used since the removal of the SKAS3/4 support. Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> --- arch/um/include/shared/skas/mm_id.h | 1 - 1 file changed, 1 deletion(-)