From patchwork Fri Nov 3 16:41:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Beichler X-Patchwork-Id: 1858991 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=01CVBcDK; dkim=fail reason="signature verification failed" header.d=uni-rostock.de header.i=@uni-rostock.de header.a=ed25519-sha256 header.s=itmze header.b=nQy1UTJt; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=uni-rostock.de header.i=@uni-rostock.de header.a=rsa-sha256 header.s=itmz header.b=ZZgULq9q; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SMRP14Nnrz1yR2 for ; Sat, 4 Nov 2023 03:42:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:CC:To:In-Reply-To:References:Message-ID :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+jvtFvr0gSrmwoP8+7sqSAaCVUA4OXSNAsQbLkULeY4=; b=01CVBcDK0gvkIu TnyYQ6adqxewWmEKU/qojULZxLqsFIOh0MwSTb0mbjeRJvbBV2xKDyUl02OOMU1hC2WwmKPsT2drg apt6W7bnSmc/0OnfnW33bh2yCeOn2k6XbobYoOLp+MEyYLZgPweeklBZ1vPIE1+p0/dIioNk/NP4q kJVrYaxx2/3YDFn+wDRkmf5Mk3mq3l16Fkn2Z5D/wPR/O+7llxMlYWU1vXXnlNExHNQK6TJXu/6eO 0JHFwJdjBNjJZrQjw4CYnW7N3GZjF5DW56l5FQ9tP8PcAUSJF1i3XKN5Va/D+IaDA7NAWGwwOqQVb JtRkDN5lP71TKVJI5DqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyxFP-00BnlG-2u; Fri, 03 Nov 2023 16:42:15 +0000 Received: from mx1.uni-rostock.de ([139.30.22.71]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyxFJ-00BnjX-0e for linux-um@lists.infradead.org; Fri, 03 Nov 2023 16:42:13 +0000 Received: from 139.30.22.84 by mx1.uni-rostock.de (Tls12, Aes256, Sha384, DiffieHellmanEllipticKey384); Fri, 03 Nov 2023 16:42:01 GMT DKIM-Signature: v=1; c=relaxed/relaxed; d=uni-rostock.de; s=itmze; t=1699029721; bh=kWrrIs3UtL45ZMJGNIGiwZAwEr1yJtlRhqWcnVdyS3M=; h= Subject:Subject:From:From:Date:Date:ReplyTo:ReplyTo:Cc:Cc:Message-Id:Message-Id; a=ed25519-sha256; b= nQy1UTJtmzTMXs7dnfMkPljyDyDKeco7iQq+AZmZ+WUrXR+2mW1P5phKshdtYG78VcMPiJnzcxpzsQpUEIABDg== DKIM-Signature: v=1; c=relaxed/relaxed; d=uni-rostock.de; s=itmz; t=1699029721; bh=kWrrIs3UtL45ZMJGNIGiwZAwEr1yJtlRhqWcnVdyS3M=; h= Subject:Subject:From:From:Date:Date:ReplyTo:ReplyTo:Cc:Cc:Message-Id:Message-Id; a=rsa-sha256; b= ZZgULq9qoyKlDIC+5CuNb++uKi+85nc9MXxlss3zdaZYK9CioT/JHVO6zO7a7j+9xETSDwRsVrjwPae2qM9WccShw27w4ml4Owk2Y8gJhsnGZ8wJ9y8Hi/m2/ofOb7LiMZnkGbgc95yj03ewtApOexMEIXH91mMIOtlhd3gkrhk= Received: from mininet-experimente.amd.e-technik.uni-rostock.de (139.30.201.3) by mail1.uni-rostock.de (139.30.22.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Fri, 3 Nov 2023 17:41:57 +0100 From: Benjamin Beichler Date: Fri, 3 Nov 2023 16:41:41 +0000 Subject: [PATCH RFC 03/11] um: Use a simple time travel handler for line interrupts MIME-Version: 1.0 Message-ID: <20231103-bb-timetravel-patches-v1-3-e2c68efcf664@uni-rostock.de> References: <20231103-bb-timetravel-patches-v1-0-e2c68efcf664@uni-rostock.de> In-Reply-To: <20231103-bb-timetravel-patches-v1-0-e2c68efcf664@uni-rostock.de> To: Richard Weinberger , Anton Ivanov , Johannes Berg CC: , Benjamin Beichler X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1699029716; l=1390; i=benjamin.beichler@uni-rostock.de; s=20231103; h=from:subject:message-id; bh=oUWecdXr0IF2cOLtLivJrlkjjt6eZJH7/VVzHS9ciVE=; b=zaAuDZsKJxWnDBsc4lAjUI18JRDA5m5ST4ri+sTj7B9S2XCFJWJcE0oITsanJKYzTGGCciGrj 9JR5lgRmRnOCzz5YObV7jWv8LCcB9sagqxfehLTY0IZZFOPVUHUqr7g X-Developer-Key: i=benjamin.beichler@uni-rostock.de; a=ed25519; pk=fla2/IRwqFWH5W+fACqQyDu/mTc6mEcSPQtqb/SoX8o= X-Originating-IP: [139.30.201.3] X-ClientProxiedBy: email3.uni-rostock.de (139.30.22.83) To mail1.uni-rostock.de (139.30.22.84) X-TM-SNTS-SMTP: A08383C23EFA02E0CC8E04C6DF65119EBAE7CC12EABFED830CCA4D2528192B8B2000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231103_094210_125330_74D47C79 X-CRM114-Status: UNSURE ( 9.41 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.9 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This change permits interrupts on serial lines in time travel mode, especially in external mode. However, these interrupts are processed with the simple handler that does not provide any acknowledgmen [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [139.30.22.71 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This change permits interrupts on serial lines in time travel mode, especially in external mode. However, these interrupts are processed with the simple handler that does not provide any acknowledgment. Signed-off-by: Benjamin Beichler --- arch/um/drivers/line.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c index b98545f3edb5..3cda0ae41824 100644 --- a/arch/um/drivers/line.c +++ b/arch/um/drivers/line.c @@ -260,9 +260,9 @@ int line_setup_irq(int fd, int input, int output, struct line *line, void *data) int err; if (input) { - err = um_request_irq(UM_IRQ_ALLOC, fd, IRQ_READ, + err = um_request_irq_tt(UM_IRQ_ALLOC, fd, IRQ_READ, line_interrupt, 0, - driver->read_irq_name, data); + driver->read_irq_name, data, simple_timetravel_handler); if (err < 0) return err; @@ -270,9 +270,9 @@ int line_setup_irq(int fd, int input, int output, struct line *line, void *data) } if (output) { - err = um_request_irq(UM_IRQ_ALLOC, fd, IRQ_WRITE, + err = um_request_irq_tt(UM_IRQ_ALLOC, fd, IRQ_WRITE, line_write_interrupt, 0, - driver->write_irq_name, data); + driver->write_irq_name, data, simple_timetravel_handler); if (err < 0) return err;