Message ID | 20210625103810.fe877ae0aef4.If240438e3f50ae226f3f755fc46ea498c6858393@changeid |
---|---|
State | Not Applicable |
Headers | show |
Series | dmaengine: idxd: depends on !UML | expand |
On 25/06/2021 09:38, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@intel.com> > > Now that UML has PCI support, this driver must depend also on > !UML since it pokes at X86_64 architecture internals that don't > exist on ARCH=um. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Johannes Berg <johannes.berg@intel.com> > --- > drivers/dma/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index 6ab9d9a488a6..1f3c0e2ea4d9 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -278,7 +278,7 @@ config INTEL_IDMA64 > > config INTEL_IDXD > tristate "Intel Data Accelerators support" > - depends on PCI && X86_64 > + depends on PCI && X86_64 && !UML > depends on PCI_MSI > depends on SBITMAP > select DMA_ENGINE > Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
On 6/25/2021 1:38 AM, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@intel.com> > > Now that UML has PCI support, this driver must depend also on > !UML since it pokes at X86_64 architecture internals that don't > exist on ARCH=um. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Johannes Berg <johannes.berg@intel.com> Acked-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/dma/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index 6ab9d9a488a6..1f3c0e2ea4d9 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -278,7 +278,7 @@ config INTEL_IDMA64 > > config INTEL_IDXD > tristate "Intel Data Accelerators support" > - depends on PCI && X86_64 > + depends on PCI && X86_64 && !UML > depends on PCI_MSI > depends on SBITMAP > select DMA_ENGINE
On 25-06-21, 10:38, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@intel.com> > > Now that UML has PCI support, this driver must depend also on > !UML since it pokes at X86_64 architecture internals that don't > exist on ARCH=um. Applied, thanks
On Wed, 2021-07-14 at 12:30 +0530, Vinod Koul wrote: > On 25-06-21, 10:38, Johannes Berg wrote: > > From: Johannes Berg <johannes.berg@intel.com> > > > > Now that UML has PCI support, this driver must depend also on > > !UML since it pokes at X86_64 architecture internals that don't > > exist on ARCH=um. > > Applied, thanks Thanks. Any reason this hasn't landed in Linus's tree yet? I keep getting build failure reports from there. johannes
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 6ab9d9a488a6..1f3c0e2ea4d9 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -278,7 +278,7 @@ config INTEL_IDMA64 config INTEL_IDXD tristate "Intel Data Accelerators support" - depends on PCI && X86_64 + depends on PCI && X86_64 && !UML depends on PCI_MSI depends on SBITMAP select DMA_ENGINE