| Message ID | 20190709063023.251446-9-brendanhiggins@google.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | kunit: introduce KUnit, the Linux kernel unit testing framework | expand |
On Mon, Jul 08, 2019 at 11:30:13PM -0700, Brendan Higgins wrote: > Fix the following warning seen on GCC 7.3: > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() > > kunit_try_catch_throw is a function added in the following patch in this > series; it allows KUnit, a unit testing framework for the kernel, to > bail out of a broken test. As a consequence, it is a new __noreturn > function that objtool thinks is broken (as seen above). So fix this > warning by adding kunit_try_catch_throw to objtool's noreturn list. > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > Link: https://www.spinics.net/lists/linux-kbuild/msg21708.html > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > --- > tools/objtool/check.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > index 172f991957269..98db5fe85c797 100644 > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -134,6 +134,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func, > "usercopy_abort", > "machine_real_restart", > "rewind_stack_do_exit", > + "kunit_try_catch_throw", > }; > > if (func->bind == STB_WEAK) > -- > 2.22.0.410.gd8fdbe21b5-goog > Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 172f991957269..98db5fe85c797 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -134,6 +134,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func, "usercopy_abort", "machine_real_restart", "rewind_stack_do_exit", + "kunit_try_catch_throw", }; if (func->bind == STB_WEAK)
Fix the following warning seen on GCC 7.3: kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch() kunit_try_catch_throw is a function added in the following patch in this series; it allows KUnit, a unit testing framework for the kernel, to bail out of a broken test. As a consequence, it is a new __noreturn function that objtool thinks is broken (as seen above). So fix this warning by adding kunit_try_catch_throw to objtool's noreturn list. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> Link: https://www.spinics.net/lists/linux-kbuild/msg21708.html Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> --- tools/objtool/check.c | 1 + 1 file changed, 1 insertion(+)