| Message ID | 90ee88bcde84141e0280ffa4ccbd288462489eba.1319313020.git.marvin24@gmx.de |
|---|---|
| State | Superseded, archived |
| Headers | show |
Marc Dietrich wrote at Saturday, October 22, 2011 2:17 PM: > * NOT FOR COMMIT * > > This just adds the dts for paz00. I like to add it to board-dt as > well as soon as I find out which tree to base it on. ... > +++ b/arch/arm/boot/dts/tegra-paz00.dts One thing that cross my mind when writing the TrimSlice support and I forgot to mention: Should these files be named ${soc}-${board}.dts or ${vendor}-${board}.dts (tegra-paz00.dts or toshiba-paz00.dts or compal-paz00.dts). I'm OK either way; just want to follow any outside expectations. > @@ -0,0 +1,51 @@ > +/dts-v1/; > + > +/memreserve/ 0x1c000000 0x04000000; > +/include/ "tegra20.dtsi" > + > +/ { > + model = "Toshiba AC100 / Dynabook AZ"; > + compatible = "compal,paz00", "nvidia,tegra20"; > + > + chosen { > + bootargs = "console=ttyS0,115200n8 root=/dev/mmcblk1p1"; > + }; > + > + memory@0 { The other boards just have "memory" here; which is wrong? ... > + i2c@7000c500 { > + clock-frequency = <80000>; That's a pretty odd I2C frequency...
On Monday 24 October 2011 22:16:15 Stephen Warren wrote: > Marc Dietrich wrote at Saturday, October 22, 2011 2:17 PM: > > * NOT FOR COMMIT * > > > > This just adds the dts for paz00. I like to add it to board-dt as > > well as soon as I find out which tree to base it on. > > ... > > > +++ b/arch/arm/boot/dts/tegra-paz00.dts > > One thing that cross my mind when writing the TrimSlice support and I > forgot to mention: Should these files be named ${soc}-${board}.dts or > ${vendor}-${board}.dts (tegra-paz00.dts or toshiba-paz00.dts or > compal-paz00.dts). I'm OK either way; just want to follow any outside > expectations. I also don't know. I prefer compal for paz00 because Toshiba's code name was procyon (I think) and I don't want to change all the naming. Also Toshiba showed no interest in helping us, so I don't see why they should get the fame. > > @@ -0,0 +1,51 @@ > > +/dts-v1/; > > + > > +/memreserve/ 0x1c000000 0x04000000; > > +/include/ "tegra20.dtsi" > > + > > +/ { > > + model = "Toshiba AC100 / Dynabook AZ"; > > + compatible = "compal,paz00", "nvidia,tegra20"; > > + > > + chosen { > > + bootargs = "console=ttyS0,115200n8 root=/dev/mmcblk1p1"; > > + }; > > + > > + memory@0 { > > The other boards just have "memory" here; which is wrong? I just copy-pasted from harmony, I guess it doesn't matter. > > ... > > > + i2c@7000c500 { > > + clock-frequency = <80000>; > > That's a pretty odd I2C frequency... no, 80000 is even ;-) Seriously, it just reflects the fact that the embedded controller bus runs at 80kHz. Even more seriously, reading "booting-without- of.txt" in the Documentation/devicetree dir, | o PowerPC,970@0 | |- name = "PowerPC,970" | |- device_type = "cpu" | |- reg = <0> | |- clock-frequency = <5f5e1000> | |- 64-bit | |- linux,phandle = <2> it looks like all clock-frequency values are hexadecimal. In this case even <400000> would be wrong (or the docu is --- ok, the docu is wrong). Marc -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/25/2011 12:16 AM, Stephen Warren wrote: > Marc Dietrich wrote at Saturday, October 22, 2011 2:17 PM: >> * NOT FOR COMMIT * >> >> This just adds the dts for paz00. I like to add it to board-dt as >> well as soon as I find out which tree to base it on. > ... >> +++ b/arch/arm/boot/dts/tegra-paz00.dts > > One thing that cross my mind when writing the TrimSlice support and I > forgot to mention: Should these files be named ${soc}-${board}.dts or > ${vendor}-${board}.dts (tegra-paz00.dts or toshiba-paz00.dts or > compal-paz00.dts). I'm OK either way; just want to follow any outside > expectations. > >> @@ -0,0 +1,51 @@ >> +/dts-v1/; >> + >> +/memreserve/ 0x1c000000 0x04000000; >> +/include/ "tegra20.dtsi" >> + >> +/ { >> + model = "Toshiba AC100 / Dynabook AZ"; >> + compatible = "compal,paz00", "nvidia,tegra20"; >> + >> + chosen { >> + bootargs = "console=ttyS0,115200n8 root=/dev/mmcblk1p1"; >> + }; >> + >> + memory@0 { > > The other boards just have "memory" here; which is wrong? > Both... I believe it should be "memory@<base address>". Rob -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Rob Herring wrote at Tuesday, October 25, 2011 1:52 PM: > On 10/25/2011 12:16 AM, Stephen Warren wrote: > > Marc Dietrich wrote at Saturday, October 22, 2011 2:17 PM: > >> * NOT FOR COMMIT * > >> > >> This just adds the dts for paz00. I like to add it to board-dt as > >> well as soon as I find out which tree to base it on. > > ... > >> +++ b/arch/arm/boot/dts/tegra-paz00.dts > > > > One thing that cross my mind when writing the TrimSlice support and I > > forgot to mention: Should these files be named ${soc}-${board}.dts or > > ${vendor}-${board}.dts (tegra-paz00.dts or toshiba-paz00.dts or > > compal-paz00.dts). I'm OK either way; just want to follow any outside > > expectations. > > > >> @@ -0,0 +1,51 @@ > >> +/dts-v1/; > >> + > >> +/memreserve/ 0x1c000000 0x04000000; > >> +/include/ "tegra20.dtsi" > >> + > >> +/ { > >> + model = "Toshiba AC100 / Dynabook AZ"; > >> + compatible = "compal,paz00", "nvidia,tegra20"; > >> + > >> + chosen { > >> + bootargs = "console=ttyS0,115200n8 root=/dev/mmcblk1p1"; > >> + }; > >> + > >> + memory@0 { > > > > The other boards just have "memory" here; which is wrong? > > Both... I believe it should be "memory@<base address>". Tegra20's memory base address is 0, so I assume the quoted example above is correct then.
Marc Dietrich wrote at Tuesday, October 25, 2011 1:05 PM: > On Monday 24 October 2011 22:16:15 Stephen Warren wrote: > > Marc Dietrich wrote at Saturday, October 22, 2011 2:17 PM: > > > * NOT FOR COMMIT * > > > > > > This just adds the dts for paz00. I like to add it to board-dt as > > > well as soon as I find out which tree to base it on. > > > > ... > > > > > +++ b/arch/arm/boot/dts/tegra-paz00.dts > > > > One thing that cross my mind when writing the TrimSlice support and I > > forgot to mention: Should these files be named ${soc}-${board}.dts or > > ${vendor}-${board}.dts (tegra-paz00.dts or toshiba-paz00.dts or > > compal-paz00.dts). I'm OK either way; just want to follow any outside > > expectations. > > I also don't know. I prefer compal for paz00 because Toshiba's code name was > procyon (I think) and I don't want to change all the naming. Also Toshiba > showed no interest in helping us, so I don't see why they should get the fame. Well, it's more about correctly defining what the HW is than advertising, fame, or support!
On Tuesday 25 October 2011 23:43:06 Stephen Warren wrote: > Marc Dietrich wrote at Tuesday, October 25, 2011 1:05 PM: > > On Monday 24 October 2011 22:16:15 Stephen Warren wrote: > > > Marc Dietrich wrote at Saturday, October 22, 2011 2:17 PM: > > > > * NOT FOR COMMIT * > > > > > > > > This just adds the dts for paz00. I like to add it to board-dt > > > > as > > > > well as soon as I find out which tree to base it on. > > > > > > ... > > > > > > > +++ b/arch/arm/boot/dts/tegra-paz00.dts > > > > > > One thing that cross my mind when writing the TrimSlice support and > > > I > > > forgot to mention: Should these files be named ${soc}-${board}.dts > > > or > > > ${vendor}-${board}.dts (tegra-paz00.dts or toshiba-paz00.dts or > > > compal-paz00.dts). I'm OK either way; just want to follow any > > > outside > > > expectations. > > > > I also don't know. I prefer compal for paz00 because Toshiba's code name > > was procyon (I think) and I don't want to change all the naming. Also > > Toshiba showed no interest in helping us, so I don't see why they > > should get the fame. > Well, it's more about correctly defining what the HW is than advertising, > fame, or support! define "what the HW is". Warning: the following list is purely fictitious. Any similarities between the companies or products mentiond, real or imaginary, are coincidental. - company A creates a cpu (only the IP) and license it to company N. - company N adds some more stuff around it (interfaces, gpu, ...) and creates real cpu hw. - company T likes the cpu and asks company C to build a computer around it - company C takes the evaluation board from company N, modifies it a bit, and builds a whole netbook around it - company T gets the netbook from company C and adds a operating system which will displeased their customers So how would you define that hw? Or the real question, who made it? And please don't take my second argument too serious. I just expressed my anger in an improper way at an improper place. Sorry for that. Marc -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-paz00.dts new file mode 100644 index 0000000..2114026 --- /dev/null +++ b/arch/arm/boot/dts/tegra-paz00.dts @@ -0,0 +1,51 @@ +/dts-v1/; + +/memreserve/ 0x1c000000 0x04000000; +/include/ "tegra20.dtsi" + +/ { + model = "Toshiba AC100 / Dynabook AZ"; + compatible = "compal,paz00", "nvidia,tegra20"; + + chosen { + bootargs = "console=ttyS0,115200n8 root=/dev/mmcblk1p1"; + }; + + memory@0 { + reg = < 0x00000000 0x20000000 >; + }; + + i2c@7000c000 { + clock-frequency = <400000>; + }; + + i2c@7000c400 { + clock-frequency = <400000>; + }; + + i2c@7000c500 { + clock-frequency = <80000>; + }; + + i2c@7000d000 { + clock-frequency = <400000>; + }; + + serial@70006000 { + clock-frequency = < 216000000 >; + }; + + serial@70006300 { + clock-frequency = < 216000000 >; + }; + + sdhci@c8000000 { + cd-gpios = <&gpio 173 0>; /* gpio PV5 */ + wp-gpios = <&gpio 57 0>; /* gpio PH1 */ + power-gpios = <&gpio 155 0>; /* gpio PT3 */ + }; + + sdhci@c8000600 { + support-8bit; + }; +};
* NOT FOR COMMIT * This just adds the dts for paz00. I like to add it to board-dt as well as soon as I find out which tree to base it on. Signed-off-by: Marc Dietrich <marvin24@gmx.de> --- arch/arm/boot/dts/tegra-paz00.dts | 51 +++++++++++++++++++++++++++++++++++++ 1 files changed, 51 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tegra-paz00.dts