| Message ID | 54D3A1A9.9040709@users.sourceforge.net |
|---|---|
| State | Deferred |
| Headers | show |
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Thu, 5 Feb 2015 17:54:16 +0100 > > The vfree() function performs also input parameter validation. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/iommu/tegra-gart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c > index f722a0c..07a795a 100644 > --- a/drivers/iommu/tegra-gart.c > +++ b/drivers/iommu/tegra-gart.c > @@ -404,8 +404,7 @@ static int tegra_gart_remove(struct platform_device *pdev) > struct gart_device *gart = platform_get_drvdata(pdev); > > writel(0, gart->regs + GART_CONFIG); > - if (gart->savedata) > - vfree(gart->savedata); > + vfree(gart->savedata); > gart_handle = NULL; > return 0; > } > Would you like to integrate this update suggestion into another source code repository? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c index f722a0c..07a795a 100644 --- a/drivers/iommu/tegra-gart.c +++ b/drivers/iommu/tegra-gart.c @@ -404,8 +404,7 @@ static int tegra_gart_remove(struct platform_device *pdev) struct gart_device *gart = platform_get_drvdata(pdev); writel(0, gart->regs + GART_CONFIG); - if (gart->savedata) - vfree(gart->savedata); + vfree(gart->savedata); gart_handle = NULL; return 0; }