diff mbox series

[v2] ARM: tegra: wire up two front panel LEDs on TrimSlice

Message ID 20240822184555.20353-1-tmn505@terefe.re
State Accepted
Headers show
Series [v2] ARM: tegra: wire up two front panel LEDs on TrimSlice | expand

Commit Message

Tomasz Maciej Nowak Aug. 22, 2024, 6:41 p.m. UTC 
From: Tomasz Maciej Nowak <tmn505@gmail.com>

Pins responsible for controlling these LEDs need to have tristate
control removed if we want them as GPIOs. This change alings with pinmux
configuration of "dte" pin group in downstream kernel[1].
These LEDs had no function assigned on vendor kernel and there is no
label on the case, the only markings are on PCB which are part of node
names (ds1 marking is on power LED controlled by PMIC), so generic term
is assigned as the function.

1. https://github.com/compulab/trimslice-android-kernel/blob/upstream/arch/arm/mach-tegra/board-trimslice-pinmux.c#L45

Signed-off-by: Tomasz Maciej Nowak <tmn505@gmail.com>
---
Previous version: https://lore.kernel.org/linux-tegra/20180219201623.6987-1-tmn505@gmail.com
Changes in v2:
- rebase
- reword commit title and message
- align to changes in leds subsystem
- align to dtschema recomendations

 .../arm/boot/dts/nvidia/tegra20-trimslice.dts | 30 +++++++++++++++----
 1 file changed, 25 insertions(+), 5 deletions(-)

Comments

Thierry Reding Aug. 29, 2024, 3:38 p.m. UTC | #1 
From: Thierry Reding <treding@nvidia.com>


On Thu, 22 Aug 2024 20:41:02 +0200, Tomasz Maciej Nowak wrote:
> Pins responsible for controlling these LEDs need to have tristate
> control removed if we want them as GPIOs. This change alings with pinmux
> configuration of "dte" pin group in downstream kernel[1].
> These LEDs had no function assigned on vendor kernel and there is no
> label on the case, the only markings are on PCB which are part of node
> names (ds1 marking is on power LED controlled by PMIC), so generic term
> is assigned as the function.
> 
> [...]

Applied, thanks!

[1/1] ARM: tegra: wire up two front panel LEDs on TrimSlice
      (no commit info)

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nvidia/tegra20-trimslice.dts b/arch/arm/boot/dts/nvidia/tegra20-trimslice.dts
index 7cae6ad57544..4caeeb9f1e1d 100644
--- a/arch/arm/boot/dts/nvidia/tegra20-trimslice.dts
+++ b/arch/arm/boot/dts/nvidia/tegra20-trimslice.dts
@@ -2,6 +2,7 @@ 
 /dts-v1/;
 
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
 #include "tegra20.dtsi"
 #include "tegra20-cpu-opp.dtsi"
 
@@ -201,16 +202,17 @@  uca {
 			conf_ata {
 				nvidia,pins = "ata", "atc", "atd", "ate",
 					"crtp", "dap2", "dap3", "dap4", "dta",
-					"dtb", "dtc", "dtd", "dte", "gmb",
-					"gme", "i2cp", "pta", "slxc", "slxd",
-					"spdi", "spdo", "uda";
+					"dtb", "dtc", "dtd", "gmb", "gme",
+					"i2cp", "pta", "slxc", "slxd", "spdi",
+					"spdo", "uda";
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_ENABLE>;
 			};
 			conf_atb {
 				nvidia,pins = "atb", "cdev1", "cdev2", "dap1",
-					"gma", "gmc", "gmd", "gpu", "gpu7",
-					"gpv", "sdio1", "slxa", "slxk", "uac";
+					"dte", "gma", "gmc", "gmd", "gpu",
+					"gpu7", "gpv", "sdio1", "slxa", "slxk",
+					"uac";
 				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
 				nvidia,tristate = <TEGRA_PIN_DISABLE>;
 			};
@@ -408,6 +410,24 @@  key-power {
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led-ds2 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <2>;
+			gpios = <&gpio TEGRA_GPIO(D, 2) GPIO_ACTIVE_LOW>;
+		};
+
+		led-ds3 {
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_INDICATOR;
+			function-enumerator = <3>;
+			gpios = <&gpio TEGRA_GPIO(BB, 5) GPIO_ACTIVE_LOW>;
+		};
+	};
+
 	poweroff {
 		compatible = "gpio-poweroff";
 		gpios = <&gpio TEGRA_GPIO(X, 7) GPIO_ACTIVE_LOW>;