| Message ID | 20240806123906.161218-6-clamor95@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Tegra114: complete TF701T device tree | expand |
On 06/08/2024 14:39, Svyatoslav Ryhel wrote: > Add serial node along with bluetooth node to ASUS TF701T device-tree. > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > --- > .../boot/dts/nvidia/tegra114-asus-tf701t.dts | 28 ++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts > index fe1772250a85..00c3325878b9 100644 > --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts > +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts > @@ -1111,7 +1111,33 @@ serial@70006040 { > }; > > serial@70006200 { > - /* Bluetooth */ > + compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart"; Why do you override compatible? Boards do not come with different SoCs, do they? Best regards, Krzysztof
On Tue, Aug 06, 2024 at 03:33:58PM GMT, Krzysztof Kozlowski wrote: > On 06/08/2024 14:39, Svyatoslav Ryhel wrote: > > Add serial node along with bluetooth node to ASUS TF701T device-tree. > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > > --- > > .../boot/dts/nvidia/tegra114-asus-tf701t.dts | 28 ++++++++++++++++++- > > 1 file changed, 27 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts > > index fe1772250a85..00c3325878b9 100644 > > --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts > > +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts > > @@ -1111,7 +1111,33 @@ serial@70006040 { > > }; > > > > serial@70006200 { > > - /* Bluetooth */ > > + compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart"; > > Why do you override compatible? Boards do not come with different SoCs, > do they? Just to clarify this: it's not being overridden because the SoC is different but because for Bluetooth we need to enable the high-speed UART mode of these devices, as opposed to the standard UART mode used for regular serial ports. Thierry
diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts index fe1772250a85..00c3325878b9 100644 --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts @@ -1111,7 +1111,33 @@ serial@70006040 { }; serial@70006200 { - /* Bluetooth */ + compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart"; + reset-names = "serial"; + /delete-property/ reg-shift; + status = "okay"; + + nvidia,adjust-baud-rates = <0 9600 100>, + <9600 115200 200>, + <1000000 4000000 136>; + + bluetooth { + compatible = "brcm,bcm4334-bt"; + max-speed = <4000000>; + + clocks = <&tegra_pmc TEGRA_PMC_CLK_BLINK>; + clock-names = "txco"; + + interrupt-parent = <&gpio>; + interrupts = <TEGRA_GPIO(U, 6) IRQ_TYPE_EDGE_RISING>; + interrupt-names = "host-wakeup"; + + device-wakeup-gpios = <&gpio TEGRA_GPIO(EE, 1) GPIO_ACTIVE_HIGH>; + shutdown-gpios = <&gpio TEGRA_GPIO(Q, 7) GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio TEGRA_GPIO(Q, 6) GPIO_ACTIVE_LOW>; + + vbat-supply = <&vdd_3v3_com>; + vddio-supply = <&vdd_1v8_vio>; + }; }; serial@70006300 {
Add serial node along with bluetooth node to ASUS TF701T device-tree. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> --- .../boot/dts/nvidia/tegra114-asus-tf701t.dts | 28 ++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)