| Message ID | 20240709214609.2472562-1-vedantd@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: tegra: enable same UARTs for Orin NX/Nano | expand |
On 09/07/2024 22:46, Vedant Deshpande wrote: > This patch ensures that Orin NX and Orin Nano enable an identical > set of serial ports. UARTA/UARTE will be enabled by adding > respective nodes to the board dtsi file. > > Signed-off-by: Vedant Deshpande <vedantd@nvidia.com> > --- > .../nvidia/tegra234-p3768-0000+p3767-0000.dts | 17 ----------------- > .../dts/nvidia/tegra234-p3768-0000+p3767.dtsi | 14 ++++++++++++++ > 2 files changed, 14 insertions(+), 17 deletions(-) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts > index 82a59e33c46c..5dc974bb360c 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts > @@ -7,24 +7,7 @@ / { > compatible = "nvidia,p3768-0000+p3767-0000", "nvidia,p3767-0000", "nvidia,tegra234"; > model = "NVIDIA Jetson Orin NX Engineering Reference Developer Kit"; > > - aliases { > - serial1 = &uarta; > - serial2 = &uarte; > - }; > - > bus@0 { > - serial@3100000 { > - compatible = "nvidia,tegra194-hsuart"; > - reset-names = "serial"; > - status = "okay"; > - }; > - > - serial@3140000 { > - compatible = "nvidia,tegra194-hsuart"; > - reset-names = "serial"; > - status = "okay"; > - }; > - > hda@3510000 { > nvidia,model = "NVIDIA Jetson Orin NX HDA"; > }; > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi > index 6d64a24fa251..81d4f4f12ab1 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi > @@ -9,6 +9,8 @@ / { > > aliases { > serial0 = &tcu; > + serial1 = &uarta; > + serial2 = &uarte; > }; > > chosen { > @@ -16,6 +18,18 @@ chosen { > }; > > bus@0 { > + serial@3100000 { > + compatible = "nvidia,tegra194-hsuart"; > + reset-names = "serial"; > + status = "okay"; > + }; > + > + serial@3140000 { > + compatible = "nvidia,tegra194-hsuart"; > + reset-names = "serial"; > + status = "okay"; > + }; > + > i2c@3160000 { > status = "okay"; > When running ... $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.yaml I see ... arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: serial@3100000: 'dmas' is a required property from schema $id: http://devicetree.org/schemas/serial/nvidia,tegra20-hsuart.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dtb: serial@3100000: 'dma-names' is a required property from schema $id: http://devicetree.org/schemas/serial/nvidia,tegra20-hsuart.yaml# DTC_CHK arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: serial@3100000: 'dmas' is a required property from schema $id: http://devicetree.org/schemas/serial/nvidia,tegra20-hsuart.yaml# arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0005.dtb: serial@3100000: 'dma-names' is a required property from schema $id: http://devicetree.org/schemas/serial/nvidia,tegra20-hsuart.yaml# Although this was already an issue for tegra234-p3768-0000+p3767-0000.dtb it is now an issue for both boards. Could we add a patch to fix this? Thanks Jon
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts index 82a59e33c46c..5dc974bb360c 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767-0000.dts @@ -7,24 +7,7 @@ / { compatible = "nvidia,p3768-0000+p3767-0000", "nvidia,p3767-0000", "nvidia,tegra234"; model = "NVIDIA Jetson Orin NX Engineering Reference Developer Kit"; - aliases { - serial1 = &uarta; - serial2 = &uarte; - }; - bus@0 { - serial@3100000 { - compatible = "nvidia,tegra194-hsuart"; - reset-names = "serial"; - status = "okay"; - }; - - serial@3140000 { - compatible = "nvidia,tegra194-hsuart"; - reset-names = "serial"; - status = "okay"; - }; - hda@3510000 { nvidia,model = "NVIDIA Jetson Orin NX HDA"; }; diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi index 6d64a24fa251..81d4f4f12ab1 100644 --- a/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3768-0000+p3767.dtsi @@ -9,6 +9,8 @@ / { aliases { serial0 = &tcu; + serial1 = &uarta; + serial2 = &uarte; }; chosen { @@ -16,6 +18,18 @@ chosen { }; bus@0 { + serial@3100000 { + compatible = "nvidia,tegra194-hsuart"; + reset-names = "serial"; + status = "okay"; + }; + + serial@3140000 { + compatible = "nvidia,tegra194-hsuart"; + reset-names = "serial"; + status = "okay"; + }; + i2c@3160000 { status = "okay";
This patch ensures that Orin NX and Orin Nano enable an identical set of serial ports. UARTA/UARTE will be enabled by adding respective nodes to the board dtsi file. Signed-off-by: Vedant Deshpande <vedantd@nvidia.com> --- .../nvidia/tegra234-p3768-0000+p3767-0000.dts | 17 ----------------- .../dts/nvidia/tegra234-p3768-0000+p3767.dtsi | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 17 deletions(-)