diff mbox series

clk: tegra: fix error return case for recalc_rate

Message ID 20230912112951.2330497-1-cyndis@kapsi.fi
State Handled Elsewhere
Headers show
Series clk: tegra: fix error return case for recalc_rate | expand

Commit Message

Mikko Perttunen Sept. 12, 2023, 11:29 a.m. UTC 
From: Timo Alho <talho@nvidia.com>

tegra-bpmp clocks driver makes implicit conversion of signed error
code to unsigned value in recalc_rate operation. The behavior for
recalc_rate, according to it's specification, should be that "If the
driver cannot figure out a rate for this clock, it must return 0."

Fixes: ca6f2796eef7 ("clk: tegra: Add BPMP clock driver")
Signed-off-by: Timo Alho <talho@nvidia.com>
Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
---
 drivers/clk/tegra/clk-bpmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd Sept. 12, 2023, 5:58 p.m. UTC | #1 
Quoting Mikko Perttunen (2023-09-12 04:29:50)
> From: Timo Alho <talho@nvidia.com>
> 
> tegra-bpmp clocks driver makes implicit conversion of signed error
> code to unsigned value in recalc_rate operation. The behavior for
> recalc_rate, according to it's specification, should be that "If the
> driver cannot figure out a rate for this clock, it must return 0."
> 
> Fixes: ca6f2796eef7 ("clk: tegra: Add BPMP clock driver")
> Signed-off-by: Timo Alho <talho@nvidia.com>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---

Applied to clk-fixes
diff mbox series

Patch

diff --git a/drivers/clk/tegra/clk-bpmp.c b/drivers/clk/tegra/clk-bpmp.c
index a9f3fb448de6..7bfba0afd778 100644
--- a/drivers/clk/tegra/clk-bpmp.c
+++ b/drivers/clk/tegra/clk-bpmp.c
@@ -159,7 +159,7 @@  static unsigned long tegra_bpmp_clk_recalc_rate(struct clk_hw *hw,
 
 	err = tegra_bpmp_clk_transfer(clk->bpmp, &msg);
 	if (err < 0)
-		return err;
+		return 0;
 
 	return response.rate;
 }