| Message ID | 20230125204211.63680-2-jonathanh@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add device-tree support for Cypress CYPD4226 | expand |
On 25/01/2023 21:42, Jon Hunter wrote: > From: Wayne Chang <waynec@nvidia.com> > > Add the device-tree binding documentation for Cypress cypd4226 dual > Type-C controller. > > Signed-off-by: Wayne Chang <waynec@nvidia.com> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > + > + firmware-name: > + enum: > + - nvidia,gpu > + - nvidia,jetson-agx-xavier > + description: | > + The name of the CCGx firmware built for product series. > + should be set one of following: > + - "nvidia,gpu" for the NVIDIA RTX product series > + - "nvidia,jetson-agx-xavier" for the NVIDIA Jetson product series > + > +patternProperties: > + '^connector@[0-1]+$': > + $ref: /schemas/connector/usb-connector.yaml# No improvements here This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > + properties: > + reg: > + maxItems: 1 > + > +unevaluatedProperties: false This goes after required: block > + > +required: > + - compatible > + - reg > + - interrupts > + Best regards, Krzysztof
On 26/01/2023 11:36, Krzysztof Kozlowski wrote: > On 25/01/2023 21:42, Jon Hunter wrote: >> From: Wayne Chang <waynec@nvidia.com> >> >> Add the device-tree binding documentation for Cypress cypd4226 dual >> Type-C controller. >> >> Signed-off-by: Wayne Chang <waynec@nvidia.com> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > >> + >> + firmware-name: >> + enum: >> + - nvidia,gpu >> + - nvidia,jetson-agx-xavier >> + description: | >> + The name of the CCGx firmware built for product series. >> + should be set one of following: >> + - "nvidia,gpu" for the NVIDIA RTX product series >> + - "nvidia,jetson-agx-xavier" for the NVIDIA Jetson product series >> + >> +patternProperties: >> + '^connector@[0-1]+$': >> + $ref: /schemas/connector/usb-connector.yaml# > > No improvements here > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. Hmmm ... I think I misinterpreted what you were asking/suggesting. OK, let me fix this up. Jon
On 26/01/2023 15:05, Jon Hunter wrote: > > On 26/01/2023 11:36, Krzysztof Kozlowski wrote: >> On 25/01/2023 21:42, Jon Hunter wrote: >>> From: Wayne Chang <waynec@nvidia.com> >>> >>> Add the device-tree binding documentation for Cypress cypd4226 dual >>> Type-C controller. >>> >>> Signed-off-by: Wayne Chang <waynec@nvidia.com> >>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> >> >>> + >>> + firmware-name: >>> + enum: >>> + - nvidia,gpu >>> + - nvidia,jetson-agx-xavier >>> + description: | >>> + The name of the CCGx firmware built for product series. >>> + should be set one of following: >>> + - "nvidia,gpu" for the NVIDIA RTX product series >>> + - "nvidia,jetson-agx-xavier" for the NVIDIA Jetson product series >>> + >>> +patternProperties: >>> + '^connector@[0-1]+$': >>> + $ref: /schemas/connector/usb-connector.yaml# >> >> No improvements here >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. >> >> Thank you. > > > Hmmm ... I think I misinterpreted what you were asking/suggesting. OK, > let me fix this up. Apologies for royally messing this up. What makes it worse is that this should have been fixed after V1 [0]. I have re-spun and will send out again shortly. Jon [0] https://lore.kernel.org/linux-tegra/f491fde0-5448-ddf2-d227-c42e30fd37d8@nvidia.com/
diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml new file mode 100644 index 000000000000..7ab23d8fdb20 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml @@ -0,0 +1,86 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/cypress,cypd4226.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cypress cypd4226 Type-C Controller + +maintainers: + - Wayne Chang <waynec@nvidia.com> + +description: + The Cypress cypd4226 is a dual Type-C controller that is controlled + via an I2C interface. + +properties: + compatible: + const: cypress,cypd4226 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + reg: + const: 0x08 + + interrupts: + items: + - description: cypd4226 host interrupt + + firmware-name: + enum: + - nvidia,gpu + - nvidia,jetson-agx-xavier + description: | + The name of the CCGx firmware built for product series. + should be set one of following: + - "nvidia,gpu" for the NVIDIA RTX product series + - "nvidia,jetson-agx-xavier" for the NVIDIA Jetson product series + +patternProperties: + '^connector@[0-1]+$': + $ref: /schemas/connector/usb-connector.yaml# + properties: + reg: + maxItems: 1 + +unevaluatedProperties: false + +required: + - compatible + - reg + - interrupts + +examples: + - | + #include <dt-bindings/gpio/tegra194-gpio.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + #interrupt-cells = <2>; + + typec@8 { + compatible = "cypress,cypd4226"; + reg = <0x08>; + interrupt-parent = <&gpio_aon>; + interrupts = <TEGRA194_AON_GPIO(BB, 2) IRQ_TYPE_LEVEL_LOW>; + firmware-name = "nvidia,jetson-agx-xavier"; + #address-cells = <1>; + #size-cells = <0>; + connector@0 { + compatible = "usb-c-connector"; + reg = <0>; + label = "USB-C"; + data-role = "dual"; + port { + endpoint { + remote-endpoint = <&usb_role_switch0>; + }; + }; + }; + }; + };