| Message ID | 20230124115119.21451-1-jonathanh@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] dt-bindings: thermal: Add Tegra234 BPMP thermal zones | expand |
On Tue, Jan 24, 2023 at 11:51:18AM +0000, Jon Hunter wrote: > From: Yi-Wei Wang <yiweiw@nvidia.com> > > Add BPMP thermal zone definitions for Tegra234. > > Signed-off-by: Yi-Wei Wang <yiweiw@nvidia.com> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > .../thermal/tegra234-bpmp-thermal.h | 19 +++++++++++++++++++ Match the compatible name please. > 1 file changed, 19 insertions(+) > create mode 100644 include/dt-bindings/thermal/tegra234-bpmp-thermal.h > > diff --git a/include/dt-bindings/thermal/tegra234-bpmp-thermal.h b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h > new file mode 100644 > index 000000000000..41a5efebcc7a > --- /dev/null > +++ b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h > @@ -0,0 +1,19 @@ License? Dual please. > +/* > + * This header provides constants for binding nvidia,tegra234-bpmp-thermal. > + */ > + > +#ifndef _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H > +#define _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H > + > +#define TEGRA234_THERMAL_ZONE_CPU 0 > +#define TEGRA234_THERMAL_ZONE_GPU 1 > +#define TEGRA234_THERMAL_ZONE_CV0 2 > +#define TEGRA234_THERMAL_ZONE_CV1 3 > +#define TEGRA234_THERMAL_ZONE_CV2 4 > +#define TEGRA234_THERMAL_ZONE_SOC0 5 > +#define TEGRA234_THERMAL_ZONE_SOC1 6 > +#define TEGRA234_THERMAL_ZONE_SOC2 7 > +#define TEGRA234_THERMAL_ZONE_TJ_MAX 8 > +#define TEGRA234_THERMAL_ZONE_COUNT 9 > + > +#endif > -- > 2.25.1 >
On 25/01/2023 20:26, Rob Herring wrote: > On Tue, Jan 24, 2023 at 11:51:18AM +0000, Jon Hunter wrote: >> From: Yi-Wei Wang <yiweiw@nvidia.com> >> >> Add BPMP thermal zone definitions for Tegra234. >> >> Signed-off-by: Yi-Wei Wang <yiweiw@nvidia.com> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> >> --- >> .../thermal/tegra234-bpmp-thermal.h | 19 +++++++++++++++++++ > > Match the compatible name please. OK, but to be clear, the compatible string is 'nvidia,tegra186-bpmp-thermal'. So should 'tegra186-bpmp-thermal.h', 'tegra194-bpmp- thermal.h' and this file be combined into a single filed called 'nvidia,tegra186-bpmp-thermal.h'? > >> 1 file changed, 19 insertions(+) >> create mode 100644 include/dt-bindings/thermal/tegra234-bpmp-thermal.h >> >> diff --git a/include/dt-bindings/thermal/tegra234-bpmp-thermal.h b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h >> new file mode 100644 >> index 000000000000..41a5efebcc7a >> --- /dev/null >> +++ b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h >> @@ -0,0 +1,19 @@ > > License? Dual please. Yes will fix this. Thanks Jon
diff --git a/include/dt-bindings/thermal/tegra234-bpmp-thermal.h b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h new file mode 100644 index 000000000000..41a5efebcc7a --- /dev/null +++ b/include/dt-bindings/thermal/tegra234-bpmp-thermal.h @@ -0,0 +1,19 @@ +/* + * This header provides constants for binding nvidia,tegra234-bpmp-thermal. + */ + +#ifndef _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H +#define _DT_BINDINGS_THERMAL_TEGRA234_BPMP_THERMAL_H + +#define TEGRA234_THERMAL_ZONE_CPU 0 +#define TEGRA234_THERMAL_ZONE_GPU 1 +#define TEGRA234_THERMAL_ZONE_CV0 2 +#define TEGRA234_THERMAL_ZONE_CV1 3 +#define TEGRA234_THERMAL_ZONE_CV2 4 +#define TEGRA234_THERMAL_ZONE_SOC0 5 +#define TEGRA234_THERMAL_ZONE_SOC1 6 +#define TEGRA234_THERMAL_ZONE_SOC2 7 +#define TEGRA234_THERMAL_ZONE_TJ_MAX 8 +#define TEGRA234_THERMAL_ZONE_COUNT 9 + +#endif