diff mbox series

ARM64: tegra: Disable the ACONNECT for Jetson TX2

Message ID 20201116162026.5324-1-jonathanh@nvidia.com
State Accepted
Headers show
Series ARM64: tegra: Disable the ACONNECT for Jetson TX2 | expand

Commit Message

Jon Hunter Nov. 16, 2020, 4:20 p.m. UTC
Commit ff4c371d2bc0 ("arm64: defconfig: Build ADMA and ACONNECT driver")
enable the Tegra ADMA and ACONNECT drivers and this is causing resume
from system suspend to fail on Jetson TX2. Resume is failing because the
ACONNECT driver is being resumed before the BPMP driver, and the ACONNECT
driver is attempting to power on a power-domain that is provided by the
BPMP. While a proper fix for the resume sequencing problem is identified,
disable the ACONNECT for Jetson TX2 temporarily to avoid breaking system
suspend.

Please note that ACONNECT driver is used by the Audio Processing Engine
(APE) on Tegra, but because there is no mainline support for APE on
Jetson TX2 currently, disabling the ACONNECT does not disable any useful
feature at the moment.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Thierry Reding Nov. 16, 2020, 4:28 p.m. UTC | #1
On Mon, Nov 16, 2020 at 04:20:26PM +0000, Jon Hunter wrote:
> Commit ff4c371d2bc0 ("arm64: defconfig: Build ADMA and ACONNECT driver")
> enable the Tegra ADMA and ACONNECT drivers and this is causing resume
> from system suspend to fail on Jetson TX2. Resume is failing because the
> ACONNECT driver is being resumed before the BPMP driver, and the ACONNECT
> driver is attempting to power on a power-domain that is provided by the
> BPMP. While a proper fix for the resume sequencing problem is identified,
> disable the ACONNECT for Jetson TX2 temporarily to avoid breaking system
> suspend.
> 
> Please note that ACONNECT driver is used by the Audio Processing Engine
> (APE) on Tegra, but because there is no mainline support for APE on
> Jetson TX2 currently, disabling the ACONNECT does not disable any useful
> feature at the moment.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 12 ------------
>  1 file changed, 12 deletions(-)

Applied, thanks.

Thierry
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts b/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
index 381a84912ba8..c28d51cc5797 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
@@ -10,18 +10,6 @@ 
 	model = "NVIDIA Jetson TX2 Developer Kit";
 	compatible = "nvidia,p2771-0000", "nvidia,tegra186";
 
-	aconnect {
-		status = "okay";
-
-		dma-controller@2930000 {
-			status = "okay";
-		};
-
-		interrupt-controller@2a40000 {
-			status = "okay";
-		};
-	};
-
 	i2c@3160000 {
 		power-monitor@42 {
 			compatible = "ti,ina3221";