From patchwork Fri Nov 6 09:14:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Hunter X-Patchwork-Id: 1395556 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.a=rsa-sha256 header.s=n1 header.b=TjxdrtYp; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CSF8547Mzz9sSs for ; Fri, 6 Nov 2020 20:14:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726503AbgKFJO2 (ORCPT ); Fri, 6 Nov 2020 04:14:28 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:19469 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725868AbgKFJO1 (ORCPT ); Fri, 6 Nov 2020 04:14:27 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 06 Nov 2020 01:14:30 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Nov 2020 09:14:26 +0000 Received: from moonraker.nvidia.com (172.20.13.39) by mail.nvidia.com (172.20.187.13) with Microsoft SMTP Server id 15.0.1473.3 via Frontend Transport; Fri, 6 Nov 2020 09:14:25 +0000 From: Jon Hunter To: Thierry Reding CC: David Airlie , Daniel Vetter , , , , Jon Hunter Subject: [PATCH V3] drm/tegra: sor: Don't warn on probe deferral Date: Fri, 6 Nov 2020 09:14:20 +0000 Message-ID: <20201106091420.773062-1-jonathanh@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-NVConfidentiality: public DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604654070; bh=aKTFlrpqLCkiGuH1D+3SmNI+TCihd2e9AeWXjqSfdIQ=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:MIME-Version: X-NVConfidentiality:Content-Transfer-Encoding:Content-Type; b=TjxdrtYpeRrwSpVHKEE2GTnd4ALHUZOUhGiAaZgWx4a8cutp4FUt09DCSiL2TgwC0 GQKSTwmHh1ObVWNd/XBHOEXSrqkomKWlccX6WcleeXrSLr1lOFDOB1ydvh3/ZBvGVK RJfP7rtgqVMGFc9xQiZD2lG3JU8WAJS/Ma0GE9i0hz3A0xLCRPMsRjWuCR4SZER2VR c0Ufgjdah5Jic/zRzKpBnhfWKqjwKiq9XVKqN+Uo5jQD/5CuVn4kWEZei/TrllCrnQ PxWPXCGOEnm9Utc3I/Cb9jqUdX0daiTVJ1GbZlUj1vJZ5tVXSVQd4jd77AFOdo/y+g hHryeCHzsu5Mw== Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users. Signed-off-by: Jon Hunter --- Changes since V2: - Removed duplicate errno print Changes since V1: - This time, I actually validated it! drivers/gpu/drm/tegra/sor.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index e88a17c2937f..a5b944dacb35 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3764,10 +3764,9 @@ static int tegra_sor_probe(struct platform_device *pdev) return err; err = tegra_output_probe(&sor->output); - if (err < 0) { - dev_err(&pdev->dev, "failed to probe output: %d\n", err); - return err; - } + if (err < 0) + return dev_err_probe(&pdev->dev, err, + "failed to probe output\n"); if (sor->ops && sor->ops->probe) { err = sor->ops->probe(sor);