From patchwork Tue Oct 9 15:25:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 981375 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42V1KV5Tb7z9s8r for ; Wed, 10 Oct 2018 02:26:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbeJIWnL (ORCPT ); Tue, 9 Oct 2018 18:43:11 -0400 Received: from mout.perfora.net ([74.208.4.196]:38311 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbeJIWnK (ORCPT ); Tue, 9 Oct 2018 18:43:10 -0400 Received: from localhost.localdomain.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus003 [74.208.5.2]) with ESMTPA (Nemesis) id 0Lalt0-1fPali2TY8-00kRL9; Tue, 09 Oct 2018 17:25:35 +0200 Received: from localhost.localdomain.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus003 [74.208.5.2]) with ESMTPA (Nemesis) id 0Lalt0-1fPali2TY8-00kRL9; Tue, 09 Oct 2018 17:25:35 +0200 From: Marcel Ziswiler To: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marcel Ziswiler , Thierry Reding , Jonathan Hunter , Rob Herring , Mark Rutland Subject: [PATCH v1 3/8] ARM: tegra: apalis/colibri_t30: fix hdmi regulator Date: Tue, 9 Oct 2018 17:25:18 +0200 Message-Id: <20181009152523.3771-4-marcel@ziswiler.com> X-Mailer: git-send-email 2.14.4 In-Reply-To: <20181009152523.3771-1-marcel@ziswiler.com> References: <20181009152523.3771-1-marcel@ziswiler.com> X-Provags-ID: V03:K1:TxlHnchDp7zNsrdszeUJvfdigjN5JzPkzgZHCOia+qtABLTsRkE qBJO+seO6vWA3AnHZ1ciIJZU5ePXAD4mNGRCP7/m2IOrNOzK/Uef+Sy3lxXQfPexcM4Uu1t ciF8Lat8X8ggjoqytSeTIGItCNK191eC9W4eYqKEICB5E5gGk8eZoMj85pHCxaGOMvvOskp 6+U/8nqzOrnDwUoXCjapQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V01:K0:apWq/wa1Hww=:ybOmJAzmlP98HLLZT5VmYV JEb1gXzx09/eLvDKNV1iJHMiUnRR0X5DylWJ6xg3MPDn+e8uWc5JjibCtxIF4yV4wxfnVElOM shSJTKIiWfFx702LQ0uXPqNXhZk+TAtH9Ip+mPnoYCupmpZNiI8iuuFI7vqbraw2ptquO8D+i z+Ja0hL/i/VvPYVqnpCVi0y5xm50NKwDtfFf62RRb6krVLcWv5vTM/dpeFpU30i95uk5yB+/W 7o+/bnCSSth4B8G91iOJHPX4ov9W8JAcXT8vKYm7wa7Pm73Fm3bqfLmshi5CAKHAVnsZHYFMy 3PelVmiD1ybJ0ESERS5qh6oUUifx802uHJhkilvV0uuVgrSZf6wMuOb/aLioGn0kHDaZSRwvo IdxUrE6QB/iql1Nt13knRkBaj73uQJJRp7iIW7rz3EPhGZnJpBfpLz3Bqo8Rmh04E67gjrkwy icvAxYds/TtY4DQwB61BAb7sph9LgqA3rH04ehzzJdDwpS6vVNiVvabWaXY4Q2fOybc2R2OhB 2+owFvzSKkp9sU8rHFyFrKqC+votv64SqSeNYb16Rm4LsF+0C4RuJCysA32/n5S+At/+MSs9e RL6W4qh5tp8E5xZGp4OvrZ61XH8YtA+VABvU1sPsNTkiOYxzmo290zPr4WuYBLgV/Nq9O+Fjo yv1DQ6uJ/qmhYmmaT1c14i1v8zfjYPD4AxPIiuhNCSURAvYs++8EmsuCufcbjU45lNSo= Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Marcel Ziswiler Fix HDMI requiring two regulators being enabled by a single GPIO. Model this using an intermediate reg_en_vdd_hdmi regulator being the vin-supply of them other two. This fixes the display subsystem and gets rid of the following error during boot: reg-fixed-voltage: probe of regulator-3v3-avdd-hdmi failed with error -16 tegra-hdmi 54280000.hdmi: failed to get VDD regulator Signed-off-by: Marcel Ziswiler --- Changes in v1: None arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 16 ++++++++++++---- arch/arm/boot/dts/tegra30-apalis.dtsi | 16 ++++++++++++---- arch/arm/boot/dts/tegra30-colibri.dtsi | 16 ++++++++++++---- 3 files changed, 36 insertions(+), 12 deletions(-) diff --git a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi index 02f8126481a2..065a24ac1052 100644 --- a/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi +++ b/arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi @@ -1133,8 +1133,7 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; enable-active-high; - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; - vin-supply = <®_1v8_vio>; + vin-supply = <®_en_vdd_hdmi>; }; reg_3v3_avdd_hdmi: regulator-3v3-avdd-hdmi { @@ -1143,8 +1142,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; enable-active-high; - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; - vin-supply = <®_module_3v3>; + vin-supply = <®_en_vdd_hdmi>; }; reg_5v0_charge_pump: regulator-5v0-charge-pump { @@ -1171,6 +1169,16 @@ regulator-always-on; }; + reg_en_vdd_hdmi: regulator-en-vdd-hdmi { + compatible = "regulator-fixed"; + regulator-name = "EN_VDD_HDMI"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; + vin-supply = <®_module_3v3>; + }; + sound { compatible = "toradex,tegra-audio-sgtl5000-apalis_t30", "nvidia,tegra-audio-sgtl5000"; diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi index 7f112f192fe9..6727c5868425 100644 --- a/arch/arm/boot/dts/tegra30-apalis.dtsi +++ b/arch/arm/boot/dts/tegra30-apalis.dtsi @@ -1115,8 +1115,7 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; enable-active-high; - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; - vin-supply = <®_1v8_vio>; + vin-supply = <®_en_vdd_hdmi>; }; reg_3v3_avdd_hdmi: regulator-3v3-avdd-hdmi { @@ -1125,8 +1124,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; enable-active-high; - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; - vin-supply = <®_module_3v3>; + vin-supply = <®_en_vdd_hdmi>; }; reg_5v0_charge_pump: regulator-5v0-charge-pump { @@ -1153,6 +1151,16 @@ regulator-always-on; }; + reg_en_vdd_hdmi: regulator-en-vdd-hdmi { + compatible = "regulator-fixed"; + regulator-name = "EN_VDD_HDMI"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; + vin-supply = <®_module_3v3>; + }; + sound { compatible = "toradex,tegra-audio-sgtl5000-apalis_t30", "nvidia,tegra-audio-sgtl5000"; diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi index 35af03ca9e90..963f26071415 100644 --- a/arch/arm/boot/dts/tegra30-colibri.dtsi +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi @@ -965,8 +965,7 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; enable-active-high; - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; - vin-supply = <®_1v8_vio>; + vin-supply = <®_en_vdd_hdmi>; }; reg_3v3_avdd_hdmi: regulator-3v3-avdd-hdmi { @@ -975,8 +974,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; enable-active-high; - gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; - vin-supply = <®_module_3v3>; + vin-supply = <®_en_vdd_hdmi>; }; reg_5v0_charge_pump: regulator-5v0-charge-pump { @@ -1012,6 +1010,16 @@ regulator-always-on; }; + reg_en_vdd_hdmi: regulator-en-vdd-hdmi { + compatible = "regulator-fixed"; + regulator-name = "EN_VDD_HDMI"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + gpio = <&pmic 6 GPIO_ACTIVE_HIGH>; + vin-supply = <®_module_3v3>; + }; + sound { compatible = "toradex,tegra-audio-sgtl5000-colibri_t30", "nvidia,tegra-audio-sgtl5000";