From patchwork Tue Aug 14 12:53:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Ziswiler X-Patchwork-Id: 957511 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ziswiler.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41qXbt4PWXz9s9l for ; Tue, 14 Aug 2018 22:54:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731751AbeHNPlU (ORCPT ); Tue, 14 Aug 2018 11:41:20 -0400 Received: from mout.perfora.net ([74.208.4.196]:49255 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731485AbeHNPlU (ORCPT ); Tue, 14 Aug 2018 11:41:20 -0400 Received: from localhost.localdomain.toradex.int ([46.140.72.82]) by mrelay.perfora.net (mreueus003 [74.208.5.2]) with ESMTPA (Nemesis) id 0M2exP-1g8Kho3fkL-00sRHh; Tue, 14 Aug 2018 14:54:02 +0200 From: Marcel Ziswiler To: linux-tegra@vger.kernel.org Cc: Lucas Stach , Marcel Ziswiler , Thierry Reding , Jonathan Hunter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie Subject: [PATCH v2] drm/tegra: hdmi: probe deferral error reporting Date: Tue, 14 Aug 2018 14:53:54 +0200 Message-Id: <20180814125355.29293-1-marcel@ziswiler.com> X-Mailer: git-send-email 2.14.4 X-Provags-ID: V03:K1:UwypYPOkSU0UORiPmTcL3TdIbomB2VnM0EWl2QauHTjCx/xqNOj fjGZ3P6a8XUmrxpdZh+L3d9zrwRMszdqqIff2xACR3SENsbF8i7pIFhqTmKj3xFPFYXWPWe xhY+3obDVnV2RXpWNLix705YjIrIAnsCXFiaMqSxUM3uP+DifIyMUifUTwO8froxOQumn9y dqr68wGFLI3UuGyRcOuog== X-UI-Out-Filterresults: notjunk:1; V01:K0:yia1fQ2YtoY=:K36yW73Z3pTIBvX4JneVk0 EiGcAyntzNj3CqO/M0iLHqdVVcH1Wem/bemMG6TxogarGk14P5hEwcZKLph6tdg/q4I3Y5ndw Qlzoc0QiyXn3xzyMYROX/YqAoqr/OQ/0SY2prb4fne1O0Ng+M9Cxj9dSyIMa623ZHebwP4DHU JSUWwBW27vpffJ4uK1ca9kHmpOyBG8sZIHOxJnSuU6H2JVTfT3QTPXEON2lRObwACoM4Lsf6c 9XXub4z3homS37OoXXBXM+V2t8Day6/volrVAd4+fynyFMCUqjzzg+PzHoqQNc6/p0azd3vv6 Vtujj5jpCiNZFRSPWNoAvKVVx+vFi78gTSCiOF5UFAVJfYSy5HC17hQTvg2eya8xCeoLV/+bI BarqPBKTVNHjSe4r80r3uu+al7yivlm/eP/fniI4ScQcVXE3IybmGSTnh7StCBu2eWv5FoVIM rryLUwgMIBmW4FtzmdjXbFOFWHosx/v4KjHnAtf3ryxvAkxaw9bP4D12gxFtbByB9TNfevgVg p5j2ud29QyRtU38MnlXkG+CdJu14dS1Q9VzmNfpCSwlNydykNJnZQQ47rMRhAkDtYMzQPTtCD W8czntk52yOaAR9a+3Cn5A5A9kPQpkFLo/RncRsjgFMtIsanPd/NgJ6Z7QBvVv6Lm2eh/c0Od 39a6SzyE0XFEnBJJEJnCnxRJWZ3Ee7AgFblJEJI6xkwPVFn+N1HXe/jFAcwkQZl4BVpM= Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Marcel Ziswiler Actually report the error code from devm_regulator_get() unless it is just a probe deferral. Signed-off-by: Marcel Ziswiler --- Changes in v2: - Silence probe deferral as suggested by Lucas. - Fix line over 80 characters as reported by checkpatch. drivers/gpu/drm/tegra/hdmi.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 0082468f703c..073d54b7225e 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -1693,14 +1693,22 @@ static int tegra_hdmi_probe(struct platform_device *pdev) hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi"); if (IS_ERR(hdmi->hdmi)) { - dev_err(&pdev->dev, "failed to get HDMI regulator\n"); - return PTR_ERR(hdmi->hdmi); + err = PTR_ERR(hdmi->hdmi); + if (err != -EPROBE_DEFER) + dev_err(&pdev->dev, "failed to get HDMI regulator: %d\n", + err); + + return err; } hdmi->pll = devm_regulator_get(&pdev->dev, "pll"); if (IS_ERR(hdmi->pll)) { - dev_err(&pdev->dev, "failed to get PLL regulator\n"); - return PTR_ERR(hdmi->pll); + err = PTR_ERR(hdmi->pll); + if (err != -EPROBE_DEFER) + dev_err(&pdev->dev, "failed to get PLL regulator: %d\n", + err); + + return err; } hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");