| Message ID | 20161108135058.1991567-1-arnd@arndb.de |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Nov 08, 2016 at 02:50:29PM +0100, Arnd Bergmann wrote: > The newly added driver fails to build right away: > > drivers/bus/tegra-gmi.c: In function 'tegra_gmi_parse_dt': > drivers/bus/tegra-gmi.c:97:11: error: 'dev' undeclared (first use in this function) > > I guess a last-minute change removed a local variable, this > adds the obvious definiton. > > Fixes: 4f95e6a5c9e4 ("bus: Add support for Tegra Generic Memory Interface") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/bus/tegra-gmi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This got reported by the 0-day builder earlier. Turns out this slipped through because my build setup failed to pick up the new configuration option. I pushed a fix for this to the Tegra tree, so it should all be good by tomorrow. Thanks, Thierry
diff --git a/drivers/bus/tegra-gmi.c b/drivers/bus/tegra-gmi.c index 44ee73186c5e..8b6ab0dd2f4c 100644 --- a/drivers/bus/tegra-gmi.c +++ b/drivers/bus/tegra-gmi.c @@ -90,9 +90,10 @@ static int tegra_gmi_parse_dt(struct tegra_gmi *gmi) { struct device_node *child; u32 property, ranges[4]; + struct device *dev = gmi->dev; int err; - child = of_get_next_available_child(gmi->dev->of_node, NULL); + child = of_get_next_available_child(dev->of_node, NULL); if (!child) { dev_err(dev, "no child nodes found\n"); return -ENODEV;
The newly added driver fails to build right away: drivers/bus/tegra-gmi.c: In function 'tegra_gmi_parse_dt': drivers/bus/tegra-gmi.c:97:11: error: 'dev' undeclared (first use in this function) I guess a last-minute change removed a local variable, this adds the obvious definiton. Fixes: 4f95e6a5c9e4 ("bus: Add support for Tegra Generic Memory Interface") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/bus/tegra-gmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)