From patchwork Thu Mar 26 12:52:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Swapna Nannapaneni X-Patchwork-Id: 455044 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41C1814007F for ; Thu, 26 Mar 2015 23:53:05 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=SRnpt2LX; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbbCZMxE (ORCPT ); Thu, 26 Mar 2015 08:53:04 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:36183 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094AbbCZMxD convert rfc822-to-8bit (ORCPT ); Thu, 26 Mar 2015 08:53:03 -0400 Received: by qgf60 with SMTP id 60so77916509qgf.3; Thu, 26 Mar 2015 05:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:content-transfer-encoding:message-id:date :subject:from:in-reply-to:references:to:cc; bh=4Z4Q8XJmxtU0+fv5O52dMkTmxwTUXv9ioon8LFl8xuc=; b=SRnpt2LXGYSj/im1Td7tdh6Xpm9eCFon+0f1It5Ronglp1ihNJaep5kvL0NBO2I8ro DuaFbBRlk3XpkP8xSkhRB8E4CgbauzkcwKPlrzPCCqaY2n6CL1d/ARLSFfM1ZB+QmAKm H9KmhgQbEGnz4TWLByDW9O/DilSWxfNOAc4onZ3Diim9hVDyHpSe1pNc+a97Gf3UOzto SFqpEN1bjR2WaaqruFtpgNQitZK9ynILn+/HNI5CQrdAcwBT8VUWl30zixeFiPBU6ie1 pZ8+5o2hSJqVvOWNcZcX2CDYedS97myYE6msiRir5YWyr14WTn4YrWWdnHX4WdUOoiiH QMNA== X-Received: by 10.140.134.135 with SMTP id 129mr3913114qhg.7.1427374374747; Thu, 26 Mar 2015 05:52:54 -0700 (PDT) Received: from [127.0.0.1] (out-on-160.wireless.telus.com. [207.219.69.160]) by mx.google.com with ESMTPSA id h6sm3416404qgh.32.2015.03.26.05.52.51 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Mar 2015 05:52:53 -0700 (PDT) MIME-Version: 1.0 X-Mailer: BlackBerry Email (10.3.1.2267) Message-ID: <20150326125251.5005382.96732.4883@gmail.com> Date: Thu, 26 Mar 2015 08:52:51 -0400 Subject: Re: [PATCH 02/16] iommu: Introduce iommu domain types From: Swapna Nannapaneni In-Reply-To: <1427373799-18662-3-git-send-email-joro@8bytes.org> References: <1427373799-18662-1-git-send-email-joro@8bytes.org> <1427373799-18662-3-git-send-email-joro@8bytes.org> To: Joerg Roedel , iommu@lists.linux-foundation.org Cc: Will Deacon , Kukjin Kim , David Woodhouse , Heiko Stuebner , Hiroshi Doyu , Stephen Warren , Thierry Reding , Alexandre Courbot , Alex Williamson , Arnd Bergmann , Yingjoe Chen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, Joerg Roedel , jroedel@suse.de Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org X Sent from my BlackBerry 10 smartphone on the TELUS network.   Original Message   From: Joerg Roedel Sentuv: Thursday, March 26, 2015 8:51 AM To: iommu@lists.linux-foundation.org Cc: Will Deacon; Kukjin Kim; David Woodhouse; Heiko Stuebner; Hiroshi Doyu; Stephen Warren; Thierry Reding; Alexandre Courbot; Alex Williamson; Arnd Bergmann; Yingjoe Chen; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-rockchip@lists.infradead.org; linux-tegra@vger.kernel.org; Joerg Roedel; jroedel@suse.de Subject: [PATCH 02/16] iommu: Introduce iommu domain types From: Joerg Roedel This allows to handle domains differently based on their type in the future. An IOMMU driver can implement certain optimizations for DMA-API domains for example. The domain types can be extended later and some of the existing domain attributes can be migrated to become domain flags. Signed-off-by: Joerg Roedel --- drivers/iommu/iommu.c | 5 +++-- include/linux/iommu.h | 27 ++++++++++++++++++++++++++- 2 files changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 11de262..4920605 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -909,14 +909,15 @@ struct iommu_domain *iommu_domain_alloc(struct bus_type *bus) ops = bus->iommu_ops; if (ops->domain_alloc) - domain = ops->domain_alloc(); + domain = ops->domain_alloc(IOMMU_DOMAIN_UNMANAGED); else domain = kzalloc(sizeof(*domain), GFP_KERNEL); if (!domain) return NULL; - domain->ops = bus->iommu_ops; + domain->ops = bus->iommu_ops; + domain->type = IOMMU_DOMAIN_UNMANAGED; if (ops->domain_init && domain->ops->domain_init(domain)) goto out_free; diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 69d1d12..72d03fe 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -51,7 +51,32 @@ struct iommu_domain_geometry { bool force_aperture; /* DMA only allowed in mappable range? */ }; +/* Domain feature flags */ +#define __IOMMU_DOMAIN_PAGING (1U << 0) /* Support for iommu_map/unmap */ +#define __IOMMU_DOMAIN_DMA_API (1U << 1) /* Domain for use in DMA-API + implementation */ +#define __IOMMU_DOMAIN_PT (1U << 2) /* Domain is identity mapped */ + +/* + * This are the possible domain-types + * + * IOMMU_DOMAIN_BLOCKED - All DMA is blocked, can be used to isolate + * devices + * IOMMU_DOMAIN_IDENTITY - DMA addresses are system physical addresses + * IOMMU_DOMAIN_UNMANAGED - DMA mappings managed by IOMMU-API user, used + * for VMs + * IOMMU_DOMAIN_DMA - Internally used for DMA-API implementations. + * This flag allows IOMMU drivers to implement + * certain optimizations for these domains + */ +#define IOMMU_DOMAIN_BLOCKED (0U) +#define IOMMU_DOMAIN_IDENTITY (__IOMMU_DOMAIN_PT) +#define IOMMU_DOMAIN_UNMANAGED (__IOMMU_DOMAIN_PAGING) +#define IOMMU_DOMAIN_DMA (__IOMMU_DOMAIN_PAGING | \ + __IOMMU_DOMAIN_DMA_API) + struct iommu_domain { + unsigned type; const struct iommu_ops *ops; void *priv; iommu_fault_handler_t handler; @@ -117,7 +142,7 @@ struct iommu_ops { void (*domain_destroy)(struct iommu_domain *domain); /* Domain allocation and freeing by the iommu driver */ - struct iommu_domain *(*domain_alloc)(void); + struct iommu_domain *(*domain_alloc)(unsigned iommu_domain_type); void (*domain_free)(struct iommu_domain *); int (*attach_dev)(struct iommu_domain *domain, struct device *dev);