From patchwork Thu Jul 23 12:18:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krishna Yarlagadda X-Patchwork-Id: 1334841 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.a=rsa-sha256 header.s=n1 header.b=dqdCbynR; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BCBG61Tkpz9sRK for ; Thu, 23 Jul 2020 22:19:10 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbgGWMTH (ORCPT ); Thu, 23 Jul 2020 08:19:07 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:7232 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgGWMTH (ORCPT ); Thu, 23 Jul 2020 08:19:07 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 23 Jul 2020 05:18:04 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 23 Jul 2020 05:19:06 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 23 Jul 2020 05:19:06 -0700 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 23 Jul 2020 12:19:06 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 23 Jul 2020 12:19:06 +0000 Received: from kyarlagadda-linux.nvidia.com (Not Verified[10.19.64.169]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Thu, 23 Jul 2020 05:19:05 -0700 From: Krishna Yarlagadda To: , , CC: , , , , , , Krishna Yarlagadda Subject: [PATCH 1/7] i2c: tegra: remove dead code Date: Thu, 23 Jul 2020 17:48:47 +0530 Message-ID: <1595506733-10307-1-git-send-email-kyarlagadda@nvidia.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1595506684; bh=fa+P5jAGVjPVirFmB1xYmlo1dz271n97QHWg6liSJZc=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type:Content-Transfer-Encoding; b=dqdCbynRWBTP0EBgNI6Jsw3LPfIDlnGpA5wTxo6YBYDADj05qQq6N62gGYPQRvode kSOeqaydNeULiJkUJELwwU1WPYuGGJCRnf8YnDMukhubNRerzk+xxiMuauyBHWqd8a +oJGTQOJnvRt6hBMFBEj4TJHpncqJihryRdX372SWX1D4R72sDTqm7nn3Srbh0rcok ecu+okg5mzW5BVQHyTGLzL1LRnz+3DMP4EiKp5KQDbj7RfB7jst0Afcsc9zetFkx63 Dq3A+ZPomsk3pLgRYff5tSxyGaBr3QtJVwD497rROpCjj2/BuG1t06fr2dRVLwNNVs pCQLncIXiqPGw== Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org From: Shardar Shariff Md When I2C_HEADER_CONT_ON_NAK bit in IO header is set then “No ACK from slave” error is not reported (NACK is considered as ACK and transfer is continued). So if I2C_ERR_NO_ACK is set, it would imply I2C_M_IGNORE_NAK is not set and hence this code will never execute. When I2C_HEADER_CONT_ON_NAK bit in IO header is set then “No ACK from slave” error is not reported. Condition (msg->flags & I2C_M_IGNORE_NAK) will never be hit Signed-off-by: Shardar Shariff Md Signed-off-by: Krishna Yarlagadda --- drivers/i2c/busses/i2c-tegra.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 1577296..c6c870c 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1336,11 +1336,8 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, return -EAGAIN; } - if (i2c_dev->msg_err == I2C_ERR_NO_ACK) { - if (msg->flags & I2C_M_IGNORE_NAK) - return 0; + if (i2c_dev->msg_err == I2C_ERR_NO_ACK) return -EREMOTEIO; - } return -EIO; }