| Message ID | 1320242948-21061-9-git-send-email-pdeschrijver@nvidia.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Nov 02, 2011 at 03:09:07PM +0100, Peter De Schrijver wrote: > Add support for the tegra30 based cardhu development board. Cardhu is a tablet > formfactor reference design for tegra30. The patch provides a device tree for > the board, updates Makefile.boot to build the dtb, includes the platform in > Kconfig and updates board-dt.c. > > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> > --- > arch/arm/boot/dts/tegra-cardhu.dts | 36 ++++++++++++++++++++++++++++++++++++ > arch/arm/mach-tegra/Kconfig | 7 +++++++ > arch/arm/mach-tegra/Makefile.boot | 1 + > arch/arm/mach-tegra/board-dt.c | 1 + > 4 files changed, 45 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/boot/dts/tegra-cardhu.dts > > diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts > new file mode 100644 > index 0000000..70c41fc > --- /dev/null > +++ b/arch/arm/boot/dts/tegra-cardhu.dts > @@ -0,0 +1,36 @@ > +/dts-v1/; > + > +/include/ "tegra30.dtsi" > + > +/ { > + model = "NVIDIA Tegra30 Cardhu evaluation board"; And this should probably be removed. > + compatible = "nvidia,cardhu", "nvidia,tegra30"; > + > + memory { > + reg = < 0x80000000 0x40000000 >; > + }; > + > + serial@70006000 { > + clock-frequency = < 408000000 >; > + }; > + > + i2c@7000c000 { > + clock-frequency = <100000>; > + }; > + > + i2c@7000c400 { > + clock-frequency = <100000>; > + }; > + > + i2c@7000c500 { > + clock-frequency = <100000>; > + }; > + > + i2c@7000c700 { > + clock-frequency = <100000>; > + }; > + > + i2c@7000d000 { > + clock-frequency = <100000>; > + }; > +}; > diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig > index f2eb6d1..43a6352 100644 > --- a/arch/arm/mach-tegra/Kconfig > +++ b/arch/arm/mach-tegra/Kconfig > @@ -83,6 +83,13 @@ config MACH_VENTANA > help > Support for the nVidia Ventana development platform > > +config MACH_CARDHU > + bool "Cardhu board" > + depends on ARCH_TEGRA_3x_SOC > + select MACH_TEGRA_DT > + help > + Support for the nVidia Cardhu development platform This should have been NVIDIA. Will be fixed in the next version. Most other nvidia boards use 'nVidia' in their description. What should we do? Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Peter De Schrijver wrote at Wednesday, November 02, 2011 9:46 AM: > On Wed, Nov 02, 2011 at 03:09:07PM +0100, Peter De Schrijver wrote: > > Add support for the tegra30 based cardhu development board. Cardhu is a tablet > > formfactor reference design for tegra30. The patch provides a device tree for > > the board, updates Makefile.boot to build the dtb, includes the platform in > > Kconfig and updates board-dt.c. ... > > diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts > > new file mode 100644 > > index 0000000..70c41fc > > --- /dev/null > > +++ b/arch/arm/boot/dts/tegra-cardhu.dts > > @@ -0,0 +1,36 @@ > > +/dts-v1/; > > + > > +/include/ "tegra30.dtsi" > > + > > +/ { > > + model = "NVIDIA Tegra30 Cardhu evaluation board"; > > And this should probably be removed. I don't follow the reasoning here; it seems correct to identify what this .dts file applies to, and having a model property is consistent with other .dts files, including non-Tegra boards.
On Wed, Nov 02, 2011 at 05:07:52PM +0100, Stephen Warren wrote: > Peter De Schrijver wrote at Wednesday, November 02, 2011 9:46 AM: > > On Wed, Nov 02, 2011 at 03:09:07PM +0100, Peter De Schrijver wrote: > > > Add support for the tegra30 based cardhu development board. Cardhu is a tablet > > > formfactor reference design for tegra30. The patch provides a device tree for > > > the board, updates Makefile.boot to build the dtb, includes the platform in > > > Kconfig and updates board-dt.c. > ... > > > diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts > > > new file mode 100644 > > > index 0000000..70c41fc > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/tegra-cardhu.dts > > > @@ -0,0 +1,36 @@ > > > +/dts-v1/; > > > + > > > +/include/ "tegra30.dtsi" > > > + > > > +/ { > > > + model = "NVIDIA Tegra30 Cardhu evaluation board"; > > > > And this should probably be removed. > > I don't follow the reasoning here; it seems correct to identify what this > .dts file applies to, and having a model property is consistent with other > .dts files, including non-Tegra boards. hmm :) Based on your comments on the previous version, I thought you wanted to move this do a different patch which also does it for other boards. Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 02, 2011 at 05:19:19PM +0100, Peter De Schrijver wrote: > On Wed, Nov 02, 2011 at 05:07:52PM +0100, Stephen Warren wrote: > > Peter De Schrijver wrote at Wednesday, November 02, 2011 9:46 AM: > > > On Wed, Nov 02, 2011 at 03:09:07PM +0100, Peter De Schrijver wrote: > > > > Add support for the tegra30 based cardhu development board. Cardhu is a tablet > > > > formfactor reference design for tegra30. The patch provides a device tree for > > > > the board, updates Makefile.boot to build the dtb, includes the platform in > > > > Kconfig and updates board-dt.c. > > ... > > > > diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts > > > > new file mode 100644 > > > > index 0000000..70c41fc > > > > --- /dev/null > > > > +++ b/arch/arm/boot/dts/tegra-cardhu.dts > > > > @@ -0,0 +1,36 @@ > > > > +/dts-v1/; > > > > + > > > > +/include/ "tegra30.dtsi" > > > > + > > > > +/ { > > > > + model = "NVIDIA Tegra30 Cardhu evaluation board"; > > > > > > And this should probably be removed. > > > > I don't follow the reasoning here; it seems correct to identify what this > > .dts file applies to, and having a model property is consistent with other > > .dts files, including non-Tegra boards. > > hmm :) Based on your comments on the previous version, I thought you wanted > to move this do a different patch which also does it for other boards. > Ok. The comment was related to device_type = "memory"; in the same patch. Sorry for the confusion. Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra-cardhu.dts b/arch/arm/boot/dts/tegra-cardhu.dts new file mode 100644 index 0000000..70c41fc --- /dev/null +++ b/arch/arm/boot/dts/tegra-cardhu.dts @@ -0,0 +1,36 @@ +/dts-v1/; + +/include/ "tegra30.dtsi" + +/ { + model = "NVIDIA Tegra30 Cardhu evaluation board"; + compatible = "nvidia,cardhu", "nvidia,tegra30"; + + memory { + reg = < 0x80000000 0x40000000 >; + }; + + serial@70006000 { + clock-frequency = < 408000000 >; + }; + + i2c@7000c000 { + clock-frequency = <100000>; + }; + + i2c@7000c400 { + clock-frequency = <100000>; + }; + + i2c@7000c500 { + clock-frequency = <100000>; + }; + + i2c@7000c700 { + clock-frequency = <100000>; + }; + + i2c@7000d000 { + clock-frequency = <100000>; + }; +}; diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig index f2eb6d1..43a6352 100644 --- a/arch/arm/mach-tegra/Kconfig +++ b/arch/arm/mach-tegra/Kconfig @@ -83,6 +83,13 @@ config MACH_VENTANA help Support for the nVidia Ventana development platform +config MACH_CARDHU + bool "Cardhu board" + depends on ARCH_TEGRA_3x_SOC + select MACH_TEGRA_DT + help + Support for the nVidia Cardhu development platform + choice prompt "Low-level debug console UART" default TEGRA_DEBUG_UART_NONE diff --git a/arch/arm/mach-tegra/Makefile.boot b/arch/arm/mach-tegra/Makefile.boot index bd12c9f..b518848 100644 --- a/arch/arm/mach-tegra/Makefile.boot +++ b/arch/arm/mach-tegra/Makefile.boot @@ -5,3 +5,4 @@ initrd_phys-$(CONFIG_ARCH_TEGRA_2x_SOC) := 0x00800000 dtb-$(CONFIG_MACH_HARMONY) += tegra-harmony.dtb dtb-$(CONFIG_MACH_SEABOARD) += tegra-seaboard.dtb dtb-$(CONFIG_MACH_VENTANA) += tegra-ventana.dtb +dtb-$(CONFIG_MACH_CARDHU) += tegra-cardhu.dtb diff --git a/arch/arm/mach-tegra/board-dt.c b/arch/arm/mach-tegra/board-dt.c index 1680e96..88947b5 100644 --- a/arch/arm/mach-tegra/board-dt.c +++ b/arch/arm/mach-tegra/board-dt.c @@ -142,6 +142,7 @@ static const char * tegra_dt_board_compat[] = { "nvidia,harmony", "nvidia,seaboard", "nvidia,ventana", + "nvidia,cardhu", NULL };
Add support for the tegra30 based cardhu development board. Cardhu is a tablet formfactor reference design for tegra30. The patch provides a device tree for the board, updates Makefile.boot to build the dtb, includes the platform in Kconfig and updates board-dt.c. Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> --- arch/arm/boot/dts/tegra-cardhu.dts | 36 ++++++++++++++++++++++++++++++++++++ arch/arm/mach-tegra/Kconfig | 7 +++++++ arch/arm/mach-tegra/Makefile.boot | 1 + arch/arm/mach-tegra/board-dt.c | 1 + 4 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tegra-cardhu.dts