| Message ID | 1318478219-9462-1-git-send-email-olof@lixom.net |
|---|---|
| State | Accepted, archived |
| Headers | show |
Olof Johansson wrote at Wednesday, October 12, 2011 9:57 PM: > Refresh tegra_defconfig: > > New options enabled: RTC, SPI, USB and USB_STORAGE together with > corresponding tegra drivers. Also enable some of the common usb ethernet > adapters. > > Finally, enable new merged boards (Ventana) and the generic devicetree board. > > Signed-off-by: Olof Johansson <olof@lixom.net> This transitively enables USE_OF by default. For Tegra, that's a good thing. However, it does mean we won't be able to detect code that only compiles with USE_OF enabled, which might affect other platform's buildability if we're talking about core code. I'm not sure if we should be concerned about this or not, or if ARM should select USE_OF now?
Olof Johansson wrote at Wednesday, October 12, 2011 9:57 PM: > Refresh tegra_defconfig: > > New options enabled: RTC, SPI, USB and USB_STORAGE together with > corresponding tegra drivers. Also enable some of the common usb ethernet > adapters. > > Finally, enable new merged boards (Ventana) and the generic devicetree board. > > Signed-off-by: Olof Johansson <olof@lixom.net> We should also enable ASoC (sound) support. Do you want to rev the patch, or should I submit a patch on top of yours?
On Thu, Oct 13, 2011 at 8:55 AM, Stephen Warren <swarren@nvidia.com> wrote: > Olof Johansson wrote at Wednesday, October 12, 2011 9:57 PM: >> Refresh tegra_defconfig: >> >> New options enabled: RTC, SPI, USB and USB_STORAGE together with >> corresponding tegra drivers. Also enable some of the common usb ethernet >> adapters. >> >> Finally, enable new merged boards (Ventana) and the generic devicetree board. >> >> Signed-off-by: Olof Johansson <olof@lixom.net> > > This transitively enables USE_OF by default. For Tegra, that's a good > thing. However, it does mean we won't be able to detect code that only > compiles with USE_OF enabled, which might affect other platform's > buildability if we're talking about core code. I'm not sure if we should > be concerned about this or not, or if ARM should select USE_OF now? Right, it uses USE_OF by default because the TEGRA_DT board was enabled. The defconfig should really be a superset of needed configs for running on most hardware out there (since we do a multiplatform kernel), so keeping it enabled on Tegra does make some sense. Also, the direction is to keep moving towards 100% device-tree (on tegra), it does make sense to keep it enabled. For testing, explicitly disabling it to compile-test will be needed for a while longer, but I don't expect to do much !USE_OF work (for tegra specifically) in the times ahead. When changing ARM-generic core code, you should probably pick a few other defconfigs and make sure those build as well -- that should cover those aspects. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 13, 2011 at 9:03 AM, Stephen Warren <swarren@nvidia.com> wrote: > Olof Johansson wrote at Wednesday, October 12, 2011 9:57 PM: >> Refresh tegra_defconfig: >> >> New options enabled: RTC, SPI, USB and USB_STORAGE together with >> corresponding tegra drivers. Also enable some of the common usb ethernet >> adapters. >> >> Finally, enable new merged boards (Ventana) and the generic devicetree board. >> >> Signed-off-by: Olof Johansson <olof@lixom.net> > > We should also enable ASoC (sound) support. Do you want to rev the patch, or > should I submit a patch on top of yours? Let's keep the amount of defconfig churn down as much as possible, since it's somewhat of a touchy subject. Please send me a patch but I'll squash it in with mine when I apply it. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig index 8845f1c..953aefe 100644 --- a/arch/arm/configs/tegra_defconfig +++ b/arch/arm/configs/tegra_defconfig @@ -25,6 +25,7 @@ CONFIG_MACH_KAEN=y CONFIG_MACH_PAZ00=y CONFIG_MACH_TRIMSLICE=y CONFIG_MACH_WARIO=y +CONFIG_MACH_VENTANA=y CONFIG_TEGRA_DEBUG_UARTD=y CONFIG_ARM_ERRATA_742230=y CONFIG_NO_HZ=y @@ -38,7 +39,6 @@ CONFIG_HIGHMEM=y CONFIG_ZBOOT_ROM_TEXT=0x0 CONFIG_ZBOOT_ROM_BSS=0x0 CONFIG_VFP=y -CONFIG_PM=y CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y @@ -65,6 +65,7 @@ CONFIG_IPV6_TUNNEL=y CONFIG_IPV6_MULTIPLE_TABLES=y # CONFIG_WIRELESS is not set # CONFIG_FIRMWARE_IN_KERNEL is not set +CONFIG_PROC_DEVICETREE=y CONFIG_BLK_DEV_LOOP=y CONFIG_MISC_DEVICES=y CONFIG_AD525X_DPOT=y @@ -72,34 +73,49 @@ CONFIG_AD525X_DPOT_I2C=y CONFIG_ICS932S401=y CONFIG_APDS9802ALS=y CONFIG_ISL29003=y +CONFIG_SCSI=y +CONFIG_BLK_DEV_SD=y +# CONFIG_SCSI_LOWLEVEL is not set CONFIG_NETDEVICES=y CONFIG_DUMMY=y +CONFIG_NET_ETHERNET=y CONFIG_R8169=y # CONFIG_NETDEV_10000 is not set # CONFIG_WLAN is not set +CONFIG_USB_PEGASUS=y +CONFIG_USB_USBNET=y +CONFIG_USB_NET_SMSC75XX=y +CONFIG_USB_NET_SMSC95XX=y # CONFIG_INPUT is not set # CONFIG_SERIO is not set # CONFIG_VT is not set +# CONFIG_LEGACY_PTYS is not set # CONFIG_DEVKMEM is not set CONFIG_SERIAL_8250=y CONFIG_SERIAL_8250_CONSOLE=y -# CONFIG_LEGACY_PTYS is not set +CONFIG_SERIAL_OF_PLATFORM=y # CONFIG_HW_RANDOM is not set CONFIG_I2C=y # CONFIG_I2C_COMPAT is not set # CONFIG_I2C_HELPER_AUTO is not set CONFIG_I2C_TEGRA=y +CONFIG_SPI=y +CONFIG_SPI_TEGRA=y CONFIG_SENSORS_LM90=y CONFIG_MFD_TPS6586X=y CONFIG_REGULATOR=y CONFIG_REGULATOR_TPS6586X=y -# CONFIG_USB_SUPPORT is not set +CONFIG_USB=y +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_EHCI_TEGRA=y +CONFIG_USB_STORAGE=y CONFIG_MMC=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_PLTFM=y CONFIG_MMC_SDHCI_TEGRA=y +CONFIG_RTC_CLASS=y +CONFIG_RTC_DRV_TEGRA=y CONFIG_STAGING=y -# CONFIG_STAGING_EXCLUDE_BUILD is not set CONFIG_IIO=y CONFIG_SENSORS_ISL29018=y CONFIG_SENSORS_AK8975=y @@ -123,18 +139,15 @@ CONFIG_NLS_ISO8859_1=y CONFIG_PRINTK_TIME=y CONFIG_MAGIC_SYSRQ=y CONFIG_DEBUG_FS=y -CONFIG_DEBUG_KERNEL=y CONFIG_DETECT_HUNG_TASK=y CONFIG_SCHEDSTATS=y CONFIG_TIMER_STATS=y CONFIG_DEBUG_SLAB=y # CONFIG_DEBUG_PREEMPT is not set CONFIG_DEBUG_MUTEXES=y -CONFIG_DEBUG_SPINLOCK_SLEEP=y CONFIG_DEBUG_INFO=y CONFIG_DEBUG_VM=y CONFIG_DEBUG_SG=y -# CONFIG_RCU_CPU_STALL_DETECTOR is not set CONFIG_DEBUG_LL=y CONFIG_EARLY_PRINTK=y CONFIG_CRYPTO_ECB=y
Refresh tegra_defconfig: New options enabled: RTC, SPI, USB and USB_STORAGE together with corresponding tegra drivers. Also enable some of the common usb ethernet adapters. Finally, enable new merged boards (Ventana) and the generic devicetree board. Signed-off-by: Olof Johansson <olof@lixom.net> --- arch/arm/configs/tegra_defconfig | 29 +++++++++++++++++++++-------- 1 files changed, 21 insertions(+), 8 deletions(-)