| Message ID | 0e36c4295adc4f2daae9715cd0dde87d@HQMAIL102.nvidia.com |
|---|---|
| State | Deferred |
| Headers | show |
The series looks ok to me, the only problem I see is that we are lacking means to thoroughly test host1x patches across all the supported Tegra chips. Could you detail what kind of testing this patch series has undergone, and which chips/boards have been tested? On Wed, Mar 18, 2015 at 9:53 AM, David Ung <davidu@nvidia.com> wrote: > ping? > > ________________________________________ > From: David Ung <davidu@nvidia.com> > Sent: Thursday, March 5, 2015 5:51 PM > To: airlied@linux.ie > Cc: linux-tegra@vger.kernel.org; thierry.reding@gmail.com; swarren@wwwdotorg.org; Arto Merilainen; Terje Bergstrom; gnurou@gmail.com; David Ung > Subject: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation size > > There is 2 set of num_relocs * sizeof(*) array at the end of host1x job. > Only the 1st set is really used and with job->gather_addr_phys pointing > somewhere within the 1st set of reloc physical addresses. > This patch removes the 2nd set of unused addresses. > > Signed-off-by: David Ung <davidu@nvidia.com> > --- > drivers/gpu/host1x/job.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c > index 63bd63f..9c11265 100644 > --- a/drivers/gpu/host1x/job.c > +++ b/drivers/gpu/host1x/job.c > @@ -46,8 +46,9 @@ struct host1x_job *host1x_job_alloc(struct host1x_channel *ch, > (u64)num_unpins * sizeof(struct host1x_job_unpin_data) + > (u64)num_waitchks * sizeof(struct host1x_waitchk) + > (u64)num_cmdbufs * sizeof(struct host1x_job_gather) + > - (u64)num_unpins * sizeof(dma_addr_t) + > - (u64)num_unpins * sizeof(u32 *); > + (u64)num_relocs * sizeof(dma_addr_t) + > + (u64)num_cmdbufs * sizeof(dma_addr_t); > + > if (total > ULONG_MAX) > return NULL; > > -- > 1.8.1.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Alexandre Courbot [mailto:gnurou@gmail.com] > Sent: Monday, March 23, 2015 12:09 AM > To: David Ung > Cc: airlied@linux.ie; linux-tegra@vger.kernel.org; > thierry.reding@gmail.com; swarren@wwwdotorg.org; Arto Merilainen; > Terje Bergstrom > Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation size > > The series looks ok to me, the only problem I see is that we are lacking > means to thoroughly test host1x patches across all the supported Tegra > chips. > > Could you detail what kind of testing this patch series has undergone, and > which chips/boards have been tested? Tested the host1x channel tests for T132 on A44. Also ran Paul's EIMT set up which only tests booting kernel to console for T20/T30/T114/T124 and QEMU
On Tue, Mar 24, 2015 at 4:39 AM, David Ung <davidu@nvidia.com> wrote: > >> -----Original Message----- >> From: Alexandre Courbot [mailto:gnurou@gmail.com] >> Sent: Monday, March 23, 2015 12:09 AM >> To: David Ung >> Cc: airlied@linux.ie; linux-tegra@vger.kernel.org; >> thierry.reding@gmail.com; swarren@wwwdotorg.org; Arto Merilainen; >> Terje Bergstrom >> Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation size >> >> The series looks ok to me, the only problem I see is that we are lacking >> means to thoroughly test host1x patches across all the supported Tegra >> chips. >> >> Could you detail what kind of testing this patch series has undergone, and >> which chips/boards have been tested? > > Tested the host1x channel tests for T132 on A44. > Also ran Paul's EIMT set up which only tests booting kernel to console for T20/T30/T114/T124 and QEMU Thierry, what do you think? I know we are lacking proper testing infrastructure for host1x, but these patches really looks harmless to me. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Alexandre Courbot [mailto:gnurou@gmail.com] > Sent: Monday, March 30, 2015 11:30 PM > To: David Ung; thierry.reding@gmail.com > Cc: airlied@linux.ie; linux-tegra@vger.kernel.org; > swarren@wwwdotorg.org; Arto Merilainen; Terje Bergstrom > Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation size > > On Tue, Mar 24, 2015 at 4:39 AM, David Ung <davidu@nvidia.com> wrote: > > > >> -----Original Message----- > >> From: Alexandre Courbot [mailto:gnurou@gmail.com] > >> Sent: Monday, March 23, 2015 12:09 AM > >> To: David Ung > >> Cc: airlied@linux.ie; linux-tegra@vger.kernel.org; > >> thierry.reding@gmail.com; swarren@wwwdotorg.org; Arto Merilainen; > >> Terje Bergstrom > >> Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation > >> size > >> > >> The series looks ok to me, the only problem I see is that we are > >> lacking means to thoroughly test host1x patches across all the > >> supported Tegra chips. > >> > >> Could you detail what kind of testing this patch series has > >> undergone, and which chips/boards have been tested? > > > > Tested the host1x channel tests for T132 on A44. > > Also ran Paul's EIMT set up which only tests booting kernel to console > > for T20/T30/T114/T124 and QEMU > > Thierry, what do you think? > > I know we are lacking proper testing infrastructure for host1x, but these > patches really looks harmless to me. Thank you Alex for the review. It would be good to have closure to this patchset. Thierry ping?
Forgot this: Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> On Fri, Apr 3, 2015 at 8:13 AM, David Ung <davidu@nvidia.com> wrote: >> -----Original Message----- >> From: Alexandre Courbot [mailto:gnurou@gmail.com] >> Sent: Monday, March 30, 2015 11:30 PM >> To: David Ung; thierry.reding@gmail.com >> Cc: airlied@linux.ie; linux-tegra@vger.kernel.org; >> swarren@wwwdotorg.org; Arto Merilainen; Terje Bergstrom >> Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation size >> >> On Tue, Mar 24, 2015 at 4:39 AM, David Ung <davidu@nvidia.com> wrote: >> > >> >> -----Original Message----- >> >> From: Alexandre Courbot [mailto:gnurou@gmail.com] >> >> Sent: Monday, March 23, 2015 12:09 AM >> >> To: David Ung >> >> Cc: airlied@linux.ie; linux-tegra@vger.kernel.org; >> >> thierry.reding@gmail.com; swarren@wwwdotorg.org; Arto Merilainen; >> >> Terje Bergstrom >> >> Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation >> >> size >> >> >> >> The series looks ok to me, the only problem I see is that we are >> >> lacking means to thoroughly test host1x patches across all the >> >> supported Tegra chips. >> >> >> >> Could you detail what kind of testing this patch series has >> >> undergone, and which chips/boards have been tested? >> > >> > Tested the host1x channel tests for T132 on A44. >> > Also ran Paul's EIMT set up which only tests booting kernel to console >> > for T20/T30/T114/T124 and QEMU >> >> Thierry, what do you think? >> >> I know we are lacking proper testing infrastructure for host1x, but these >> patches really looks harmless to me. > > > Thank you Alex for the review. > It would be good to have closure to this patchset. > > Thierry ping? > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 02, 2015 at 11:13:38PM +0000, David Ung wrote: > > -----Original Message----- > > From: Alexandre Courbot [mailto:gnurou@gmail.com] > > Sent: Monday, March 30, 2015 11:30 PM > > To: David Ung; thierry.reding@gmail.com > > Cc: airlied@linux.ie; linux-tegra@vger.kernel.org; > > swarren@wwwdotorg.org; Arto Merilainen; Terje Bergstrom > > Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation size > > > > On Tue, Mar 24, 2015 at 4:39 AM, David Ung <davidu@nvidia.com> wrote: > > > > > >> -----Original Message----- > > >> From: Alexandre Courbot [mailto:gnurou@gmail.com] > > >> Sent: Monday, March 23, 2015 12:09 AM > > >> To: David Ung > > >> Cc: airlied@linux.ie; linux-tegra@vger.kernel.org; > > >> thierry.reding@gmail.com; swarren@wwwdotorg.org; Arto Merilainen; > > >> Terje Bergstrom > > >> Subject: Re: [PATCH V2 1/3] gpu: host1x: Reduce host1x job allocation > > >> size > > >> > > >> The series looks ok to me, the only problem I see is that we are > > >> lacking means to thoroughly test host1x patches across all the > > >> supported Tegra chips. > > >> > > >> Could you detail what kind of testing this patch series has > > >> undergone, and which chips/boards have been tested? > > > > > > Tested the host1x channel tests for T132 on A44. > > > Also ran Paul's EIMT set up which only tests booting kernel to console > > > for T20/T30/T114/T124 and QEMU > > > > Thierry, what do you think? > > > > I know we are lacking proper testing infrastructure for host1x, but these > > patches really looks harmless to me. > > > Thank you Alex for the review. > It would be good to have closure to this patchset. We'll get closure on this once the testing infrastructure appears. I won't apply these patches before then. Thierry
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c index 63bd63f..9c11265 100644 --- a/drivers/gpu/host1x/job.c +++ b/drivers/gpu/host1x/job.c @@ -46,8 +46,9 @@ struct host1x_job *host1x_job_alloc(struct host1x_channel *ch, (u64)num_unpins * sizeof(struct host1x_job_unpin_data) + (u64)num_waitchks * sizeof(struct host1x_waitchk) + (u64)num_cmdbufs * sizeof(struct host1x_job_gather) + - (u64)num_unpins * sizeof(dma_addr_t) + - (u64)num_unpins * sizeof(u32 *); + (u64)num_relocs * sizeof(dma_addr_t) + + (u64)num_cmdbufs * sizeof(dma_addr_t); + if (total > ULONG_MAX) return NULL;