mbox series

[0/2] phy: tegra: xusb: fix device(_node) release in tegra210_xusb_padctl_probe

Message ID 20241028-phy-tegra-xusb-tegra210-put_device-v1-0-28f74368c9ba@gmail.com
Headers show
Series phy: tegra: xusb: fix device(_node) release in tegra210_xusb_padctl_probe | expand

Message

Javier Carrasco Oct. 28, 2024, 10:33 p.m. UTC 
This series fixes two similar issues in tegra_210_xusb_padctl_probe().

Two resources (device_node *np and the device within struct
platform_device *pdev) are acquired, but never released after they are
no longer needed. To avoid leaking such resources, calls to
of_node_put() and put_device() must be added.

In this case, the resources are not assigned anywhere in the probe
function, and they must be released in the error and success paths. If
I overlooked any assignment, please report it as an error.

I have tried to affect the existing code and execution paths as less as
possible by releasing the device and device_node as soon as possible,
but if goto jumps to labels for the cleanup are desired, I can go for
that approach instead.

This series has been compiled successfully, but not tested on real
hardware as I don't have access to it. Any validation with the affected
hardware is always welcome.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Javier Carrasco (2):
      phy: tegra: xusb: fix device release in tegra210_xusb_padctl_probe
      phy: tegra: xusb: fix device node release in tegra210_xusb_padctl_probe

 drivers/phy/tegra/xusb-tegra210.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
---
base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d
change-id: 20241028-phy-tegra-xusb-tegra210-put_device-ff7ae76403b4

Best regards,