mbox series

[net,v6,0/2] Fix AQR PMA capabilities

Message ID 20241001224626.2400222-1-quic_abchauha@quicinc.com
Headers show
Series Fix AQR PMA capabilities | expand

Message

Abhishek Chauhan Oct. 1, 2024, 10:46 p.m. UTC 
Patch 1:- 
AQR115c reports incorrect PMA capabilities which includes
10G/5G and also incorrectly disables capabilities like autoneg
and 10Mbps support.

AQR115c as per the Marvell databook supports speeds up to 2.5Gbps
with autonegotiation.

Patch 2:- 
Remove the use of phy_set_max_speed in phy driver as the
function is mainly used in MAC driver to set the max
speed.

Instead use get_features to fix up Phy PMA capabilities for
AQR111, AQR111B0, AQR114C and AQCS109


Abhishek Chauhan (2):
  net: phy: aquantia: AQR115c fix up PMA capabilities
  net: phy: aquantia: remove usage of phy_set_max_speed

 drivers/net/phy/aquantia/aquantia_main.c | 51 +++++++++++++++---------
 1 file changed, 33 insertions(+), 18 deletions(-)

Comments

Russell King (Oracle) Oct. 1, 2024, 11:13 p.m. UTC | #1 
On Tue, Oct 01, 2024 at 03:46:24PM -0700, Abhishek Chauhan wrote:
> Patch 1:- 
> AQR115c reports incorrect PMA capabilities which includes
> 10G/5G and also incorrectly disables capabilities like autoneg
> and 10Mbps support.
> 
> AQR115c as per the Marvell databook supports speeds up to 2.5Gbps
> with autonegotiation.
> 
> Patch 2:- 
> Remove the use of phy_set_max_speed in phy driver as the
> function is mainly used in MAC driver to set the max
> speed.
> 
> Instead use get_features to fix up Phy PMA capabilities for
> AQR111, AQR111B0, AQR114C and AQCS109

For both patches:

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!
patchwork-bot+netdevbpf@kernel.org Oct. 3, 2024, 11:20 p.m. UTC | #2 
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  1 Oct 2024 15:46:24 -0700 you wrote:
> Patch 1:-
> AQR115c reports incorrect PMA capabilities which includes
> 10G/5G and also incorrectly disables capabilities like autoneg
> and 10Mbps support.
> 
> AQR115c as per the Marvell databook supports speeds up to 2.5Gbps
> with autonegotiation.
> 
> [...]

Here is the summary with links:
  - [net,v6,1/2] net: phy: aquantia: AQR115c fix up PMA capabilities
    https://git.kernel.org/netdev/net/c/17cbfcdd85f6
  - [net,v6,2/2] net: phy: aquantia: remove usage of phy_set_max_speed
    https://git.kernel.org/netdev/net/c/8f61d73306c6

You are awesome, thank you!