| Message ID | 20240704-tegra210_emcfreq-v4-0-3e450503c555@tecnico.ulisboa.pt |
|---|---|
| Headers | show |
| Series | memory: tegra: Cleanup Tegra210 EMC frequency scaling | expand |
On 04/07/2024 13:31, Diogo Ivo wrote: > Hello, > > This patch series consists of a general cleanup of the Tegra210 EMC > frequency scaling code for revision 7. > > Currently the code is relying heavily on a function, update_clock_tree_delay(), > that is responsible for too many things, making it long and confusing. > The general idea with these patches is to simplify this function and its > surrounding code, making it more modular. > > The motivation behind these changes (besides improving readability and > maintainability) is to make it simpler to add support in the future for > frequency change revisions other than 7, where we can reuse a large > portion of the modularized code rather than essentially repeating 2k > lines of code with minimal changes. > > There are no functional changes with this patch set, as it is only meant > as preparation for following patches where revision 6 support is added. > > Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt> > --- > Changes in v4: > - PATCH 07/07: Add missing parenthesis around operands when calculating > delay > - Link to v3: https://lore.kernel.org/r/20240507093056.3921-1-diogo.ivo@tecnico.ulisboa.pt > > --- > Diogo Ivo (7): > memory: tegra: Remove periodic compensation duplicate calls > memory: tegra: Move DQSOSC measurement to common place > memory: tegra: Reword and correct comments > memory: tegra: Change macros to interpret parameter as integer > memory: tegra: Loop update_clock_tree_delay() > memory: tegra: Move compare/update current delay values to a function > memory: tegra: Rework update_clock_tree_delay() > > drivers/memory/tegra/tegra210-emc-cc-r21021.c | 429 ++++++-------------------- > 1 file changed, 86 insertions(+), 343 deletions(-) > --- > base-commit: 22a40d14b572deb80c0648557f4bd502d7e83826 > change-id: 20240704-tegra210_emcfreq-9d2466310cec I don't understand what happened with this series. lore cannot find anything for above change-id. b4 diff also fails: b4 diff '<20240704-tegra210_emcfreq-v4-0-3e450503c555@tecnico.ulisboa.pt>' Grabbing thread from lore.kernel.org/all/20240704-tegra210_emcfreq-v4-0-3e450503c555@tecnico.ulisboa.pt/t.mbox.gz Checking for older revisions Grabbing search results from lore.kernel.org Nothing matching that query. --- Analyzing 8 messages in the thread Could not find lower series to compare against. Link to v3 does not point to v3, but to some resend. Changelog is incomplete - mentions only v3, but what happened between v1->v2, v2->v3? There is canonical way to send patches which makes everything straightforward (and IMHO easy). It's called b4. But you can just use git format-patch and git send-email. Whatever you choose, this makes maintainer life easy. Way you sent patches is somehow broken, I don't know how, but it does not make maintainer life easy. Please reply with changelog and explanation where is original v3. Best regards, Krzysztof
On Thu, 04 Jul 2024 12:31:19 +0100, Diogo Ivo wrote: > This patch series consists of a general cleanup of the Tegra210 EMC > frequency scaling code for revision 7. > > Currently the code is relying heavily on a function, update_clock_tree_delay(), > that is responsible for too many things, making it long and confusing. > The general idea with these patches is to simplify this function and its > surrounding code, making it more modular. > > [...] OK, I found v2 and v3, downloaded and compared. It would have been much easier if `b4 diff` just worked, so please be sure to send patches in canonical way so maintainer's workflow is easy. Applied, thanks! [1/7] memory: tegra: Remove periodic compensation duplicate calls https://git.kernel.org/krzk/linux-mem-ctrl/c/649f4783dcda7400bbed866140df504d09a3b135 [2/7] memory: tegra: Move DQSOSC measurement to common place https://git.kernel.org/krzk/linux-mem-ctrl/c/7b4dcb8888e1660d590ec13463ba71ec5bbf6333 [3/7] memory: tegra: Reword and correct comments https://git.kernel.org/krzk/linux-mem-ctrl/c/c5f83622ccd0158cf16c6be8ba56f178c99776a5 [4/7] memory: tegra: Change macros to interpret parameter as integer https://git.kernel.org/krzk/linux-mem-ctrl/c/a238f62b3666558f38d8abf688d0fecf4ccb48ee [5/7] memory: tegra: Loop update_clock_tree_delay() https://git.kernel.org/krzk/linux-mem-ctrl/c/adc720820f963047210efc4fe1c1ff068b4bd773 [6/7] memory: tegra: Move compare/update current delay values to a function https://git.kernel.org/krzk/linux-mem-ctrl/c/b109656e9ca399d6899152eb40efac2bdd3b4202 [7/7] memory: tegra: Rework update_clock_tree_delay() https://git.kernel.org/krzk/linux-mem-ctrl/c/ddb869ea237eb4e1c882c8768675fad53623b062 Best regards,
Hello, This patch series consists of a general cleanup of the Tegra210 EMC frequency scaling code for revision 7. Currently the code is relying heavily on a function, update_clock_tree_delay(), that is responsible for too many things, making it long and confusing. The general idea with these patches is to simplify this function and its surrounding code, making it more modular. The motivation behind these changes (besides improving readability and maintainability) is to make it simpler to add support in the future for frequency change revisions other than 7, where we can reuse a large portion of the modularized code rather than essentially repeating 2k lines of code with minimal changes. There are no functional changes with this patch set, as it is only meant as preparation for following patches where revision 6 support is added. Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt> --- Changes in v4: - PATCH 07/07: Add missing parenthesis around operands when calculating delay - Link to v3: https://lore.kernel.org/r/20240507093056.3921-1-diogo.ivo@tecnico.ulisboa.pt --- Diogo Ivo (7): memory: tegra: Remove periodic compensation duplicate calls memory: tegra: Move DQSOSC measurement to common place memory: tegra: Reword and correct comments memory: tegra: Change macros to interpret parameter as integer memory: tegra: Loop update_clock_tree_delay() memory: tegra: Move compare/update current delay values to a function memory: tegra: Rework update_clock_tree_delay() drivers/memory/tegra/tegra210-emc-cc-r21021.c | 429 ++++++-------------------- 1 file changed, 86 insertions(+), 343 deletions(-) --- base-commit: 22a40d14b572deb80c0648557f4bd502d7e83826 change-id: 20240704-tegra210_emcfreq-9d2466310cec Best regards,