mbox series

[V4,0/4] hwmon: ina3221: Add selective summation support

Message ID 20230929102744.84989-1-jonathanh@nvidia.com
Headers show
Series hwmon: ina3221: Add selective summation support | expand

Message

Jon Hunter Sept. 29, 2023, 10:27 a.m. UTC 
The current INA3221 driver always sums the shunt voltage for all enabled
channels regardless of the shunt-resistor used for each channel. Summing
the shunt-voltage for channels is only meaningful if the shunt resistor
is the same for each channel. This series adds device-tree support to
allow which channels are summed in device-tree.

Changes since V3:
- Added missing descriptions for new structure members that was reported
  by the kernel-test-bot.
- Added comment in the ina3221 dt-binding doc example to explain why we
  need to explicitly disable channels.
- Added more commentary in the commit message for the new DT property
  to explain that this property does not change the behaviour of the
  driver unless it is populated.

Changes since V2:
- Added note to binding-doc to indicate that input channels must be
  explicitly disabled.
- Corrected ordering of properties in the binding-doc
- Updated license for the binding-doc to be dual licensed.
- Changed newly added property from 'summation-bypass' to
  summation-disable'.
- Documented type for the new 'summation-disable' property.
- Corrected spelling and comments as per the feedback received.
- Used debugfs instead of sysfs for exposing the 'summation-disable'
  status for each input channel.
- Populated missing instances for the ina3221 device for Tegra234
  boards.
- Populated ina219 device for the NVIDIA IGX board (not strictly
  related to this series but related to populating all
  power-sensors for Tegra234 boards)

Changes since V1:
- Added yaml conversion patch for binding-doc
- Added binding-doc documentation patch for new property
- Added patch to populate ina3221 devices for Tegra234.

Jon Hunter (2):
  dt-bindings: hwmon: ina3221: Add ti,summation-disable
  arm64: tegra: Add power-sensors for Tegra234 boards

Ninad Malwade (2):
  dt-bindings: hwmon: ina3221: Convert to json-schema
  hwmon: ina3221: Add support for channel summation disable

 .../devicetree/bindings/hwmon/ina3221.txt     |  54 --------
 .../devicetree/bindings/hwmon/ti,ina3221.yaml | 121 ++++++++++++++++++
 .../boot/dts/nvidia/tegra234-p3701-0008.dtsi  |  33 +++++
 .../arm64/boot/dts/nvidia/tegra234-p3701.dtsi |  53 ++++++++
 .../arm64/boot/dts/nvidia/tegra234-p3767.dtsi |  29 +++++
 drivers/hwmon/ina3221.c                       |  33 ++++-
 6 files changed, 266 insertions(+), 57 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/ina3221.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml

Comments

Jon Hunter Sept. 29, 2023, 10:38 a.m. UTC | #1 
On 29/09/2023 11:27, Jon Hunter wrote:
> The current INA3221 driver always sums the shunt voltage for all enabled
> channels regardless of the shunt-resistor used for each channel. Summing
> the shunt-voltage for channels is only meaningful if the shunt resistor
> is the same for each channel. This series adds device-tree support to
> allow which channels are summed in device-tree.
> 
> Changes since V3:
> - Added missing descriptions for new structure members that was reported
>    by the kernel-test-bot.
> - Added comment in the ina3221 dt-binding doc example to explain why we
>    need to explicitly disable channels.
> - Added more commentary in the commit message for the new DT property
>    to explain that this property does not change the behaviour of the
>    driver unless it is populated.


Ignore this version. I messed up which patch where I added the new 
comment for the dt-binding doc.

Jon