mbox series

[v13,0/6] mmc: sdhci: Add Tegra234 support

Message ID 20221206165945.3551774-1-thierry.reding@gmail.com
Headers show
Series mmc: sdhci: Add Tegra234 support | expand

Message

Thierry Reding Dec. 6, 2022, 4:59 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

Hi,

This is an updated version of v12 from a few days ago:

    https://lore.kernel.org/all/20221202152644.29450-1-thierry.reding@gmail.com/

The only difference here is a fix for the included headers (bitops.h
does not have all the definitions on all architectures, so we need
bitfield.h instead) and an Acked-by from Robin on the new Tegra-specific
helper.

It'd be great to see this go in for v6.2 so that the new helper is
available for the next release and the other patches that I have
prepared can be merged.

Ulf, given that Joerg has acked patch 1 and Robin has acked patch 2, I
think the expectation is for you to pick up the whole set.

Thanks,
Thierry

Prathamesh Shete (3):
  mmc: sdhci-tegra: Separate Tegra194 and Tegra234 SoC data
  mmc: sdhci-tegra: Add support to program MC stream ID
  mmc: sdhci-tegra: Issue CMD and DAT resets together

Thierry Reding (3):
  iommu: Add note about struct iommu_fwspec usage
  iommu/tegra: Add tegra_dev_iommu_get_stream_id() helper
  mmc: sdhci-tegra: Sort includes alphabetically

 drivers/mmc/host/sdhci-tegra.c | 69 ++++++++++++++++++++++++++++------
 drivers/mmc/host/sdhci.c       |  5 +++
 drivers/mmc/host/sdhci.h       |  2 +
 include/linux/iommu.h          | 25 ++++++++++++
 4 files changed, 89 insertions(+), 12 deletions(-)

Comments

Ulf Hansson Dec. 7, 2022, 12:37 p.m. UTC | #1
+ Stephen Rothwell

On Tue, 6 Dec 2022 at 17:59, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
> Hi,
>
> This is an updated version of v12 from a few days ago:
>
>     https://lore.kernel.org/all/20221202152644.29450-1-thierry.reding@gmail.com/
>
> The only difference here is a fix for the included headers (bitops.h
> does not have all the definitions on all architectures, so we need
> bitfield.h instead) and an Acked-by from Robin on the new Tegra-specific
> helper.
>
> It'd be great to see this go in for v6.2 so that the new helper is
> available for the next release and the other patches that I have
> prepared can be merged.
>
> Ulf, given that Joerg has acked patch 1 and Robin has acked patch 2, I
> think the expectation is for you to pick up the whole set.

Applied for next, thanks!

Note that, it seems likely that we may encounter a merge conflict
between the mmc and iommu tree, due to changes in
include/linux/iommu.h. Although, if that's the case, I believe the
conflict should be trivial to resolve, so let's try this and see how
it goes.

Stephen, I added you here, just to let you know of what goes on.

>
> Thanks,
> Thierry
>
> Prathamesh Shete (3):
>   mmc: sdhci-tegra: Separate Tegra194 and Tegra234 SoC data
>   mmc: sdhci-tegra: Add support to program MC stream ID
>   mmc: sdhci-tegra: Issue CMD and DAT resets together
>
> Thierry Reding (3):
>   iommu: Add note about struct iommu_fwspec usage
>   iommu/tegra: Add tegra_dev_iommu_get_stream_id() helper
>   mmc: sdhci-tegra: Sort includes alphabetically
>
>  drivers/mmc/host/sdhci-tegra.c | 69 ++++++++++++++++++++++++++++------
>  drivers/mmc/host/sdhci.c       |  5 +++
>  drivers/mmc/host/sdhci.h       |  2 +
>  include/linux/iommu.h          | 25 ++++++++++++
>  4 files changed, 89 insertions(+), 12 deletions(-)

Kind regards
Uffe
Stephen Rothwell Dec. 7, 2022, 11:47 p.m. UTC | #2
Hi all,

On Wed, 7 Dec 2022 13:37:52 +0100 Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Tue, 6 Dec 2022 at 17:59, Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Hi,
> >
> > This is an updated version of v12 from a few days ago:
> >
> >     https://lore.kernel.org/all/20221202152644.29450-1-thierry.reding@gmail.com/
> >
> > The only difference here is a fix for the included headers (bitops.h
> > does not have all the definitions on all architectures, so we need
> > bitfield.h instead) and an Acked-by from Robin on the new Tegra-specific
> > helper.
> >
> > It'd be great to see this go in for v6.2 so that the new helper is
> > available for the next release and the other patches that I have
> > prepared can be merged.
> >
> > Ulf, given that Joerg has acked patch 1 and Robin has acked patch 2, I
> > think the expectation is for you to pick up the whole set.  
> 
> Applied for next, thanks!
> 
> Note that, it seems likely that we may encounter a merge conflict
> between the mmc and iommu tree, due to changes in
> include/linux/iommu.h. Although, if that's the case, I believe the
> conflict should be trivial to resolve, so let's try this and see how
> it goes.
> 
> Stephen, I added you here, just to let you know of what goes on.
> 
> >
> > Thanks,
> > Thierry
> >
> > Prathamesh Shete (3):
> >   mmc: sdhci-tegra: Separate Tegra194 and Tegra234 SoC data
> >   mmc: sdhci-tegra: Add support to program MC stream ID
> >   mmc: sdhci-tegra: Issue CMD and DAT resets together
> >
> > Thierry Reding (3):
> >   iommu: Add note about struct iommu_fwspec usage
> >   iommu/tegra: Add tegra_dev_iommu_get_stream_id() helper
> >   mmc: sdhci-tegra: Sort includes alphabetically
> >
> >  drivers/mmc/host/sdhci-tegra.c | 69 ++++++++++++++++++++++++++++------
> >  drivers/mmc/host/sdhci.c       |  5 +++
> >  drivers/mmc/host/sdhci.h       |  2 +
> >  include/linux/iommu.h          | 25 ++++++++++++
> >  4 files changed, 89 insertions(+), 12 deletions(-)  

All good. Thanks for the heads up.

BTW, it would be good if some of those long lines in comments were
wrapped ...
Thierry Reding Dec. 8, 2022, 12:04 a.m. UTC | #3
On Thu, Dec 08, 2022 at 10:47:49AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 7 Dec 2022 13:37:52 +0100 Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > On Tue, 6 Dec 2022 at 17:59, Thierry Reding <thierry.reding@gmail.com> wrote:
> > >
> > > From: Thierry Reding <treding@nvidia.com>
> > >
> > > Hi,
> > >
> > > This is an updated version of v12 from a few days ago:
> > >
> > >     https://lore.kernel.org/all/20221202152644.29450-1-thierry.reding@gmail.com/
> > >
> > > The only difference here is a fix for the included headers (bitops.h
> > > does not have all the definitions on all architectures, so we need
> > > bitfield.h instead) and an Acked-by from Robin on the new Tegra-specific
> > > helper.
> > >
> > > It'd be great to see this go in for v6.2 so that the new helper is
> > > available for the next release and the other patches that I have
> > > prepared can be merged.
> > >
> > > Ulf, given that Joerg has acked patch 1 and Robin has acked patch 2, I
> > > think the expectation is for you to pick up the whole set.  
> > 
> > Applied for next, thanks!
> > 
> > Note that, it seems likely that we may encounter a merge conflict
> > between the mmc and iommu tree, due to changes in
> > include/linux/iommu.h. Although, if that's the case, I believe the
> > conflict should be trivial to resolve, so let's try this and see how
> > it goes.
> > 
> > Stephen, I added you here, just to let you know of what goes on.
> > 
> > >
> > > Thanks,
> > > Thierry
> > >
> > > Prathamesh Shete (3):
> > >   mmc: sdhci-tegra: Separate Tegra194 and Tegra234 SoC data
> > >   mmc: sdhci-tegra: Add support to program MC stream ID
> > >   mmc: sdhci-tegra: Issue CMD and DAT resets together
> > >
> > > Thierry Reding (3):
> > >   iommu: Add note about struct iommu_fwspec usage
> > >   iommu/tegra: Add tegra_dev_iommu_get_stream_id() helper
> > >   mmc: sdhci-tegra: Sort includes alphabetically
> > >
> > >  drivers/mmc/host/sdhci-tegra.c | 69 ++++++++++++++++++++++++++++------
> > >  drivers/mmc/host/sdhci.c       |  5 +++
> > >  drivers/mmc/host/sdhci.h       |  2 +
> > >  include/linux/iommu.h          | 25 ++++++++++++
> > >  4 files changed, 89 insertions(+), 12 deletions(-)  
> 
> All good. Thanks for the heads up.
> 
> BTW, it would be good if some of those long lines in comments were
> wrapped ...

Hm... looks like I misinterpreted the checkpatch.pl change from a while
ago. I should probably switch back my editor settings if the preference
is still 80 characters instead of the 100 enforced by checkpatch.

Thierry