mbox series

[GIT,PULL] pwm: Three fixes for the pwm-stm32 driver

Message ID 2d2qmxla4hcug3mx4puvhrnezwjw6xp6xdnwodggcdglghmx4w@wqd7rv5qys73
State Rejected
Headers show
Series [GIT,PULL] pwm: Three fixes for the pwm-stm32 driver | expand

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git tags/pwm/for-6.10-rc5-fixes

Message

Uwe Kleine-König June 21, 2024, 7:18 a.m. UTC
Hello Linus,

The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:

  Linux 6.10-rc1 (2024-05-26 15:20:12 -0700)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git tags/pwm/for-6.10-rc5-fixes

for you to fetch changes up to 4120bc75cf95bb1b10df83e85a0478f292ea97cc:

  pwm: stm32: Fix error message to not describe the previous error path (2024-06-21 08:57:12 +0200)

The first two patches were in next since Wednesday as

	215d1aa8b5a7 ("pwm: stm32: Refuse too small period requests")
	ea80bdb90a5d ("pwm: stm32: Fix calculation of prescaler")

I rewrote them for this PR to add a review tag and improve the commit
log. I also dropped Cc: stable for the latter, because the offending
commit is only included in v6.10-rc1; there are no code changes.

While preparing this PR I noticed the bogus error message fixed in the
third patch. I consider this obviously right enough to include it here
without cooking in next.

Please pull this for 6.10-rc5.

Thanks
Uwe

----------------------------------------------------------------
pwm: Three fixes for the pwm-stm32 driver

The first patch prevents an integer wrap-around for small periods. In
the second patch the calculation for the input clock prescaler is
corrected which resulted in another wrap-around and so bogus period
configurations. The last commit improves an error message that was
wrongly copied from another error path.

----------------------------------------------------------------

Uwe Kleine-König (3):
      pwm: stm32: Refuse too small period requests
      pwm: stm32: Fix calculation of prescaler
      pwm: stm32: Fix error message to not describe the previous error path

 drivers/pwm/pwm-stm32.c | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

Comments

Uwe Kleine-König June 21, 2024, 9:41 a.m. UTC | #1
Hello Linus,

On Fri, Jun 21, 2024 at 09:18:08AM +0200, Uwe Kleine-König wrote:
> The following changes since commit 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0:
> 
>   Linux 6.10-rc1 (2024-05-26 15:20:12 -0700)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git tags/pwm/for-6.10-rc5-fixes
> 
> for you to fetch changes up to 4120bc75cf95bb1b10df83e85a0478f292ea97cc:
> 
>   pwm: stm32: Fix error message to not describe the previous error path (2024-06-21 08:57:12 +0200)
> 
> The first two patches were in next since Wednesday as
> 
> 	215d1aa8b5a7 ("pwm: stm32: Refuse too small period requests")
> 	ea80bdb90a5d ("pwm: stm32: Fix calculation of prescaler")
> 
> I rewrote them for this PR to add a review tag and improve the commit
> log. I also dropped Cc: stable for the latter, because the offending
> commit is only included in v6.10-rc1; there are no code changes.
> 
> While preparing this PR I noticed the bogus error message fixed in the
> third patch. I consider this obviously right enough to include it here
> without cooking in next.
> 
> Please pull this for 6.10-rc5.

I assume you didn't pull yet, please don't. During some more tests I
found another corner case that isn't properly handled by commit "pwm:
stm32: Fix calculation of prescaler". I removed the tag my repository,
will send you another PR once I'm convinced I really fixed the problem.

Sorry for the confusion,
Uwe