| Message ID | 20240731191312.1710417-25-robh@kernel.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: Use of_property_read_bool() | expand |
Hello, On Wed, Jul 31, 2024 at 01:13:03PM -0600, Rob Herring (Arm) wrote: > Use of_property_read_bool() to read boolean properties rather than > of_get_property(). This is part of a larger effort to remove callers > of of_get_property() and similar functions. of_get_property() leaks > the DT property data pointer which is a problem for dynamically > allocated nodes which may be freed. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > drivers/pwm/pwm-omap-dmtimer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good to me. Unless you object I'd apply with adding "omap-dmtimer: " to the short log. Best regards Uwe
On Thu, Aug 1, 2024 at 3:41 AM Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote: > > Hello, > > On Wed, Jul 31, 2024 at 01:13:03PM -0600, Rob Herring (Arm) wrote: > > Use of_property_read_bool() to read boolean properties rather than > > of_get_property(). This is part of a larger effort to remove callers > > of of_get_property() and similar functions. of_get_property() leaks > > the DT property data pointer which is a problem for dynamically > > allocated nodes which may be freed. > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > > --- > > drivers/pwm/pwm-omap-dmtimer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Looks good to me. Unless you object I'd apply with adding > "omap-dmtimer: " to the short log. No objection and sorry I missed that. Rob
On Tue, Sep 03, 2024 at 02:19:01PM -0500, Rob Herring wrote: > On Thu, Aug 1, 2024 at 3:41 AM Uwe Kleine-König > <u.kleine-koenig@baylibre.com> wrote: > > > > Hello, > > > > On Wed, Jul 31, 2024 at 01:13:03PM -0600, Rob Herring (Arm) wrote: > > > Use of_property_read_bool() to read boolean properties rather than > > > of_get_property(). This is part of a larger effort to remove callers > > > of of_get_property() and similar functions. of_get_property() leaks > > > the DT property data pointer which is a problem for dynamically > > > allocated nodes which may be freed. > > > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > > > --- > > > drivers/pwm/pwm-omap-dmtimer.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Looks good to me. Unless you object I'd apply with adding > > "omap-dmtimer: " to the short log. > > No objection and sorry I missed that. No problem for me, applied with the mentioned change to the short log to https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next . Best regards Uwe
diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c index cd51c4a938f5..e514f3614c43 100644 --- a/drivers/pwm/pwm-omap-dmtimer.c +++ b/drivers/pwm/pwm-omap-dmtimer.c @@ -355,7 +355,7 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev) goto err_platdata; } - if (!of_get_property(timer, "ti,timer-pwm", NULL)) { + if (!of_property_read_bool(timer, "ti,timer-pwm")) { dev_err(&pdev->dev, "Missing ti,timer-pwm capability\n"); ret = -ENODEV; goto err_timer_property;
Use of_property_read_bool() to read boolean properties rather than of_get_property(). This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/pwm/pwm-omap-dmtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)