| Message ID | 20240710234116.2370655-3-gnstark@salutedevices.com |
|---|---|
| State | New |
| Headers | show |
| Series | pwm: meson: add pwm support for A1 | expand |
On Thu, Jul 11, 2024 at 02:41:15AM +0300, George Stark wrote: > The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF. > > Signed-off-by: George Stark <gnstark@salutedevices.com> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> Missing ack from Conor. When you submit new versions, it is your responsibility to add tags. > --- > .../devicetree/bindings/pwm/pwm-amlogic.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+)
Hello Rob, Conor On 7/12/24 15:52, Rob Herring wrote: > On Thu, Jul 11, 2024 at 02:41:15AM +0300, George Stark wrote: >> The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF. >> >> Signed-off-by: George Stark <gnstark@salutedevices.com> >> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > Missing ack from Conor. When you submit new versions, it is your > responsibility to add tags. I had Conor's ack in my mind but his response was related to the squashed patch (a1 compatible + power domains) and the current patch was a bit different that's why I didn't dare to add the ack. Conor, do you mind if I resend this patch (and may be [PATCH v4 1/3]) with your ack? > >> --- >> .../devicetree/bindings/pwm/pwm-amlogic.yaml | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+)
On Fri, Jul 12, 2024 at 06:12:26PM +0300, George Stark wrote: > Hello Rob, Conor > > On 7/12/24 15:52, Rob Herring wrote: > > On Thu, Jul 11, 2024 at 02:41:15AM +0300, George Stark wrote: > > > The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF. > > > > > > Signed-off-by: George Stark <gnstark@salutedevices.com> > > > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > > > Missing ack from Conor. When you submit new versions, it is your > > responsibility to add tags. > > I had Conor's ack in my mind but his response was related to the > squashed patch (a1 compatible + power domains) and the current patch was > a bit different that's why I didn't dare to add the ack. > > Conor, do you mind if I resend this patch (and may be [PATCH v4 1/3]) > with your ack? Ye, both are fine :+1:
diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml index 267908c2bf7b..e021cf59421a 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml @@ -37,6 +37,10 @@ properties: - enum: - amlogic,meson8-pwm-v2 - amlogic,meson-s4-pwm + - items: + - enum: + - amlogic,meson-a1-pwm + - const: amlogic,meson-s4-pwm - items: - enum: - amlogic,meson8b-pwm-v2 @@ -139,6 +143,16 @@ allOf: required: - clocks + - if: + properties: + compatible: + contains: + enum: + - amlogic,meson-a1-pwm + then: + required: + - power-domains + additionalProperties: false examples: