| Message ID | 20240614090829.560605-1-sean@mess.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | bus: ts-nbus: Use pwm_apply_might_sleep() | expand |
Hello, [To: += Arnd] On Fri, Jun 14, 2024 at 10:08:29AM +0100, Sean Young wrote: > pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename > pwm_apply_state() to pwm_apply_might_sleep()"). > > Signed-off-by: Sean Young <sean@mess.org> > --- > drivers/bus/ts-nbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c > index baf22a82c47a7..b8af44c5cdbd0 100644 > --- a/drivers/bus/ts-nbus.c > +++ b/drivers/bus/ts-nbus.c > @@ -294,7 +294,7 @@ static int ts_nbus_probe(struct platform_device *pdev) > state.duty_cycle = state.period; > state.enabled = true; > > - ret = pwm_apply_state(pwm, &state); > + ret = pwm_apply_might_sleep(pwm, &state); > if (ret < 0) > return dev_err_probe(dev, ret, "failed to configure PWM\n"); Thanks. I guess the patch becoming 8129d25e32b7fd0f77bc664252321f3a16bb26b8 was created a while before pwm_apply_might_sleep() was a thing. Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Arnd, you merged the last changes to that driver. Do you want to care for that one, too? If not I can apply it via my pwm tree. Best regards Uwe
On Fri, Jun 14, 2024, at 12:06, Uwe Kleine-König wrote: > On Fri, Jun 14, 2024 at 10:08:29AM +0100, Sean Young wrote: > > Thanks. I guess the patch becoming > 8129d25e32b7fd0f77bc664252321f3a16bb26b8 was created a while before > pwm_apply_might_sleep() was a thing. > > Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> > > Arnd, you merged the last changes to that driver. Do you want to care > for that one, too? If not I can apply it via my pwm tree. Whichever works best for you. I generally take drivers/bus and drivers/soc fixes through the soc tree, but if this is a PWM related change then having it in the pwm tree makes sense as well. If you like me to pick it up through the soc tree, please forward the fix to soc@kernel.org. Arnd
Hello Arnd, On Fri, Jun 14, 2024 at 01:38:05PM +0200, Arnd Bergmann wrote: > On Fri, Jun 14, 2024, at 12:06, Uwe Kleine-König wrote: > > On Fri, Jun 14, 2024 at 10:08:29AM +0100, Sean Young wrote: > > > > Thanks. I guess the patch becoming > > 8129d25e32b7fd0f77bc664252321f3a16bb26b8 was created a while before > > pwm_apply_might_sleep() was a thing. > > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> > > > > Arnd, you merged the last changes to that driver. Do you want to care > > for that one, too? If not I can apply it via my pwm tree. > > Whichever works best for you. I generally take drivers/bus > and drivers/soc fixes through the soc tree, but if this is > a PWM related change then having it in the pwm tree makes > sense as well. > > If you like me to pick it up through the soc tree, please > forward the fix to soc@kernel.org. OK, then I pick it up and consider it done. Thanks. Best regards Uwe
diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index baf22a82c47a7..b8af44c5cdbd0 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -294,7 +294,7 @@ static int ts_nbus_probe(struct platform_device *pdev) state.duty_cycle = state.period; state.enabled = true; - ret = pwm_apply_state(pwm, &state); + ret = pwm_apply_might_sleep(pwm, &state); if (ret < 0) return dev_err_probe(dev, ret, "failed to configure PWM\n");
pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename pwm_apply_state() to pwm_apply_might_sleep()"). Signed-off-by: Sean Young <sean@mess.org> --- drivers/bus/ts-nbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)