[3/3] pwm: Make pwm_request_from_chip() private to the core

Message ID	20240607084416.897777-8-u.kleine-koenig@baylibre.com
State	Accepted
Headers	show Return-Path: <linux-pwm+bounces-2373-incoming=patchwork.ozlabs.org@vger.kernel.org> From: " =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= " <ukleinek@baylibre.com> To: Benson Leung <bleung@chromium.org> Cc: Guenter Roeck <groeck@chromium.org>, linux-pwm@vger.kernel.org, chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] pwm: Make pwm_request_from_chip() private to the core Date: Fri, 7 Jun 2024 10:44:17 +0200 Message-ID: <20240607084416.897777-8-u.kleine-koenig@baylibre.com> In-Reply-To: <20240607084416.897777-5-u.kleine-koenig@baylibre.com> References: <20240607084416.897777-5-u.kleine-koenig@baylibre.com> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Series	pwm: cros-ec: Some simplifications \| expand [0/3] pwm: cros-ec: Some simplifications [1/3] pwm: cros-ec: Don't care about consumers in .get_state() [2/3] pwm: cros-ec: Simplify device tree xlation [3/3] pwm: Make pwm_request_from_chip() private to the core

Message ID

20240607084416.897777-8-u.kleine-koenig@baylibre.com

State

Accepted

Headers

From: " =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= " <ukleinek@baylibre.com>
To: Benson Leung <bleung@chromium.org>
Cc: Guenter Roeck <groeck@chromium.org>,
	linux-pwm@vger.kernel.org,
	chrome-platform@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] pwm: Make pwm_request_from_chip() private to the core
Date: Fri,  7 Jun 2024 10:44:17 +0200
Message-ID: <20240607084416.897777-8-u.kleine-koenig@baylibre.com>
In-Reply-To: <20240607084416.897777-5-u.kleine-koenig@baylibre.com>
References: <20240607084416.897777-5-u.kleine-koenig@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Series

pwm: cros-ec: Some simplifications | expand

Commit Message

Uwe Kleine-König June 7, 2024, 8:44 a.m. UTC

The last user of this function outside of core.c is gone, so it can be
made static.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 drivers/pwm/core.c  |  8 +++-----
 include/linux/pwm.h | 12 ------------
 2 files changed, 3 insertions(+), 17 deletions(-)

Comments

Tzung-Bi Shih June 12, 2024, 6:27 a.m. UTC | #1

On Fri, Jun 07, 2024 at 10:44:17AM +0200, Uwe Kleine-König wrote:
> The last user of this function outside of core.c is gone, so it can be
> made static.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 18574857641e..76969d5052af 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -394,9 +394,9 @@  static int pwm_device_request(struct pwm_device *pwm, const char *label)
  * chip. A negative error code is returned if the index is not valid for the
  * specified PWM chip or if the PWM device cannot be requested.
  */
-struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip,
-					 unsigned int index,
-					 const char *label)
+static struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip,
+						unsigned int index,
+						const char *label)
 {
 	struct pwm_device *pwm;
 	int err;
@@ -414,8 +414,6 @@  struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip,
 	mutex_unlock(&pwm_lock);
 	return pwm;
 }
-EXPORT_SYMBOL_GPL(pwm_request_from_chip);
-
 
 struct pwm_device *
 of_pwm_xlate_with_flags(struct pwm_chip *chip, const struct of_phandle_args *args)
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 60b92c2c75ef..3ac1a04acc0e 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -407,10 +407,6 @@  void pwmchip_remove(struct pwm_chip *chip);
 int __devm_pwmchip_add(struct device *dev, struct pwm_chip *chip, struct module *owner);
 #define devm_pwmchip_add(dev, chip) __devm_pwmchip_add(dev, chip, THIS_MODULE)
 
-struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip,
-					 unsigned int index,
-					 const char *label);
-
 struct pwm_device *of_pwm_xlate_with_flags(struct pwm_chip *chip,
 		const struct of_phandle_args *args);
 struct pwm_device *of_pwm_single_xlate(struct pwm_chip *chip,
@@ -505,14 +501,6 @@  static inline int devm_pwmchip_add(struct device *dev, struct pwm_chip *chip)
 	return -EINVAL;
 }
 
-static inline struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip,
-						       unsigned int index,
-						       const char *label)
-{
-	might_sleep();
-	return ERR_PTR(-ENODEV);
-}
-
 static inline struct pwm_device *pwm_get(struct device *dev,
 					 const char *consumer)
 {

[3/3] pwm: Make pwm_request_from_chip() private to the core

Commit Message

Comments

Patch