From patchwork Mon Oct 9 20:42:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 1845474 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=VbVJoH3q; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4S49vf4FGMz1ypX for ; Tue, 10 Oct 2023 07:42:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378003AbjJIUmg (ORCPT ); Mon, 9 Oct 2023 16:42:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377979AbjJIUmf (ORCPT ); Mon, 9 Oct 2023 16:42:35 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92E9E92 for ; Mon, 9 Oct 2023 13:42:33 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-41810cfc569so32655401cf.2 for ; Mon, 09 Oct 2023 13:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1696884152; x=1697488952; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=wksn2ye7hg5JYQ/b4QzcrS4iyVG/SEhWePVlKH6CS0o=; b=VbVJoH3qYgSj3+etWAnhYBiqbgpxcAD21Qv+icQlu0LBlpR7EIvPHzlQb6ViF3yNzZ giaOQEdEumfLLXWj/RrvAE6GK6aJoX8zCpFu93AVAyPiYgDBUOyycA7Z2bKMGIvqF2/4 KALX1abdpHfpqfocKML/7xbZbhitrJ5J/nKzc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696884152; x=1697488952; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wksn2ye7hg5JYQ/b4QzcrS4iyVG/SEhWePVlKH6CS0o=; b=Kjm5A9oIPGVN8lTz02kW4DjgrKdzfcMGNZrOyyRPKvsD+0AdaSykX0TVsZcwjFPp58 80gh8AGuHv8LP7fbCkObXvsc8aJs13FOvNohorWz1QAomIEh/y8x/Y8NVR98RQ6ZgGum fZIE3bwJBkclV/dMr+q6HZ69DKGn+k+qCv83BzlJy8wj5cTOL0a4J7t1/r53Z+dg3hsy i2+LpL0e/AOpVTUmCvBMCAWUVsrvUDVS+FZr+uP9BlCMYDUPA4JvvjWGEjiOGvRRPksC Cmqe5n9qYgOef0FAtz6u7BNeiFmEEAx/q2gOAkgY6gAluKIkMWTszCzUQfIe2uj+9Hlj 9xmw== X-Gm-Message-State: AOJu0YwmN5kzxY7Izcj7J05tLIRtrBWKuaT6+fh8XQ5SzqHh4Db/FrlZ CjSulV9w8EGuDYHkVjFPMyQ9JVvyljSpVjWr78RMArJaLdAY91oQ9aQYdOQBN9YCozCZfA9VkMM 0q0uEQyApi0aWmlt7J8yqWpkwUqmWOiVtR6quSXnMwFCGTY94n/tchi7jro8SpNaeGhtXJbThRV RsPUtrOKi10osziw== X-Google-Smtp-Source: AGHT+IGitQZigQOV8jF0NpM9P7N0RQuLQO5jc3KoXDJU9IxUR/tSVv/R9LVUS1ob0426rAZpq02CGw== X-Received: by 2002:ac8:5b49:0:b0:418:bd5:f682 with SMTP id n9-20020ac85b49000000b004180bd5f682mr24003565qtw.33.1696884152308; Mon, 09 Oct 2023 13:42:32 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id w7-20020ac84d07000000b0040399fb5ef3sm3973703qtv.0.2023.10.09.13.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 13:42:31 -0700 (PDT) From: Florian Fainelli To: linux-pwm@vger.kernel.org Cc: Florian Fainelli , Angus Clark , Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] pwm: bcm2835: Add support for suspend/resume Date: Mon, 9 Oct 2023 13:42:26 -0700 Message-Id: <20231009204226.3224521-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MIME_NO_TEXT, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Similar to other drivers, we need to make sure that the clock is disabled during suspend and re-enabled during resume. Reported-by: Angus Clark Signed-off-by: Florian Fainelli --- Changes in v2: - use DEFINE_SIMPLE_DEV_PM_OPS as suggested by Uwe drivers/pwm/pwm-bcm2835.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c index bdfc2a5ec0d6..938f993ae746 100644 --- a/drivers/pwm/pwm-bcm2835.c +++ b/drivers/pwm/pwm-bcm2835.c @@ -182,6 +182,25 @@ static void bcm2835_pwm_remove(struct platform_device *pdev) clk_disable_unprepare(pc->clk); } +static int __maybe_unused bcm2835_pwm_suspend(struct device *dev) +{ + struct bcm2835_pwm *pc = dev_get_drvdata(dev); + + clk_disable_unprepare(pc->clk); + + return 0; +} + +static int __maybe_unused bcm2835_pwm_resume(struct device *dev) +{ + struct bcm2835_pwm *pc = dev_get_drvdata(dev); + + return clk_prepare_enable(pc->clk); +} + +static DEFINE_SIMPLE_DEV_PM_OPS(bcm2835_pwm_pm_ops, bcm2835_pwm_suspend, + bcm2835_pwm_resume); + static const struct of_device_id bcm2835_pwm_of_match[] = { { .compatible = "brcm,bcm2835-pwm", }, { /* sentinel */ } @@ -192,6 +211,7 @@ static struct platform_driver bcm2835_pwm_driver = { .driver = { .name = "bcm2835-pwm", .of_match_table = bcm2835_pwm_of_match, + .pm = &bcm2835_pwm_pm_ops, }, .probe = bcm2835_pwm_probe, .remove_new = bcm2835_pwm_remove,