From patchwork Thu Oct 5 16:47:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 1844078 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=el4JCpJP; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4S1dD32DbYz1yqD for ; Fri, 6 Oct 2023 04:02:59 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbjJERCZ (ORCPT ); Thu, 5 Oct 2023 13:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjJERBK (ORCPT ); Thu, 5 Oct 2023 13:01:10 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AD5530C4 for ; Thu, 5 Oct 2023 09:47:40 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-d81afd5273eso1286491276.3 for ; Thu, 05 Oct 2023 09:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1696524459; x=1697129259; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=PoVomi2ZwlMZ7qbjjknKXFPZPpyZXB9jbmXueY034xc=; b=el4JCpJPl8tO91eU982HSzJ+EsdVY3VAVDewAuLR6WgPIw0zrTABvVUHEe/WTexEDC JvpEM0J4ASkbNw6n0/dYqYaEYuWZkDSQsCTYfGy8FlGUYOlyJYFJJiziWyoW/hgS2EHT sKBpw/4c3nuKkvxvNI4VVXwSNFkUNId20inu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696524459; x=1697129259; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PoVomi2ZwlMZ7qbjjknKXFPZPpyZXB9jbmXueY034xc=; b=j+m74F6WnqrmEVCZ12d7dRJjbj2xEpVtF7fymuQrBXmOgGNNADARrJxNoTvrYRrZC6 eetf8Q9+FEBsAVhxYPsAekkCLZtfiqXFDab+EI7SjjSCMWREmj3r1YIdP+mXE8pWShc/ uSTmTFzdr/qE7n6xPRrWgIQPtefj3g4v4E9Sn3IQygBWpOPwkEfdtYiHeQPdK+hLZEvR 6T8tCSX/ZXlqcfhX5aQpCxGa6+Oxkrd/dnXUvFhCO4SwlfOXx4t1TkWhr6VLTyOjrabe tR2G/ejQqbw9Cr1lVN3si0eDIQ9UtvRhim50jpJ4D4JbuhA8ofR+b/GgTy2H7+JlYYPq hiMQ== X-Gm-Message-State: AOJu0YxTlkbgefuHUYnaWtC/TTwFITDxseH+jct57+4/ljmk8q6w8K1c dum6Fy75JQv+zwsIqPyZ5qaFpFyMmai7CA45/Dj0EsdWzc9QP3WSBAkCfuxixHdA82SgXSUqd08 ZRbCbvZ0dUjTR0cPUSjPyzPQm+N1xoS6sHK17BYqAj57+HgRXpcFJiQn8FK4/ikuPUDOk5eovGE VwGKtlSu6gadvb/A== X-Google-Smtp-Source: AGHT+IHUvbeX/9TMTGXpNeMZiRb9jaigp92I+hDJiGNTjvImbmpxdtAVzNB0BDPzxvh0h2OlThcAVA== X-Received: by 2002:a25:8b84:0:b0:d09:34f4:6698 with SMTP id j4-20020a258b84000000b00d0934f46698mr4993619ybl.36.1696524458725; Thu, 05 Oct 2023 09:47:38 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x15-20020a0ce0cf000000b0065b2e561c17sm623761qvk.123.2023.10.05.09.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 09:47:38 -0700 (PDT) From: Florian Fainelli To: linux-pwm@vger.kernel.org Cc: Florian Fainelli , =?utf-8?q?Uwe_Kleine-K?= =?utf-8?q?=C3=B6nig?= , Thierry Reding , Broadcom internal kernel review list , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value Date: Thu, 5 Oct 2023 09:47:27 -0700 Message-Id: <20231005164728.1846726-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Check the clk_prepare_enable() return value and propagate it. Suggested-by: Uwe Kleine-König Signed-off-by: Florian Fainelli Reviewed-by: Uwe Kleine-König --- This change depends upon: https://lore.kernel.org/all/20231004175414.1738475-1-florian.fainelli@broadcom.com/ drivers/pwm/pwm-brcmstb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c index a7d529bf76ad..de9cbda2e4ff 100644 --- a/drivers/pwm/pwm-brcmstb.c +++ b/drivers/pwm/pwm-brcmstb.c @@ -297,9 +297,7 @@ static int brcmstb_pwm_resume(struct device *dev) { struct brcmstb_pwm *p = dev_get_drvdata(dev); - clk_prepare_enable(p->clk); - - return 0; + return clk_prepare_enable(p->clk); } #endif