From patchwork Wed Jan 9 08:27:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 1022321 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="0ojt3r09"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43ZMhQ5XJyz9sD9 for ; Wed, 9 Jan 2019 19:28:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729281AbfAII2G (ORCPT ); Wed, 9 Jan 2019 03:28:06 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:43404 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbfAII2G (ORCPT ); Wed, 9 Jan 2019 03:28:06 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x098JMI3059115; Wed, 9 Jan 2019 08:28:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2018-07-02; bh=upVnPgacJIIOVpTSodocmZe3tFvW3Lv1ZXgzbWsOxKs=; b=0ojt3r09Q/Rl6YymXuPC2MLiWU6Rz9T7wzKDvBC0YP4Lsf+zBdU07JRsvF1LWfzmMYB1 Cm/Nv5+LXgXuvdJ/bMvN9J8hLw9Pjb0P9Il7kfMd3+qRDXq9Au7xr1ktbBddCqs4PCxs S3q1QjogSKiDzW9AzJ28EMj6zS9d7M16RHLOb9MBU9biwOJ0PLx4OR6xkHvUok05DwPS 6KN+58fKM4pK1JyQYzlyobd/B8M39vih2ZD7EylfMI+BZ/wbhcDxRZxJAu9K1vsLXbBR r1zNbXftC4sC2kK7wzvHkogN1YxYvax3W27p77Jwi/GNkDh4+M2QFfKuLjT5sDdkA0+n 1Q== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2ptm0u7ysh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Jan 2019 08:28:01 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x098RtYd002959 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jan 2019 08:27:56 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x098Rtqo001579; Wed, 9 Jan 2019 08:27:55 GMT Received: from kadam (/41.202.241.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 Jan 2019 00:27:55 -0800 Date: Wed, 9 Jan 2019 11:27:47 +0300 From: Dan Carpenter To: Thierry Reding , Anson Huang Cc: linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] pwm: imx: Signedness bug in imx_pwm_get_state() Message-ID: <20190109082747.GA5476@kadam> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9130 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=957 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901090072 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org "ret" only holds zero and negative error codes. It needs to be signed for the error handling to work. Fixes: 9f4c8f9607c3 ("pwm: imx: Add ipg clock operation") Signed-off-by: Dan Carpenter Reviewed-by: Uwe Kleine-König --- drivers/pwm/pwm-imx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index 55a3a363d5be..b8452abe2392 100644 --- a/drivers/pwm/pwm-imx.c +++ b/drivers/pwm/pwm-imx.c @@ -128,8 +128,9 @@ static void imx_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, struct pwm_state *state) { struct imx_chip *imx = to_imx_chip(chip); - u32 period, prescaler, pwm_clk, ret, val; + u32 period, prescaler, pwm_clk, val; u64 tmp; + int ret; ret = imx_pwm_clk_prepare_enable(chip); if (ret < 0)