| Message ID | 20240605203507.1934434-1-tgamblin@baylibre.com |
|---|---|
| Headers | show |
| Series | pwm: add axi-pwm-gen driver | expand |
Hello Trevor, On Wed, Jun 05, 2024 at 04:35:04PM -0400, Trevor Gamblin wrote: > Resending due to missing real name in "From:" line. > > This series adds support for the AXI PWM GEN subsystem found on FPGA IP > cores. It can be used to generate configurable PWM outputs, and includes > options for external synchronization and clock signals. The work is > being done on behalf of, and therefore lists maintainers from Analog > Devices, Inc. > > The series has been tested on actual hardware using an EVAL-AD7985FMCZ > evaluation board. An oscilloscope was used to validate that the > generated PWM signal matched the requested one. > > There was previously a follow-up series > (https://lore.kernel.org/linux-pwm/20240314204722.1291993-1-tgamblin@baylibre.com/) > that enabled support for two different versions of the AXI PWM GEN IP. > Since issues were identified with the v1 IP functionality and v2's > regmap is the one listed on the device wiki > (https://analogdevicesinc.github.io/hdl/library/axi_pwm_gen/index.html), > the driver was changed to support only the v2 IP after squashing those > additions. As a result, the overall driver is simpler as it no longer > uses an axi_pwm_variant struct. Support for v1 IP can be added back > later in the event that it is required. I found a minor nitpick in your patch. I applied it anyhow and jumped at the patch opportunity myself. Patch in your inbox (or at https://lore.kernel.org/linux-pwm/20240606164047.534741-6-u.kleine-koenig@baylibre.com) Best regards and thanks for your contribution! Uwe
Resending due to missing real name in "From:" line. This series adds support for the AXI PWM GEN subsystem found on FPGA IP cores. It can be used to generate configurable PWM outputs, and includes options for external synchronization and clock signals. The work is being done on behalf of, and therefore lists maintainers from Analog Devices, Inc. The series has been tested on actual hardware using an EVAL-AD7985FMCZ evaluation board. An oscilloscope was used to validate that the generated PWM signal matched the requested one. There was previously a follow-up series (https://lore.kernel.org/linux-pwm/20240314204722.1291993-1-tgamblin@baylibre.com/) that enabled support for two different versions of the AXI PWM GEN IP. Since issues were identified with the v1 IP functionality and v2's regmap is the one listed on the device wiki (https://analogdevicesinc.github.io/hdl/library/axi_pwm_gen/index.html), the driver was changed to support only the v2 IP after squashing those additions. As a result, the overall driver is simpler as it no longer uses an axi_pwm_variant struct. Support for v1 IP can be added back later in the event that it is required. --- v6 changes: * Address feedback for driver in v5: * Add link to public device documentation in pwm-axi-pwmgen.c * Remove unnecessary line split in axi_pwmgen_setup * Remove unnecessary call to devm_add_action_or_reset() in axi_pwmgen_probe * Update documentation link in driver and binding commit messages Link to v5: https://lore.kernel.org/linux-pwm/20240424125850.4189116-1-tgamblin@baylibre.com/ v5 changes: * Address feedback for driver in v4: * Clarify device behavior in frontmatter * Include register name in bitfield definitions * Use devm_clk_rate_exclusive_get() and handle error * Squash v2 IP patches into series from: https://lore.kernel.org/linux-pwm/20240314204722.1291993-1-tgamblin@baylibre.com/ * Refactor driver code to support only v2 IP * Issues were identified with v1 IP implementation, so only v2 will be supported * Remove axi_pwm_variant struct and usage * Version check in axi_pwmgen_setup() left as-is to limit usage to * only v2 IP * Adjust dt bindings to use adi,axi-pwmgen-2.00.a Link to v4: https://lore.kernel.org/linux-pwm/20240301173343.1086332-1-tgamblin@baylibre.com/ v4 changes: * Address feedback for driver in v3: * Update to use devm_pwmchip_alloc() function * Simplify use of dev symbol in axi_pwmgen_probe * Remove unnecessary axi_pwmgen_from_chip function and use pwmchip_get_drvdata directly Link to v3: https://lore.kernel.org/linux-pwm/20240131214042.1335251-1-tgamblin@baylibre.com/ v3 changes: * Address feedback for driver in v2: * Remove unnecessary blank line in axi_pwmgen_apply * Use macros already defined in <linux/fpga/adi-axi-common.h> for version checking Link to v2: https://lore.kernel.org/linux-pwm/20240123220515.279439-1-tgamblin@baylibre.com/ v2 changes: * Address feedback for driver and device tree in v1: * Use more reasonable Kconfig approach * Use common prefixes for all functions * Rename axi_pwmgen struct to axi_pwmgen_ddata * Change use of "pwm" to "ddata" * Set and check state->polarity * Multiply safely with mul_u64_u64_div_u64() * Improve handling of max and zero periods * Error if clk_rate_hz > NSEC_PER_SEC * Add "Limitations" section at top of pwm-axi-pwmgen.c * Don't disable outputs by default * Remove unnecessary macros for period, duty, offset * Fix axi_pwmgen_ddata alignment * Don't artificially limit npwm to four * Use clk_rate_exclusive_get(), balance with clk_rate_exclusive_put() * Cache clk rate in axi_pwmgen_ddata * Don't assign pwm->chip.base, do assign pwm->chip.atomic * Relocate "unevaluatedProperties" in device tree binding * Remove redundant calls to clk_get_rate * Test contents of AXI_PWMGEN_REG_CORE_MAGIC instead of arbitrary AXI_PWMGEN_TEST_DATA in AXI_PWMGEN_REG_SCRATCHPAD * Remove redundant clk struct from axi_pwmgen_ddata * Add self as module author * Add major version check for IP core Link to v1: https://lore.kernel.org/linux-pwm/20240115201222.1423626-1-tgamblin@baylibre.com/ Drew Fustini (2): dt-bindings: pwm: Add AXI PWM generator pwm: Add driver for AXI PWM generator .../bindings/pwm/adi,axi-pwmgen.yaml | 48 ++++ MAINTAINERS | 9 + drivers/pwm/Kconfig | 13 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-axi-pwmgen.c | 241 ++++++++++++++++++ 5 files changed, 312 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml create mode 100644 drivers/pwm/pwm-axi-pwmgen.c