From patchwork Mon Nov 18 11:00:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= X-Patchwork-Id: 1196662 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="seaSPzcW"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47GmG31Mbfz9sPW for ; Mon, 18 Nov 2019 22:00:43 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726695AbfKRLAm (ORCPT ); Mon, 18 Nov 2019 06:00:42 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40413 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbfKRLAm (ORCPT ); Mon, 18 Nov 2019 06:00:42 -0500 Received: by mail-wr1-f65.google.com with SMTP id q15so6090151wrw.7; Mon, 18 Nov 2019 03:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CwG2QKBTPng2ELiNtc6lBmywHFbDH68p/PbyzwMke0w=; b=seaSPzcWW7pAe6mvpfNGIERNdtwFtoRJGER3FNZ3pjh5BXyy25wIBOIe1jm0Ppszfb +M7hxsDAsA8Xwp0E8MLUAISuM3CF/CY5Pn4G+aerOUO2QlsVvjf/DuExFwDUSagUZ32Y RAHkot59E2fxg1rzppEHTVw/Q6AI54xRVOVtB1m3fgl1hNYFB3nV1BXhutcmcDkNnWgE 4IV2f/zR9onY7jrj0y5x9BzMKSdUaCVVHqYWsQg4xA8ertEw/gTZFYGBbzQ4nWAB3K7y 1qVtTTRNXvvxQVI95tyVxxI4Xz3Vg7nbp6T1CqAA6+GiK+AaZLYynnIL7teVHqL9iEAd lILQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CwG2QKBTPng2ELiNtc6lBmywHFbDH68p/PbyzwMke0w=; b=oxZ4IpVYfvqwM2152QH4hdcTh1PdwvELWsC4Q9IQlYm80i3KKfFX+0pVQcDO8AG2E1 t5vlsW7LRlloXi0KBuh1EmWgyvDUeUjuwx7a+L7EF/7jiagSQy2ZIiK41Cr/H9FdQKv8 G/8BXGklP/83IRZrEjK5+8R5wRYoAYHwpKXrOq6bZOZaDOq+ftEC43Gjlymd1lPKHJXn DtAvL2/WyHRRLKdCvzkoUiK3mHk45Y+KpSvftNKfI5/L6GjIzfZy1OlPhFZDOWizjRy/ +t6BGS6vNzoX0sRoK85nov1jFprFx1XPFAD8mndk6k52mIDMJcEHPRNR7b/YA9dCyZ2L N4qw== X-Gm-Message-State: APjAAAUWgSVPLFAuyU+obJwEe+vLHPyKCmXcahjt7CitkIJgB/K28uRz E68cpzh4ooG2EnKTAUcLnbM= X-Google-Smtp-Source: APXvYqy51ZqGdaG0m12s1h+XihVJJ3jXrIA+ItvBShJOBrCbxAo7ED8x2y4bje26IMScyYqPIzMP/g== X-Received: by 2002:adf:b608:: with SMTP id f8mr27742764wre.99.1574074839807; Mon, 18 Nov 2019 03:00:39 -0800 (PST) Received: from clement-Latitude-7490.outsight.local (lputeaux-656-1-11-33.w82-127.abo.wanadoo.fr. [82.127.142.33]) by smtp.gmail.com with ESMTPSA id f67sm19873313wme.16.2019.11.18.03.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 03:00:39 -0800 (PST) From: =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K?= =?utf-8?b?w7ZuaWc=?= , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Philipp Zabel Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, =?utf-8?b?Q2zDqW1lbnQgUMOpcm9u?= Subject: [PATCH v6 0/8] Add support for H6 PWM Date: Mon, 18 Nov 2019 12:00:26 +0100 Message-Id: <20191118110034.19444-1-peron.clem@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Hi, This is a rework of Jernej's previous work[1] taking account all the previous remarks. Bindings is still strict but probe in the driver are now optionnals. If someone could confirm that the PWM is not broken, as my board doesn't output it. I didn't add the acked-tags as there are big changes. Thanks, Clément Jernej's cover: Allwinner H6 SoC has PWM core which is basically the same as that found in A20, it's just depends on additional bus clock and reset line. This series adds support for it and extends PWM driver functionality in a way that it's now possible to bypass whole core and output PWM source clock directly as a PWM signal. This functionality is needed by AC200 chip, which is bundled in same physical package as H6 SoC, to serve as a clock source of 24 MHz. AC200 clock input pin is bonded internally to the second PWM channel. I would be grateful if anyone can test this patch series for any kind of regression on other SoCs. [1]: https://patchwork.kernel.org/cover/11061737/ Changes in v6: - Update git commit log - Distinguish error message Changes in v5: - Move bypass calculation to pwm_calculate - Split mod_clock fallback from bus_clk probe - Update comment - Move my SoB after acked-by/reviewed-by Changes in v4: - item description in correct order and add a blank line - use %pe for printing PTR_ERR - don't print error when it's an EPROBE_DEFER - change output clock bypass formula to match PWM policy Changes in v3: - Documentation update to allow one clock without name - Change reset optional to shared - If reset probe failed return an error - Remove old clock probe - Update bypass enabled formula Changes in v2: - Remove allOf in Documentation - Add H6 example in Documentation - Change clock name from "pwm" to "mod" - Change reset quirk to optional probe - Change bus_clock quirk to optional probe - Add limitation comment about mod_clk_output - Add quirk for mod_clk_output - Change bypass formula Clément Péron (2): pwm: sun4i: Prefer "mod" clock to unnamed [DO NOT MERGE] arm64: allwinner: h6: enable Beelink GS1 PWM Jernej Skrabec (6): dt-bindings: pwm: allwinner: Add H6 PWM description pwm: sun4i: Add an optional probe for reset line pwm: sun4i: Add an optional probe for bus clock pwm: sun4i: Add support to output source clock directly pwm: sun4i: Add support for H6 PWM arm64: dts: allwinner: h6: Add PWM node .../bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 48 +++++ .../dts/allwinner/sun50i-h6-beelink-gs1.dts | 4 + arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 10 + drivers/pwm/pwm-sun4i.c | 185 +++++++++++++++--- 4 files changed, 215 insertions(+), 32 deletions(-)