From patchwork Fri Dec 7 17:24:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Pimentel X-Patchwork-Id: 1009586 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=synopsys.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=synopsys.com header.i=@synopsys.com header.b="VwUZmCjr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43BK902ghbz9s3C for ; Sat, 8 Dec 2018 04:24:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726076AbeLGRYv (ORCPT ); Fri, 7 Dec 2018 12:24:51 -0500 Received: from smtprelay.synopsys.com ([198.182.47.9]:41358 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbeLGRYv (ORCPT ); Fri, 7 Dec 2018 12:24:51 -0500 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id E934A24E2048; Fri, 7 Dec 2018 09:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1544203490; bh=cV1TWCidK3fYmQj/SuoTDm9CKiCSAw0hssfRoR+tW/A=; h=From:To:Cc:Subject:Date:From; b=VwUZmCjrOhErMiW+M/QmNolkFWEV/0tew0VnTui4U2GhSItE8CVL9K9bnRJA04PsR FMy9+atAKBqLA/or/jU56iUUpuiPTXG402ig2KyOZuv62t/FZQ3EEXGhYStARk5H2S +a4vf7/2YdhuBDYzHl9w7778/Fe00I7iBx9WtfE0CKy+JtzL1ti953/loVL3Z4Jno3 3JoloH44CNhjjE/dMOIEHTn1kHVwP0FKBPgs9z8dL67Puw8hpnKSfYnIUK6s9zXE52 XEFizD51qTK5R0rOmPkyDHdBVhd8GZLbe6r/91ofjiAv50/KyZiTwOMt0g5SGAR2kX srtwp50ZisKmA== Received: from de02.synopsys.com (germany.internal.synopsys.com [10.225.17.21]) by mailhost.synopsys.com (Postfix) with ESMTP id B14C1367C; Fri, 7 Dec 2018 09:24:50 -0800 (PST) Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by de02.synopsys.com (Postfix) with ESMTP id ED57D3E83B; Fri, 7 Dec 2018 18:24:49 +0100 (CET) From: Gustavo Pimentel To: lorenzo.pieralisi@arm.com Cc: Gustavo Pimentel , Jingoo Han , Bjorn Helgaas , Joao Pinto , linux-pci@vger.kernel.org Subject: [PATCH v2] PCI: dwc: Print debug error message when MSI-X entry control mask bit is set Date: Fri, 7 Dec 2018 18:24:37 +0100 Message-Id: X-Mailer: git-send-email 2.7.4 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Add debug error message when MSI-X entry control mask bit is set, to help debug the reason why a MSI-X interrupt is not being triggered. Cc: Jingoo Han Cc: Bjorn Helgaas Cc: Joao Pinto Cc: linux-pci@vger.kernel.org Signed-off-by: Gustavo Pimentel --- drivers/pci/controller/dwc/pcie-designware-ep.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index 1e7b022..a969322 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -466,8 +466,10 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, iounmap(msix_tbl); - if (vec_ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT) + if (vec_ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT) { + dev_dbg(pci->dev, "MSI-X entry ctrl set\n"); return -EPERM; + } ret = dw_pcie_ep_map_addr(epc, func_no, ep->msi_mem_phys, msg_addr, epc->mem->page_size);