| Message ID | a5f26b59ae720edf4f3b90e4ee2d052e2920dca9.1544203477.git.gustavo.pimentel@synopsys.com |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | [v2] PCI: dwc: Print debug error message when MSI-X entry control mask bit is set | expand |
On Fri, Dec 07, 2018 at 06:24:37PM +0100, Gustavo Pimentel wrote: > Add debug error message when MSI-X entry control mask bit is set, to help > debug the reason why a MSI-X interrupt is not being triggered. > > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Joao Pinto <joao.pinto@synopsys.com> > Cc: linux-pci@vger.kernel.org > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied to pci/dwc for v5.1, thanks. Lorenzo > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > index 1e7b022..a969322 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > @@ -466,8 +466,10 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, > > iounmap(msix_tbl); > > - if (vec_ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT) > + if (vec_ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT) { > + dev_dbg(pci->dev, "MSI-X entry ctrl set\n"); > return -EPERM; > + } > > ret = dw_pcie_ep_map_addr(epc, func_no, ep->msi_mem_phys, msg_addr, > epc->mem->page_size); > -- > 2.7.4 >
diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index 1e7b022..a969322 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -466,8 +466,10 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, iounmap(msix_tbl); - if (vec_ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT) + if (vec_ctrl & PCI_MSIX_ENTRY_CTRL_MASKBIT) { + dev_dbg(pci->dev, "MSI-X entry ctrl set\n"); return -EPERM; + } ret = dw_pcie_ep_map_addr(epc, func_no, ep->msi_mem_phys, msg_addr, epc->mem->page_size);
Add debug error message when MSI-X entry control mask bit is set, to help debug the reason why a MSI-X interrupt is not being triggered. Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Joao Pinto <joao.pinto@synopsys.com> Cc: linux-pci@vger.kernel.org Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> --- drivers/pci/controller/dwc/pcie-designware-ep.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)