From patchwork Tue Nov 24 12:08:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriele Paoloni X-Patchwork-Id: 548026 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A65EE140316 for ; Tue, 24 Nov 2015 23:09:55 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752922AbbKXMJo (ORCPT ); Tue, 24 Nov 2015 07:09:44 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:51575 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbbKXMJm (ORCPT ); Tue, 24 Nov 2015 07:09:42 -0500 Received: from 172.18.7.190 (EHLO lhreml402-hub.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CAS89698; Tue, 24 Nov 2015 12:08:26 +0000 (GMT) Received: from LHREML503-MBS.china.huawei.com ([10.125.30.104]) by lhreml402-hub.china.huawei.com ([10.201.5.241]) with mapi id 14.03.0235.001; Tue, 24 Nov 2015 12:08:17 +0000 From: Gabriele Paoloni To: Kishon Vijay Abraham I , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "james.morse@arm.com" , "gabriel.fernandez@st.com" , "Minghuan.Lian@freescale.com" , "Wangzhou (B)" , "arnd@arndb.de" , "bhelgaas@google.com" , "pratyush.anand@gmail.com" , "Nori, Sekhar" , "jingoohan1@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: RE: PCIe regression with DRA7xx in 4.4-rc1 Thread-Topic: PCIe regression with DRA7xx in 4.4-rc1 Thread-Index: AQHRJrAKzKfV4L7ulEiASIyKCdbvRJ6rE62w Date: Tue, 24 Nov 2015 12:08:17 +0000 Message-ID: References: <56545183.8000507@ti.com> In-Reply-To: <56545183.8000507@ti.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.137.242] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.5654533D.01BA, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 2f09352ef6ccc90cb6cd7a9cacf404e2 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Kishon > -----Original Message----- > From: Kishon Vijay Abraham I [mailto:kishon@ti.com] > Sent: 24 November 2015 12:01 > To: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > omap@vger.kernel.org; james.morse@arm.com; gabriel.fernandez@st.com; > Minghuan.Lian@freescale.com; Wangzhou (B); Gabriele Paoloni; arnd@arndb.de; > bhelgaas@google.com; pratyush.anand@gmail.com; Nori, Sekhar; > jingoohan1@gmail.com; linux-arm-kernel@lists.infradead.org > Subject: PCIe regression with DRA7xx in 4.4-rc1 > > Hi, > > I'm seeing a regression with ("PCI: > designware: Make driver arch-agnostic"). > > Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that > I > observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O > error, err_mask=0x4)" > May this be related to the bug flagged in: [PATCH] PCI: designware: remove wrong io_base assignment [...] -- 1.7.9.5 [...] Can you try to see if applying the patch above solves the issue? Thanks Gab > Logs using a Ethenet PCIe card [2]. Again here the PCIe card enumerates fine > but when I give ifconfig up, it fails. > > If I just revert commit , the PCIe > cards starts to work fine again > > Logs using a SATA PCIe card [3]. Here the KINGSTON SSD gets detected fine. > Logs using a Ethernet PCIe card [4]. I'm able to do ping tests now. > > Actually I'm not able to find any obvious problems with the patch and the irq > number and the memory resource also looks fine. Any idea what could be the > problem? > > [1] -> http://pastebin.ubuntu.com/13491456/ > [2] -> http://pastebin.ubuntu.com/13491526/ > > [3] -> http://pastebin.ubuntu.com/13491658/ > [4] -> http://pastebin.ubuntu.com/13491593/ > > Thanks > Kishon diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 540f077c37ea..02a7452bdf23 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp) ret, pp->io); continue; } - pp->io_base = pp->io->start; break; case IORESOURCE_MEM: pp->mem = win->res;