@@ -407,12 +407,6 @@ static void mtk_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
(int)data->hwirq, msg->address_hi, msg->address_lo);
}
-static int mtk_msi_set_affinity(struct irq_data *irq_data,
- const struct cpumask *mask, bool force)
-{
- return -EINVAL;
-}
-
static void mtk_msi_ack_irq(struct irq_data *data)
{
struct mtk_pcie_port *port = irq_data_get_irq_chip_data(data);
@@ -424,7 +418,6 @@ static void mtk_msi_ack_irq(struct irq_data *data)
static struct irq_chip mtk_msi_bottom_irq_chip = {
.name = "MTK MSI",
.irq_compose_msi_msg = mtk_compose_msi_msg,
- .irq_set_affinity = mtk_msi_set_affinity,
.irq_ack = mtk_msi_ack_irq,
};
@@ -486,8 +479,8 @@ static struct irq_chip mtk_msi_irq_chip = {
};
static struct msi_domain_info mtk_msi_domain_info = {
- .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
- MSI_FLAG_PCI_MSIX),
+ .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
+ MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
.chip = &mtk_msi_irq_chip,
};
Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without printing "IRQ...: set affinity failed(-22)" warning. Remove .irq_set_affinity implementation which only return -EINVAL from this controller driver. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: "Krzysztof Wilczyński" <kw@linux.com> Cc: "Pali Rohár" <pali@kernel.org> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Aleksandr Mishin <amishin@t-argos.ru> Cc: Anna-Maria Behnsen <anna-maria@linutronix.de> Cc: Anup Patel <apatel@ventanamicro.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> Cc: Daire McNamara <daire.mcnamara@microchip.com> Cc: Damien Le Moal <dlemoal@kernel.org> Cc: Florian Fainelli <florian.fainelli@broadcom.com> Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> Cc: Jianjun Wang <jianjun.wang@mediatek.com> Cc: Jim Quinlan <jim2101024@gmail.com> Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com> Cc: Jon Hunter <jonathanh@nvidia.com> Cc: Jonathan Derrick <jonathan.derrick@linux.dev> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Joyce Ooi <joyce.ooi@intel.com> Cc: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in> Cc: Kishon Vijay Abraham I <kishon@kernel.org> Cc: Koichiro Den <den@valinux.co.jp> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: Marc Zyngier <maz@kernel.org> Cc: Michal Simek <michal.simek@amd.com> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> Cc: Niklas Cassel <cassel@kernel.org> Cc: Nipun Gupta <nipun.gupta@amd.com> Cc: Nirmal Patel <nirmal.patel@linux.intel.com> Cc: Rob Herring <robh@kernel.org> Cc: Ryder Lee <ryder.lee@mediatek.com> Cc: Shivamurthy Shastri <shivamurthy.shastri@linutronix.de> Cc: Siddharth Vadapalli <s-vadapalli@ti.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-pci@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-tegra@vger.kernel.org --- V4: - New patch --- drivers/pci/controller/pcie-mediatek.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)