Message ID | 20240723132958.41320-13-marek.vasut+renesas@mailbox.org |
---|---|
State | New |
Headers | show |
Series | genirq/msi: Silence set affinity failed warning | expand |
On Tue, 23 Jul 2024 15:27:12 +0200 Marek Vasut <marek.vasut+renesas@mailbox.org> wrote: > Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps > .irq_set_affinity unset and allows migrate_one_irq() code in > cpuhotplug.c to exit right away, without printing "IRQ...: set > affinity failed(-22)" warning. > > Remove .irq_set_affinity implementation which only return -EINVAL > from this controller driver. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > --- > Cc: "Krzysztof Wilczyński" <kw@linux.com> > Cc: "Pali Rohár" <pali@kernel.org> > Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> > Cc: Aleksandr Mishin <amishin@t-argos.ru> > Cc: Anna-Maria Behnsen <anna-maria@linutronix.de> > Cc: Anup Patel <apatel@ventanamicro.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Broadcom internal kernel review list > <bcm-kernel-feedback-list@broadcom.com> Cc: Daire McNamara > <daire.mcnamara@microchip.com> Cc: Damien Le Moal <dlemoal@kernel.org> > Cc: Florian Fainelli <florian.fainelli@broadcom.com> > Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> > Cc: Jianjun Wang <jianjun.wang@mediatek.com> > Cc: Jim Quinlan <jim2101024@gmail.com> > Cc: Jingoo Han <jingoohan1@gmail.com> > Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > Cc: Jon Hunter <jonathanh@nvidia.com> > Cc: Jonathan Derrick <jonathan.derrick@linux.dev> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Joyce Ooi <joyce.ooi@intel.com> > Cc: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in> > Cc: Kishon Vijay Abraham I <kishon@kernel.org> > Cc: Koichiro Den <den@valinux.co.jp> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: Marc Zyngier <maz@kernel.org> > Cc: Michal Simek <michal.simek@amd.com> > Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> > Cc: Niklas Cassel <cassel@kernel.org> > Cc: Nipun Gupta <nipun.gupta@amd.com> > Cc: Nirmal Patel <nirmal.patel@linux.intel.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Ryder Lee <ryder.lee@mediatek.com> > Cc: Shivamurthy Shastri <shivamurthy.shastri@linutronix.de> > Cc: Siddharth Vadapalli <s-vadapalli@ti.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-pci@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-tegra@vger.kernel.org > --- > V4: - New patch > --- > drivers/pci/controller/vmd.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/pci/controller/vmd.c > b/drivers/pci/controller/vmd.c index a726de0af011f..bc849b0d9e8dc > 100644 --- a/drivers/pci/controller/vmd.c > +++ b/drivers/pci/controller/vmd.c > @@ -204,22 +204,11 @@ static void vmd_irq_disable(struct irq_data > *data) raw_spin_unlock_irqrestore(&list_lock, flags); > } > > -/* > - * XXX: Stubbed until we develop acceptable way to not create > conflicts with > - * other devices sharing the same vector. > - */ > -static int vmd_irq_set_affinity(struct irq_data *data, > - const struct cpumask *dest, bool > force) -{ > - return -EINVAL; > -} > - > static struct irq_chip vmd_msi_controller = { > .name = "VMD-MSI", > .irq_enable = vmd_irq_enable, > .irq_disable = vmd_irq_disable, > .irq_compose_msi_msg = vmd_compose_msi_msg, > - .irq_set_affinity = vmd_irq_set_affinity, > }; > > static irq_hw_number_t vmd_get_hwirq(struct msi_domain_info *info, > @@ -326,7 +315,7 @@ static struct msi_domain_ops vmd_msi_domain_ops = > { > static struct msi_domain_info vmd_msi_domain_info = { > .flags = MSI_FLAG_USE_DEF_DOM_OPS | > MSI_FLAG_USE_DEF_CHIP_OPS | > - MSI_FLAG_PCI_MSIX, > + MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX, > .ops = &vmd_msi_domain_ops, > .chip = &vmd_msi_controller, > }; Reviewed-by: Nirmal Patel <nirmal.patel@linux.intel.com> Thanks.
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index a726de0af011f..bc849b0d9e8dc 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -204,22 +204,11 @@ static void vmd_irq_disable(struct irq_data *data) raw_spin_unlock_irqrestore(&list_lock, flags); } -/* - * XXX: Stubbed until we develop acceptable way to not create conflicts with - * other devices sharing the same vector. - */ -static int vmd_irq_set_affinity(struct irq_data *data, - const struct cpumask *dest, bool force) -{ - return -EINVAL; -} - static struct irq_chip vmd_msi_controller = { .name = "VMD-MSI", .irq_enable = vmd_irq_enable, .irq_disable = vmd_irq_disable, .irq_compose_msi_msg = vmd_compose_msi_msg, - .irq_set_affinity = vmd_irq_set_affinity, }; static irq_hw_number_t vmd_get_hwirq(struct msi_domain_info *info, @@ -326,7 +315,7 @@ static struct msi_domain_ops vmd_msi_domain_ops = { static struct msi_domain_info vmd_msi_domain_info = { .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | - MSI_FLAG_PCI_MSIX, + MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX, .ops = &vmd_msi_domain_ops, .chip = &vmd_msi_controller, };
Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without printing "IRQ...: set affinity failed(-22)" warning. Remove .irq_set_affinity implementation which only return -EINVAL from this controller driver. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: "Krzysztof Wilczyński" <kw@linux.com> Cc: "Pali Rohár" <pali@kernel.org> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Aleksandr Mishin <amishin@t-argos.ru> Cc: Anna-Maria Behnsen <anna-maria@linutronix.de> Cc: Anup Patel <apatel@ventanamicro.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com> Cc: Daire McNamara <daire.mcnamara@microchip.com> Cc: Damien Le Moal <dlemoal@kernel.org> Cc: Florian Fainelli <florian.fainelli@broadcom.com> Cc: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> Cc: Jianjun Wang <jianjun.wang@mediatek.com> Cc: Jim Quinlan <jim2101024@gmail.com> Cc: Jingoo Han <jingoohan1@gmail.com> Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com> Cc: Jon Hunter <jonathanh@nvidia.com> Cc: Jonathan Derrick <jonathan.derrick@linux.dev> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Joyce Ooi <joyce.ooi@intel.com> Cc: Karthikeyan Mitran <m.karthikeyan@mobiveil.co.in> Cc: Kishon Vijay Abraham I <kishon@kernel.org> Cc: Koichiro Den <den@valinux.co.jp> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: Marc Zyngier <maz@kernel.org> Cc: Michal Simek <michal.simek@amd.com> Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> Cc: Niklas Cassel <cassel@kernel.org> Cc: Nipun Gupta <nipun.gupta@amd.com> Cc: Nirmal Patel <nirmal.patel@linux.intel.com> Cc: Rob Herring <robh@kernel.org> Cc: Ryder Lee <ryder.lee@mediatek.com> Cc: Shivamurthy Shastri <shivamurthy.shastri@linutronix.de> Cc: Siddharth Vadapalli <s-vadapalli@ti.com> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-pci@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-tegra@vger.kernel.org --- V4: - New patch --- drivers/pci/controller/vmd.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)