From patchwork Mon Jul 8 17:08:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 1958066 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=n9ZDKSkq; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1; helo=sv.mirrors.kernel.org; envelope-from=linux-pci+bounces-9950-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WHrG3610Fz1xpd for ; Tue, 9 Jul 2024 03:09:47 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 91CAC280D1D for ; Mon, 8 Jul 2024 17:09:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C37B714B97E; Mon, 8 Jul 2024 17:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="n9ZDKSkq" X-Original-To: linux-pci@vger.kernel.org Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010015.outbound.protection.outlook.com [52.101.69.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAC0414B967; Mon, 8 Jul 2024 17:08:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720458519; cv=fail; b=tkAGkkXz5TDrxo6MkXVfIiTpOEdT3bdqDYiQLEdWZ9+FU7LxlcOn+qXNvGWupOTmWJwq96pPZyIllmiExz+tM4ADZsQD17+Fw+kis9AJgfjxKhKK5gSPD2pmEDTmhz64hiH3Av9Sx5TRO9dtWVYIJxWUM2mOmKTcA56Y7xE3AOU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720458519; c=relaxed/simple; bh=Jm6GeRMPxeTBPfJ2OeGnp/OweXbfacd9STdPEml5mz8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=p8es6rMmEAAqdCqNzDFYAF1afj/kO/sAW+HJ4H53uwhtUdL7KjRhM1QCduW8BN3Vx+nG+Za22oh/Ml6ybd6wTuLJ9RNpzeHuVFalw74T8+0HM8NycqyoHz24JzWu92Yv1Bi/G0oyiXXm1I4e9ltwu3TqsWeVLSXs7i69ddcAT30= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=n9ZDKSkq; arc=fail smtp.client-ip=52.101.69.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RhQjdnmIZINFQeTnbcvCvUUbLs9ZfT2qjETlNiyTfjFtAYCoZd3VMPsh6i6mpS430xGb+1rLTAYYZsFH+fFPJloI6JVU0VulRwKtNeX2KQwYTY82Xp80bcSpyeuKKjj28/1+Ff1rynF54hJ9Q1s2zvhH9PlezKtw/HFMUqvjNnRetRbVhpZgFZrw2OpkCFH8gvxTgWEqH7OEgmfQZ6FlAc4Ef8dsrxY2kIN3uiWE6v+PHnW906eaDQwr8qcC5ALnShN5qMp5cRpKcKob3bNqQxUqtyD0Z/Cmj5xIsMLkC3QrExLXaSCThvzdrMWLhvfGM7Zol2xJqHyGG7wJBnc+Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nmaevdNZlABMzm/iTBpcukEaFZ5SPA983fiKgGailbg=; b=DLqTuqBXzAi8I+0ZOY+WS7AK6gp/ubNaSpdiOUv2nENyfOm2woadrn+3MEmw1WNO1szmmCZ/5SVEVgMn3T5SBmhLWiu0Fey8uMiWaywdNlVAuGTE1KHI/Tyj8K4kv6z60RbyzDqkRyjU4zm/1s/Vw+++oYzl/4sMolkb+UzGM2hdzLnkyUM640Ozi66wLzW+g6T4+rFxVc9Uukgs3ULgl06Q5qEVnlODjJQT4lo2bjFT4KrkXWwSNzyZp7URnbtY1o1oskGcv45KIpAZJm9EalZLi86XQIm6uctkNTWOxyQWNHQ8lBMxuFI4Zt+fC+2kavyQJcxCI8kQJroe8zrT4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nmaevdNZlABMzm/iTBpcukEaFZ5SPA983fiKgGailbg=; b=n9ZDKSkqpP0oQ0bW1nxFOf/DLi8S8ptW/yx5OMqjbRCkEJBReOujfelm61lcwY9wC2vYEFP7ZwUDi3+uwpbAe3Ar864BLtvwU0l1WKp3K6TtATC1vkLD2iVq4VENfN/8qpYFnDNGuCszf7YBv8yy6//coOVXnl6j1qDSsgPWdek= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DBBPR04MB7867.eurprd04.prod.outlook.com (2603:10a6:10:1e5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Mon, 8 Jul 2024 17:08:35 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 17:08:35 +0000 From: Frank Li Date: Mon, 08 Jul 2024 13:08:06 -0400 Subject: [PATCH v7 02/10] PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI Message-Id: <20240708-pci2_upstream-v7-2-ac00b8174f89@nxp.com> References: <20240708-pci2_upstream-v7-0-ac00b8174f89@nxp.com> In-Reply-To: <20240708-pci2_upstream-v7-0-ac00b8174f89@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li , Jason Liu X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1720458497; l=1316; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=l14lKtYuaY1+3koIMWZcDAe9ZGgSegJpQYHD4eJEreI=; b=nGTCzoSrnG9T+MK3JZPMjCgvuInupZ10wJn1acT2nGO4CsBe7gZMW2HOvPwHp2Rzb0k3fUhNp MF3yxSZjlFVB6oUj/n8/b6Jy7/TNFUwNgx0tsUaI3XadIeJ/M49P5BT X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0198.namprd13.prod.outlook.com (2603:10b6:a03:2c3::23) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DBBPR04MB7867:EE_ X-MS-Office365-Filtering-Correlation-Id: bc482cd4-f661-4da4-913a-08dc9f709a13 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|52116014|7416014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?3T0QaUE9zNakRbzffIPF7QwLBQHqbCJ?= =?utf-8?q?qoF/9m6kzKCGxLUv/j0TkHhMgwHaXNlGWAG9AfTLHAYN4MX2q2XR55fVfjSkVvThO?= =?utf-8?q?PGP2iSEARD+LMqVR8OxLrUJiQc6NlkxdpHTASk9Ok6HWL2zCCQpSGxOTeBJLeCDUm?= =?utf-8?q?dctE6kJpeM7eat8W32R2/lb/ZlyJAzbQt77SLjm12zj7d0feQTtWw/TFuaaGnIqsN?= =?utf-8?q?2VGYYvHAqJguHl05WcVnR3iV2ZhWaNzOG3KpLcL5kyg6g6J0QrV0ZV8xW/1Ab2UgV?= =?utf-8?q?GLbh3W5C8YtTQ2rNQYXozuRrqvKS74kBBOeM2M6FkCAakIJLw5r5/F86kaNr/UrEH?= =?utf-8?q?7ZT/OtfFJE+hwA7wcsjRYCEB4JjzTJzwECIn1Y3fXfGZuRiNhA9G3oWSCMK/b937g?= =?utf-8?q?CpSM0yhV07MsEuEdLwz+GxmqLmfebWG5Wsx0IiDYUCCkg9zsWYEYvhn6dg7MfJoG8?= =?utf-8?q?WASRmrm5tivxAxJGljUCyntlkfBaJT7OzeGlZwgUrqV7oqbVDjGC3Hr6uNRmtsbog?= =?utf-8?q?isx+t2piYRr867X/SGeE37inWvjfLJjd9Q0/T9q1ZGJe5Gk27WX1AWymP1KNayqOw?= =?utf-8?q?9pAqhQgtkTmUqg+YY7j0+JwL3OrpsLj20LjmLPopow/HddGcEtbt4bzjj7QZi7e7F?= =?utf-8?q?qkIefuIWKFgHI9ziHUQyyTt83VnlTpcgf1GZO7V4K2I4Fh5tX5uFrCAiNSzMC944d?= =?utf-8?q?8seyz/yypcIhwpf0EDae6rAOANIfjAyKsiPgvBPe2zlyqBe7D48gIrGEW6j4MRnC1?= =?utf-8?q?C0q679y03yuTyUtDr6ReR28DxCL2JG8aY8oKXlu7Z0tOdaMfqmqrQLHLkEFq+KLmn?= =?utf-8?q?/V4cYIzjWpXX7Tvvu5oF+E2lmCiW1PerlMDgV0txbOAsCh8N2kvQ25HooLO3GbeTT?= =?utf-8?q?REFwAptcBMEmvYkLDNhqcP9VbgzouIgxjogkV0PMtNRQzGbs8CRi9+MIhwE0YUdlJ?= =?utf-8?q?DlWCmacJyRqU8Ww1eAJaUUsUrOcPLLyTzP1Vr64ec+OyQ22xixrSyXte3CADv+Dxc?= =?utf-8?q?2FONqRpSyqGFKKc6gZpDpADS5Jj49BcheR0gCdTr6n45+PA6ibbrEEPZrnj3PjO2q?= =?utf-8?q?zMOLOP5kwvMokW7DZaj2PVyjU18hXIxYgoxEdWx6oPYXTzyhKEPqFLMzA1uuioP0Z?= =?utf-8?q?i7SK51FOwcFeRKIkYsX3HxL23GlHBAXdJBIZ9G3a9K/U8/DlGvQNudfkZST+pkvi7?= =?utf-8?q?vXR7FvB/jKF07DCLh5M0E9v8IiaeLMpzIuag5eVI4/RCSRZMHQID6RLUJnWkK3dsz?= =?utf-8?q?dDmM8xikOUe5CPm7c7VPl/31GlO+F85l9KuUrT4+hPpyPJFUSPNCAwkGd5Fci4wVp?= =?utf-8?q?zpyslHKKvZVIvJ81JLykavx8O3S5mydwOGi84RwDAFiKYvtlC0FIjxQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(52116014)(7416014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?xZz/cca4BKPCzWns/dVNz1Z/VyKE?= =?utf-8?q?303ProVVDjxIeVo9PXm0xyul4MJUt+eAewtYlqe5C+XwgFTN/GnD4fffrBD01oWKk?= =?utf-8?q?MFrJZ3qKMpyZrVRNwspSTAac3dLOtA1yrKnsoN/tRPYFm+lVR7nI0VKbmrRhiNqtL?= =?utf-8?q?cVM3q3JybL9+5MiH3N2Jg3TXrps9B96APE0FuaXRNh1k9r0rZpebkpPzp5dUD5Dzv?= =?utf-8?q?hNbA6tsV/RCqs/TFgN41Mb39r28Ev0LXGORJNkuu9v/cbf4m10ggBpHOiHtI27OEa?= =?utf-8?q?tpOo51pJxWiziFIIIASXiKMq2/poemxel3H4JFhCIJXC0Oe5pjJI8QtVLqk3JeFgH?= =?utf-8?q?JE70OJHPrUG3Esoc4zczKELRrc6g+qZA+1bFF9yhO3eCE6pBnPZyQSQtJFaJ+4Gs/?= =?utf-8?q?aQilJm1ci3Uu+vhCphp3s9LH91bE0xqR3Rpg+PY3LqLZrhWNJEpWkPm8Y5mcQBmmQ?= =?utf-8?q?38ZQl2YSz5eer0FWTyfUgYA1uIT/9L6EFx01N64Bp1ZwZ6O7LC4M3smP+NJVGCw/D?= =?utf-8?q?m9bFSIdrYL+D7L4dzjzeHOMTrMSz9Yspfw7Pi8aVq7MRwkrY+BuDXStJL7r1yb8lx?= =?utf-8?q?l72oINJQ1/7Zq0ZEADjWQTuj+4ZBZExQGpNFZX3By7X3h53uzRRkgqvhQkERCWCld?= =?utf-8?q?6AfU3B+tBiTG1LvWGmGtIvRrHW5gfjqT3+jlRpl+PVHd92US1Ov8+eqi8C3AMuHmn?= =?utf-8?q?Vz9ig7BmqrxQwjGVOC/pmIQOCw56qAdNB8axTF5FXQRGYBZt8mmRbzB376K7ZFXm+?= =?utf-8?q?6Dw1BoFocc3VDA871U24E8USQttcSGpH6HDIYwaOiufgYxpLovrJFlFK1D+M4fQZs?= =?utf-8?q?Sc4CaqV6RGTeD8YaE940RTqdciOCfa6AGV9ybe8t6LKsc7zuIwXmpylaAvwWT6aG/?= =?utf-8?q?ZQt6pqMJ2xC5HhTSfwi5sljJ+ur5JcrGaAFEc6Ov/ohfXzZSosMHZpp8FOLc9mh2Z?= =?utf-8?q?2ahbJv4FlnztpxTvTvlw+OgBi1K56WnARCGFRIQMLIT+U+ZzpKfEcxpt4vQ+JGJd6?= =?utf-8?q?pBqBPcNh6bkenk8dxroeKB2Z3SZm88eFPStDEHv/E0TAusO/ZTJlV5NrvO0QurRrx?= =?utf-8?q?ekwyKS+hPR+dnMkwUwdU/wfeBD0iXAuC3wWK0fuaIOmb82dhgn4aMKKT099WCYcGS?= =?utf-8?q?6S8cV2uUzoq+6ZTn5eKKaQnJZhapKLEXFNK30mf1NPYCHz5xprwM6WjPcJiHfEk3s?= =?utf-8?q?K2Tl75IKl5BaAjzd/R83vlK2PjmJacnqXlxVCdQIjsbXIPrIZs0Edy5kUAU+fvBab?= =?utf-8?q?+uSLA3qOeXy4aHfTO/3S9a6FEMRVHGtFpIGdKRBVRjnAfyDIDFA9A0kM5er5C41HU?= =?utf-8?q?X+lnLtfGQCjF4lIgsBQabOI78NjxFMrPspomOIaekmbKa5UrIEM6KFFDsL0howXgL?= =?utf-8?q?uF0RVNxtC2DHZZIWIFu9CSw8+IjIsipbTVHJEnlPI+DRZQ2FYaSlPQcHRnaCdplbY?= =?utf-8?q?sbuhAJe2TNBsqYM/m3SWTlOxLAszK5oGFwPaVnS1OLHUJMexl+yhwy40=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc482cd4-f661-4da4-913a-08dc9f709a13 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 17:08:35.1151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6DU4ftsBgM3fdzyWuzx10FcUA8w2ljNSb4U1pS1cDUPSfhMgGPmMwy9/81fR6bzOeFAPA+Qq4zK9vJCMtqrH7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7867 From: Richard Zhu Correct occasional MSI triggering failures in i.MX8MP PCIe EP by applying the correct hardware outbound alignment requirement. The i.MX platform has a restriction about outbound address translation. The pci-epc-mem uses page_size to manage it. Set the correct page_size for i.MX platform to meet the hardware requirement, which is the same as inbound address alignment. Align it with epc_features::align. Fixes: 1bd0d43dcf3b ("PCI: imx6: Clean up addr_space retrieval code") Signed-off-by: Richard Zhu Acked-by: Jason Liu Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pci-imx6.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 9a71b8aa09b3c..ca9a000c9a96d 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1118,6 +1118,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie, if (imx6_check_flag(imx6_pcie, IMX6_PCIE_FLAG_SUPPORT_64BIT)) dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); + ep->page_size = imx6_pcie->drvdata->epc_features->align; + ret = dw_pcie_ep_init(ep); if (ret) { dev_err(dev, "failed to initialize endpoint\n");